This PR was merged into the 2.6 branch.
Discussion
----------
[HttpKernel] Fixed DumpDataCollector: dump.name for Windows file paths
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes?
| Fixed tickets |
| License | MIT
| Doc PR |
When using VarDumper on Windows files, the automatic "dump.name" generated wrong names.
`dump()` call in:
```
F:\HtDocs\demo\src\Acme\Controller\DemoController.php
```
Displayed:
```
dump()
in :\HtDocs\demo\src\Acme\Controller\DemoController.php line 35
```
Expected result is:
```
dump()
in DemoController.php line 35
```
The existing code in line 118 didn't use the variable from the previous line.
Commits
-------
a025dea Fix dump.name for Windows file paths
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes#13586).
Discussion
----------
[DX][Config] Changed return type definition for some methods of NodeDefinition
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12280
| License | MIT
Discussed in #12280
Commits
-------
89ca585 Changed return type definition for some methods of NodeDefinition
This PR was merged into the 2.3 branch.
Discussion
----------
fixed possible race condition when creating a directory
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #13228
| License | MIT
| Doc PR | n/a
Commits
-------
8542866 fixed possible race condition when creating a directory
This PR was merged into the 2.6 branch.
Discussion
----------
[WebProfilerBundle] fix html lint on (other) empty onclick
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
*This is for the empty onclick that appeared in 2.6*
The request collector has an empty onclick="" attribute
when {{ link }} isn't available. This tends to happen when
rendering the debug toolbar.
Commits
-------
58bd16c [WebProfilerBundle] fix html lint on (other) empty onclick
This PR was merged into the 2.3 branch.
Discussion
----------
[WebProfilerBundle] fix html lint on empty onclick
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
The request collector has an empty onclick="" attribute
when {{ link }} isn't available. This tends to happen when
rendering the debug toolbar.
Commits
-------
a3a2f15 [WebProfilerBundle] fix html linting on empty onclick
This PR was merged into the 2.6 branch.
Discussion
----------
[WebProfilerBundle] Fix for broken profiler layout
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
With the latest 2.6 the profiler layout is broken:
I am not sure what broke it...
Commits
-------
af0ea97 Fix for broken profiler layout
This PR was squashed before being merged into the 2.3 branch (closes#13691).
Discussion
----------
[Console] Added a little explaination about Command#interact()
This has confused some long time Symfony users recently: https://twitter.com/jmolivas/status/566283453264850945
| Q | A
| ------------- | ---
| Fixed tickets | -
| License | MIT
Commits
-------
38e7b72 [Console] Added a little explaination about Command#interact()
*This is for the empty onclick that appeared in 2.6*
The request collector has an empty onclick="" attribute
when {{ link }} isn't available. This tends to happen when
rendering the debug toolbar.
This PR was merged into the 2.3 branch.
Discussion
----------
[Validator] Fixed: The state of the XML/YAML loaders was changed even if an exception was thrown upon loading
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12158
| License | MIT
| Doc PR | -
Commits
-------
85d464a [Validator] Fixed: The state of the XML/YAML loaders was changed even if an exception was thrown upon loading
This PR was merged into the 2.6 branch.
Discussion
----------
[WebProfilerBundle] Fixes event listener attaching error in IE
I haven't tested the change, because I don't any working Symfony installation at hand. By the looks of changes it should work.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | not sure (do we have JS tests?)
| Fixed tickets | #13447
| License | MIT
| Doc PR |
Commits
-------
21693e4 [WebProfilerBundle] Fixes event listener attaching error in IE
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes#13630).
Discussion
----------
[Console] fixed ArrayInput, if array contains 0 key.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
```php
$input = new ArrayInput(array('Fabien', '--foo' => 'bar'));
var_dump($input->getParameterOption('--foo')); // this is 'Fabien'.
```
Because `in_array` third argument's default is `false`.
`in_array(0, $values)` returns `true` in many cases.
Commits
-------
a642e4b [Console] fixed ArrayInput, if array contains 0 key.
* 2.3:
[FrameworkBundle] Fix title and placeholder rendering in php form templates.
RequestDataCollector - small fix
renamed composer.phar to composer to be consistent with the Symfony docs
[FrameworkBundle] bumped min version of Routing to 2.3
removed composer --dev option everywhere
fixed a test
[Console] Fixed output bug, if escaped string in a formatted string.
[Security] Remove ContextListener's onKernelResponse listener as it is used
Revert "minor #12652 [HttpFoundation] [Hackday] #9942 test: Request::getContent() for null value (skler)"
Revert "fixed assertion"
fixed assertion
[HttpFoundation] [Hackday] #9942 test: Request::getContent() for null value
fixed URL
Add reference to documentation in FormEvents phpdocs
[YAML] Fix one-liners to work with multiple new lines
Keep "pre" meaning for var_dump quick-and-dirty debug
[Console][Table] Fix cell padding with multi-byte
Conflicts:
src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/widget_attributes.html.php
src/Symfony/Bundle/FrameworkBundle/composer.json
src/Symfony/Component/Console/Helper/TableHelper.php
This PR was merged into the 2.3 branch.
Discussion
----------
[FrameworkBundle] Fix title and placeholder rendering in php form templates
Small fix for rendering placeholder on widgets in php templates.
| Q | A |
| ------------- | --- |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | no |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
This is a test case for #13290, including a fix applied on 2.3, since that's the earliest supported branch the bug exist.
In 2.6 the template is a bit different, and unfortunately I couldn't re-use #13290's fix.
When this is merged into 2.3, and then to 2.6 I think we can also merge #13290.
Commits
-------
f82193d [FrameworkBundle] Fix title and placeholder rendering in php form templates.
This PR was submitted for the 2.7 branch but it was merged into the 2.6 branch instead (closes#13638).
Discussion
----------
[TwigBridge] Removed duplicated code from TwigRenderer
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
See https://github.com/symfony/symfony/blob/2.7/src/Symfony/Component/Form/FormRenderer.php#L65-L69
Commits
-------
1a9aca7 [TwigBridge] Removed duplicated code from TwigRenderer
This PR was merged into the 2.6 branch.
Discussion
----------
Fix form icon position in web profiler
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Form icon in web profiler toolbar moved to the left edge
This fix changes icon position to its default value.
Commits
-------
b128439 Fix form icon position in web profiler
This PR was merged into the 2.3 branch.
Discussion
----------
removed composer --dev option everywhere
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
0fe4913 renamed composer.phar to composer to be consistent with the Symfony docs
af59316 removed composer --dev option everywhere
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#13629).
Discussion
----------
RequestDataCollector - small fix
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
7ed48db RequestDataCollector - small fix
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes#13607).
Discussion
----------
[Console] Fixed output bug, if escaped string in a formatted string.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
If there is a escaped tag in a formatted string, the output wasn't correct.
I have add a test for this problem and integrated a solution for this.
Commits
-------
1c62eb7 [Console] Fixed output bug, if escaped string in a formatted string.
This PR was submitted for the 2.7 branch but it was merged into the 2.6 branch instead (closes#13611).
Discussion
----------
[Console] “console help” ignores --raw option
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
The option for DescriptorHelper::describe() is `raw_text`, not `raw`.
Commits
-------
eabc5d8 “console help” ignores --raw option
