Commit Graph

36765 Commits

Author SHA1 Message Date
Thomas Calvet
fe15f51d4d [DoctrineBridge] Improve queries parameters display in Profiler 2019-11-16 19:56:08 +01:00
Nicolas Grekas
4ac626a482 Merge branch '4.3' into 4.4
* 4.3:
  [HttpFoundation] fix docblock
  Fix MySQL column type definition.
  Link the right file depending on the new version
  [Config] fix id-generation for GlobResource
  [Finder] Allow ssh2 stream wrapper for sftp
  [DI] Use reproducible entropy to generate env placeholders
  [WebProfilerBundle] Require symfony/twig-bundle
  bumped Symfony version to 4.3.9
  updated VERSION for 4.3.8
  updated CHANGELOG for 4.3.8
  bumped Symfony version to 3.4.36
  updated VERSION for 3.4.35
  updated CHANGELOG for 3.4.35
2019-11-16 16:22:42 +01:00
Nicolas Grekas
769aced459 Merge branch '3.4' into 4.3
* 3.4:
  Fix MySQL column type definition.
2019-11-16 16:18:16 +01:00
Nicolas Grekas
4d9b6f1bbd [HttpFoundation] fix docblock 2019-11-16 16:17:02 +01:00
Robin Chalas
585216a8e8 [HttpKernel] Flatten "exception" controller argument if not typed 2019-11-16 13:16:23 +01:00
Jérémie Broutier
51c5f69274 Fix MySQL column type definition.
Fix wrong MySQL column type definition causing Numeric value out of range exception.

Ref #34409
2019-11-16 12:41:30 +01:00
Nicolas Grekas
476042d0fb Merge branch '3.4' into 4.3
* 3.4:
  Link the right file depending on the new version
  [Finder] Allow ssh2 stream wrapper for sftp
  [WebProfilerBundle] Require symfony/twig-bundle
  bumped Symfony version to 3.4.36
  updated VERSION for 3.4.35
  updated CHANGELOG for 3.4.35
2019-11-16 10:07:40 +01:00
Nicolas Grekas
278dcfb380 bug #34403 [Cache] Redis Tag Aware warn on wrong eviction policy (andrerom)
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Cache] Redis Tag Aware warn on wrong eviction policy

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| Deprecations? | no
| Tickets       | n.a.
| License       | MIT
| Doc PR        | n.a.

Adds validation to make sure Redis has been setup with the supported eviction policy to avoid surprises when cache suddenly is inconsistent.

This PR replaces #34178, and instead of checking in constructor and throwing it only checks on save, warns about this and refuses to save cache as suggested on the other PR.

TODO:
- [x] ~Adapt test setups for this to set correct eviction policy~ _It already uses default noeviction_

Commits
-------

e77f6de1e8 [Cache] Redis Tag Aware warn on wrong eviction policy
2019-11-16 09:53:59 +01:00
André R
e77f6de1e8 [Cache] Redis Tag Aware warn on wrong eviction policy 2019-11-16 09:53:52 +01:00
Nicolas Grekas
fda36e84b3 bug #34400 [HttpKernel] collect bundle classes, not paths (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] collect bundle classes, not paths

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34359
| License       | MIT
| Doc PR        | -

Commits
-------

7824d75ac3 [HttpKernel] collect bundle classes, not paths
2019-11-16 09:51:49 +01:00
Nicolas Grekas
a90de43a8e bug #34398 [Config] fix id-generation for GlobResource (nicolas-grekas)
This PR was merged into the 4.3 branch.

Discussion
----------

[Config] fix id-generation for GlobResource

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

I never encountered any issues related to this but still, it's a fix.

Commits
-------

6adbfa2ae7 [Config] fix id-generation for GlobResource
2019-11-16 09:51:12 +01:00
Nicolas Grekas
114a4b86ac bug #34404 [HttpClient] fix HttpClientDataCollector (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] fix HttpClientDataCollector

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34365
| License       | MIT
| Doc PR        | -

Commits
-------

f51adc53f8 [HttpClient] fix HttpClientDataCollector
2019-11-16 09:50:26 +01:00
Nicolas Grekas
f51adc53f8 [HttpClient] fix HttpClientDataCollector 2019-11-16 09:45:13 +01:00
Fabien Potencier
1374abd6e8 minor #34399 [HttpKernel] dont check cache freshness more than once per process (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] dont check cache freshness more than once per process

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

While running some functional tests in a loop, I noticed that half the time is spent computing cache freshness. This makes no sense - this mechanism is supposed to run once per process.

Here is the Blackfire comparison:
https://blackfire.io/profiles/compare/a4f2eb44-ae85-440b-ae87-edf43c2b2ef7/graph

![image](https://user-images.githubusercontent.com/243674/68955196-c5667780-07c5-11ea-9a19-f8e765664a8e.png)

Commits
-------

7f9556ce19 [HttpKernel] dont check cache freshness more than once per process
2019-11-15 18:39:48 +01:00
Nicolas Grekas
7824d75ac3 [HttpKernel] collect bundle classes, not paths 2019-11-15 17:50:43 +01:00
Nicolas Grekas
6adbfa2ae7 [Config] fix id-generation for GlobResource 2019-11-15 16:28:20 +01:00
Nicolas Grekas
7f9556ce19 [HttpKernel] dont check cache freshness more than once per process 2019-11-15 16:26:40 +01:00
Damien Alexandre
e6c9d77b63
[Finder] Allow ssh2 stream wrapper for sftp
Same fix as #28604 but for the ss2.sftp wrapper.
2019-11-15 15:28:29 +01:00
Fabien Potencier
ca9a3a41a3 bug #34389 [WebProfilerBundle] add FrameworkBundle requirement (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[WebProfilerBundle] add FrameworkBundle requirement

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34379
| License       | MIT
| Doc PR        |

Commits
-------

1752dd9432 add FrameworkBundle requirement
2019-11-15 12:26:07 +01:00
Nicolas Grekas
b8f8ac947e bug #34358 [Security] always check the token on non-lazy firewalls (nicolas-grekas, lyrixx)
This PR was merged into the 4.4 branch.

Discussion
----------

 [Security] always check the token on non-lazy firewalls

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34357
| License       | MIT
| Doc PR        |

Commits
-------

2c2632a04c [SecurityBundle] add tests with empty authenticator
797450d6b8 [Security] always check the token on non-lazy firewalls
2019-11-15 12:06:35 +01:00
Nicolas Grekas
6fd10771d9 bug #34390 [FrameworkBundle] fix wiring of httplug client (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] fix wiring of httplug client

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Closes https://github.com/symfony/recipes/issues/676
| License       | MIT
| Doc PR        | -

Commits
-------

d969d49292 [FrameworkBundle] fix wiring of httplug client
2019-11-15 12:03:34 +01:00
Nicolas Grekas
d969d49292 [FrameworkBundle] fix wiring of httplug client 2019-11-15 11:02:26 +01:00
Christian Flothmann
1752dd9432 add FrameworkBundle requirement 2019-11-15 10:12:35 +01:00
Grégoire Pineau
2c2632a04c [SecurityBundle] add tests with empty authenticator 2019-11-14 23:51:34 +01:00
Nicolas Grekas
797450d6b8 [Security] always check the token on non-lazy firewalls 2019-11-14 23:50:50 +01:00
Nicolas Grekas
600ae33262 [DI] Use reproducible entropy to generate env placeholders 2019-11-14 21:13:17 +01:00
Thomas Calvet
78dad79fec [WebProfilerBundle] Require symfony/twig-bundle 2019-11-14 16:04:06 +01:00
Maxime Steinhausser
abcf63aaa8 [Mailer] Add UPGRADE entry about the null transport DSN 2019-11-14 15:24:33 +01:00
Nicolas Grekas
2a2d2bc0c0 minor #34367 [Form] Allow symfony/service-contracts v2 (derrabus)
This PR was merged into the 4.4 branch.

Discussion
----------

[Form] Allow symfony/service-contracts v2

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

In Symfony 4.4 applications, the Form component currently prevents the installation of `symfony/service-contracts` 2.0.0. That should not be the case.

Commits
-------

4755e160be [Form] Allow symfony/service-contracts v2.
2019-11-14 09:55:14 +01:00
Fabien Potencier
2a91f28ed4 bug #34369 [FrameworkBundle] Disallow WebProfilerBundle < 4.4 (derrabus)
This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] Disallow WebProfilerBundle < 4.4

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34364
| License       | MIT
| Doc PR        | N/A

Commits
-------

3d2b589af9 [FrameworkBundle] Disallow WebProfilerBundle < 4.4.
2019-11-14 05:22:53 +01:00
Nicolas Grekas
eccb937d97 [DI] fix detecting singly implemented interfaces 2019-11-13 22:56:53 +01:00
Alexander M. Turek
3d2b589af9 [FrameworkBundle] Disallow WebProfilerBundle < 4.4. 2019-11-13 22:26:07 +01:00
Alexander M. Turek
4755e160be [Form] Allow symfony/service-contracts v2. 2019-11-13 22:07:47 +01:00
Fabien Potencier
29a2f17124 bumped Symfony version to 4.4.0 2019-11-13 10:18:19 +01:00
Fabien Potencier
8c47650d53 updated VERSION for 4.4.0-BETA2 2019-11-13 10:13:36 +01:00
Fabien Potencier
d863fc2b4b bumped Symfony version to 4.3.9 2019-11-13 10:11:31 +01:00
Fabien Potencier
3a50fa397d updated VERSION for 4.3.8 2019-11-13 10:07:28 +01:00
Fabien Potencier
8a68d2d358 bumped Symfony version to 3.4.36 2019-11-13 09:48:47 +01:00
Fabien Potencier
02257c8098 updated VERSION for 3.4.35 2019-11-13 09:44:50 +01:00
Nicolas Grekas
ae3552685d Merge branch '4.3' into 4.4
* 4.3:
  [Console] Constant STDOUT might be undefined.
  Allow returning null from NormalizerInterface::normalize
  [Security\Core] throw AccessDeniedException when switch user fails
  [Mime] fix guessing mime-types of files with leading dash
  [HttpFoundation] fix guessing mime-types of files with leading dash
  [VarExporter] fix exporting some strings
  [Cache] forbid serializing AbstractAdapter and TagAwareAdapter instances
  Use constant time comparison in UriSigner
2019-11-13 08:39:40 +01:00
Nicolas Grekas
983b5d1d5f Merge branch '3.4' into 4.3
* 3.4:
  [Console] Constant STDOUT might be undefined.
  Allow returning null from NormalizerInterface::normalize
2019-11-13 08:29:07 +01:00
Nicolas Grekas
32bde39f63 bug #34344 [Console] Constant STDOUT might be undefined (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[Console] Constant STDOUT might be undefined

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34341
| License       | MIT
| Doc PR        | N/A

Commits
-------

bb8c82c0b5 [Console] Constant STDOUT might be undefined.
2019-11-13 08:27:07 +01:00
Nicolas Grekas
53dc781814 minor #34340 Allow returning null from NormalizerInterface::normalize (teohhanhui)
This PR was merged into the 3.4 branch.

Discussion
----------

Allow returning null from NormalizerInterface::normalize

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes?
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

Looking at the code, it seems that a normalizer might be called with a `null` value for `$data`, and thus it's only sensible that it be allowed to return `null` too:

7064ff35f2/src/Symfony/Component/Serializer/Serializer.php (L141-L148)

Updating the phpdoc to match.

Commits
-------

1c8edc55ad Allow returning null from NormalizerInterface::normalize
2019-11-13 08:26:33 +01:00
Nicolas Grekas
bb8c82c0b5 [Console] Constant STDOUT might be undefined. 2019-11-13 08:12:39 +01:00
Yonel Ceruto
5db0981fd9 Add missing conflict with symfony/serializer <4.4 2019-11-12 14:08:04 -05:00
Teoh Han Hui
1c8edc55ad
Allow returning null from NormalizerInterface::normalize 2019-11-12 18:51:12 +01:00
Fabien Potencier
839c6b4256 bumped Symfony version to 4.4.0 2019-11-12 18:50:34 +01:00
Fabien Potencier
88927e1640 updated VERSION for 4.4.0-BETA1 2019-11-12 18:37:44 +01:00
Thomas Calvet
47bd32e16f Fix some \Throwable support remaining issues 2019-11-12 18:18:47 +01:00
Nicolas Grekas
7cee181e08 feature #34333 Revert "feature #34329 [ExpressionLanguage] add XOR operator (ottaviano)" (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

Revert "feature #34329 [ExpressionLanguage] add XOR operator (ottaviano)"

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

This reverts commit d1d4bc8bad, reversing
changes made to f63976fcbb.

Commits
-------

adb716dd2c Revert "feature #34329 [ExpressionLanguage] add XOR operator (ottaviano)"
2019-11-12 15:57:18 +01:00