Archived

forked from https://github.com/symfony/symfony

This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Go to file

Fabien Potencier 063e6f9ae6 merged branch Seldaek/commands (PR #1470 ) Commits ------- `d675c28` [FrameworkBundle] Use Router instead of RouterInterface `ae7ae8d` [FrameworkBundle] Moved router_listener from web to router.xml since it depends on the router `35a9023` [FrameworkBundle] Added isEnabled to Router commands, fixes #1467 `536d979` [Console] Added Command::isEnabled method that defines whether to add the command or not Discussion ---------- [2.1] [Console] Added Command::isEnabled method This addresses #1467. The idea is to allow commands to evaluate whether they can run or not, since they are automatically registered. - It's useful for the two router:* commands since they're optional (router can be disabled), but part of the FrameworkBundle that is not really optional. - It could be useful for third party code as well. - It's BC. - aa95bb0d395810b29a3e654673e130736d9d1080 should address the issue in #1467, while the other commits just make sure the command is not registered at all if the router isn't standard. One issue remains though: - A few other services like twig helpers get the `ròuter` injected, this means that if there is really no router service defined, there is still an error. I'm not sure how to fix those beyond adding `on-invalid="null"` but I'm not sure if that's desirable. I guess we could argue that the router is a big candidate for replacement/suppression, and as such it should be truly optional, but if we do it I don't know where it'll lead. I don't want to end up in a situation where half the dependencies are optional to support every possible combination. @fabpot wdyt? --------------------------------------------------------------------------- by kriswallsmith at 2011/06/28 16:19:46 -0700 I'd rather see us not register a command instead of register and then disable it. Can we do the same thing you've done here in the bundle's registerCommands() method? --------------------------------------------------------------------------- by Seldaek at 2011/06/28 16:51:36 -0700 Note that it's never really registered. During the registration it's checked and skipped if not enabled. However, doing it as you suggest means overriding/copy-pasting all the code from the core Bundle class, which I don't like so much. It also means adding code specific to those two commands in a somewhat unrelated place, which I also don't like. I'm not saying the current solution is perfect, but from the alternatives I considered, it's the best I have found. --------------------------------------------------------------------------- by stof at 2011/09/04 04:58:04 -0700 @Seldaek your branch conflicts with master. could you rebase it ? @fabpot what do you think about this PR ? --------------------------------------------------------------------------- by Seldaek at 2011/09/04 08:39:05 -0700 Rebased		2011-09-27 15:48:10 +02:00
src/Symfony	merged branch Seldaek/commands (PR #1470 )	2011-09-27 15:48:10 +02:00
tests	[Form] added tests for previous merge	2011-09-27 10:12:54 +02:00
.gitignore	Added vendor directory to .gitignore	2010-06-24 10:44:28 +02:00
autoload.php.dist	fixed autoloader when tests are run on a machine without intl installed	2011-07-20 14:27:10 +02:00
CHANGELOG-2.0.md	updated CHANGELOG for 2.0.3	2011-09-25 11:50:40 +02:00
CHANGELOG-2.1.md	[Form] added tests for previous merge	2011-09-27 10:12:54 +02:00
check_cs	fixed root search path to include only './src' and './tests'	2011-06-08 18:11:05 +02:00
CONTRIBUTORS.md	update CONTRIBUTORS for 2.0.2	2011-09-25 10:26:33 +02:00
LICENSE	added the LICENSE file for the YAML component	2011-02-18 11:52:11 +01:00
phpunit.xml.dist	[Security] cleaned up opt-in to benchmark test	2011-03-06 20:06:13 +01:00
README.md	[README] Adding a small section with information about contributing.	2011-09-23 11:21:11 -05:00
UPDATE.ja.md	updated translation of UPDATE file (Japanese RC5 added)	2011-07-30 02:08:25 +09:00
UPDATE.md	updated UPDATE file	2011-07-22 17:45:02 +02:00
vendors.php	fixed version and vendors	2011-09-25 10:29:26 +02:00

README.md

README

What is Symfony2?

Symfony2 is a PHP 5.3 full-stack web framework. It is written with speed and flexibility in mind. It allows developers to build better and easy to maintain websites with PHP.

Symfony can be used to develop all kind of websites, from your personal blog to high traffic ones like Dailymotion or Yahoo! Answers.

Requirements

Symfony2 is only supported on PHP 5.3.2 and up.

Installation

The best way to install Symfony2 is to download the Symfony Standard Edition available at http://symfony.com/download.

Documentation

The "Quick Tour" tutorial gives you a first feeling of the framework. If, like us, you think that Symfony2 can help speed up your development and take the quality of your work to the next level, read the official Symfony2 documentation.

Contributing

Symfony2 is an open source, community-driven project. If you'd like to contribute, please read the Contributing Code part of the documentation. If you're submitting a pull request, please follow the guidelines in the Submitting a Patch section.