This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Fabien Potencier 0669b61035 merged branch canni/composer (PR #3291) ... Commits ------- aa055df [Composer] Stwitch to composer vendors management Discussion ---------- [Composer] Stwitch to composer vendors management Bug fix: no Feature addition: yes Backwards compatibility break: No? Symfony2 tests pass: yes Fixes the following tickets: - Todo: - [](http://travis-ci.org/canni/symfony) This speeds up Travis CI builds to `~2 min` also makes vendor management a lot easier. --------------------------------------------------------------------------- by fabpot at 2012-02-09T06:24:24Z I'm -1 on this change. The `vendors.php` script is *only* for people working on the core so that we can run the unit tests. So, we need the flexibility to test on many different versions of the code and having the repository here is kind of mandatory. --------------------------------------------------------------------------- by Seldaek at 2012-02-09T08:15:28Z You can `composer install --dev` to get proper clones. I'm not really pro or against, just saying it's an option. --------------------------------------------------------------------------- by canni at 2012-02-09T08:28:54Z @fabpot I understand yours point, but from my view transferring the whole git structure of *vendors* is little pointless IMO (especially in Travis env) but I think I can make this change optional, so Travis and anyone that prefer to, can use `composer` an with old functionality available. (There will be almost no duplication, as anyway we're updating `composer.json`) --------------------------------------------------------------------------- by canni at 2012-02-09T09:20:17Z @fabpot I've enabled both behaviors, everything will work regardless of using `composer` or `vendors.php` this lets the developer decide what to use --------------------------------------------------------------------------- by drak at 2012-02-16T12:05:28Z Since there is a `--dev` option in Composer then I think this is a good idea. You could also add composer.phar to the repo bin directory. --------------------------------------------------------------------------- by henrikbjorn at 2012-02-16T12:06:55Z `--dev` have been renamed to `--prefer-source` --------------------------------------------------------------------------- by canni at 2012-02-16T12:22:01Z @fabpot any chance to consider this merge? If not, this PR can be closed. --------------------------------------------------------------------------- by henrikbjorn at 2012-02-16T12:25:51Z @canni This is the goal eventually. But i think we need composer to be a bit more stable in its solver. --------------------------------------------------------------------------- by francoispluchino at 2012-02-16T12:39:24Z 👍 --------------------------------------------------------------------------- by jmikola at 2012-04-06T18:19:27Z @fabpot: Is this PR still off the table, or are you reconsidering it with the `--prefer-source` option? I was just running symfony unit tests, and attempted to install deps with composer as I thought this PR or another like it had recently been merged to core. It wasn't :) Admittedly, it's a downside that vendor libs, even if git repositories, will be nestled within the `.composer/` directory. --------------------------------------------------------------------------- by drak at 2012-04-07T00:20:33Z @canni This PR needs to be rebased and reviewed because of the changed tests directory (there is no longer a central `tests/` folder). --------------------------------------------------------------------------- by canni at 2012-04-07T06:34:28Z Hey, will do after a weekend. canni Użytkownik Drak <reply@reply.github.com> napisał: >@canni This PR needs to be rebased and reviewed because of the changed tests directory (there is no longer a central `tests/` folder). > >--- >Reply to this email directly or view it on GitHub: >https://github.com/symfony/symfony/pull/3291#issuecomment-5004750 --------------------------------------------------------------------------- by canni at 2012-04-08T19:02:03Z @drak done.		2012-04-18 11:06:49 +02:00
..
Command	replaced command names with supported placeholders in help texts	2012-03-21 05:31:52 +01:00
DataCollector	[Security] various changes, see below	2011-03-10 10:25:32 +01:00
DependencyInjection	[Routing] Request methods always return a raw path, fix the matcher to decode only once	2012-04-10 10:40:58 +02:00
EventListener	updated license blocks	2012-03-31 18:00:32 -03:00
Resources	[FrameworkBundle + WebProfilerBundle] Optimized images and icons with PunnyPNG	2012-03-14 23:31:48 +01:00
Security	updated license blocks	2012-03-31 18:00:32 -03:00
Templating/Helper	[SecurityBundle] Avoid direct request dependency in LogoutUrlHelper	2012-03-06 02:36:11 -05:00
Tests	merged branch canni/composer (PR #3291)	2012-04-18 11:06:49 +02:00
Twig/Extension	[SecurityBundle] Templating helpers to generate logout URL's with CSRF tokens	2012-02-14 19:03:51 -05:00
Validator/Constraint	[Validator] Renamed ConstraintValidatorInterface::isValid() to validate() because of the lack of a return value	2012-04-17 16:46:43 +02:00
composer.json	Removed version field	2012-02-27 09:59:20 +01:00
SecurityBundle.php	[BC break][SecurityBundle] Changed the way to register factories	2011-11-17 20:16:17 +01:00