0a3d3d4dff
This PR was submitted for the 4.2 branch but it was merged into the 4.1 branch instead (closes #29697).
Discussion
----------
[DI] Fixed wrong factory method in exception
| Q | A
| ------------- | ---
| Branch? | 4.2 <!-- see below -->
| Bug fix? | yes
| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| Fixed tickets | #29678 <!-- #-prefixed issue number(s), if any -->
| License | MIT
| Doc PR | n/a <!-- required for new features -->
When a service definition with a factory defines invalid arguments, the [resulting exception message ](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/DependencyInjection/Compiler/ResolveNamedArgumentsPass.php#L70)incorrectly specifies the factory constructor instead of the factory method as not having the specified named arguments.
<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
- Bug fixes must be submitted against the lowest branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against the master branch.
-->
Commits
-------
|
||
|---|---|---|
| .. | ||
| AnalyzeServiceReferencesPassTest.php | ||
| AutoAliasServicePassTest.php | ||
| AutowireExceptionPassTest.php | ||
| AutowirePassTest.php | ||
| AutowireRequiredMethodsPassTest.php | ||
| CheckArgumentsValidityPassTest.php | ||
| CheckCircularReferencesPassTest.php | ||
| CheckDefinitionValidityPassTest.php | ||
| CheckExceptionOnInvalidReferenceBehaviorPassTest.php | ||
| CheckReferenceValidityPassTest.php | ||
| DecoratorServicePassTest.php | ||
| DefinitionErrorExceptionPassTest.php | ||
| ExtensionCompilerPassTest.php | ||
| FactoryReturnTypePassTest.php | ||
| InlineServiceDefinitionsPassTest.php | ||
| IntegrationTest.php | ||
| MergeExtensionConfigurationPassTest.php | ||
| OptionalServiceClass.php | ||
| PassConfigTest.php | ||
| PriorityTaggedServiceTraitTest.php | ||
| RegisterEnvVarProcessorsPassTest.php | ||
| RegisterServiceSubscribersPassTest.php | ||
| RemoveUnusedDefinitionsPassTest.php | ||
| ReplaceAliasByActualDefinitionPassTest.php | ||
| ResolveBindingsPassTest.php | ||
| ResolveChildDefinitionsPassTest.php | ||
| ResolveClassPassTest.php | ||
| ResolveDefinitionTemplatesPassTest.php | ||
| ResolveFactoryClassPassTest.php | ||
| ResolveHotPathPassTest.php | ||
| ResolveInstanceofConditionalsPassTest.php | ||
| ResolveInvalidReferencesPassTest.php | ||
| ResolveNamedArgumentsPassTest.php | ||
| ResolveParameterPlaceHoldersPassTest.php | ||
| ResolvePrivatesPassTest.php | ||
| ResolveReferencesToAliasesPassTest.php | ||
| ResolveTaggedIteratorArgumentPassTest.php | ||