This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Fabien Potencier 0ad71a07e8 merged branch rdohms/upload-validation-details (PR #3637) ... Commits ------- 836d12b Fixing typo. ac2a187 Improved feedback for Upload Validator to cover all PHP error states. This way we don't get a unclear "upload error" message unless its something completely unexpected. Discussion ---------- Improved feedback for Upload Validator to cover all PHP error states. The upload validator only sets individual messages for 2 out of the 7 error states PHP suports for uploading files. Which means when you have any of those 5 stats you get a standard error message and have to really dig into the code to read the error state. I added messages for every state, so that you will always get a detailed message. --------------------------------------------------------------------------- by stloyd at 2012-03-19T13:54:04Z You should probably also extend translations in `FrameworkBundle`. --------------------------------------------------------------------------- by rdohms at 2012-03-19T14:04:50Z @stloyd what's the best way to do that? I obviously don't speak all languages. Could you point me to a best practices in this case? --------------------------------------------------------------------------- by stof at 2012-03-19T15:58:17Z @rdohms update the translations for the languages you speak. Other people will contribute with update later eventually :) --------------------------------------------------------------------------- by rdohms at 2012-03-19T22:34:50Z Fixed the typo, only other language i can update is portuguese, but it needs more work. I'll update it on a separate PR later on. Anything else for this PR? --------------------------------------------------------------------------- by mvrhov at 2012-03-20T05:41:00Z @rdohms: just put English strings into other lanugages --------------------------------------------------------------------------- by rdohms at 2012-03-20T07:35:56Z @mvrhov is there a quick way to do this? or is it copying and pasting into every language and adjusting the string IDs? --------------------------------------------------------------------------- by mvrhov at 2012-03-20T09:02:59Z AFAIK you'll have to copy paste. String ids and source are the same in all translations so it really is just c/p after you update the first one. --------------------------------------------------------------------------- by rdohms at 2012-03-20T09:56:48Z @mvrhov so which is the most updated one you would say? i see a lot of them missing bit and pieces :P --------------------------------------------------------------------------- by mvrhov at 2012-03-20T14:00:21Z Sorry no idea. --------------------------------------------------------------------------- by stof at 2012-03-20T19:09:10Z @mvrhov Please don't do this. The translation component has a fallback mecanism so putting the EN string in an incomplete translation file is a bad idea as it forbids using a fallback. --------------------------------------------------------------------------- by rdohms at 2012-03-20T20:14:50Z @stof i figured as much. Any other concerns before we push this PR further?		2012-03-21 22:31:15 +01:00
..
BrowserKit	merged 2.0	2012-03-11 18:00:10 +01:00
ClassLoader	[ClassLoader] Fixed version compare	2012-03-09 08:17:46 +01:00
Config	[Config] Improve handling of PrototypedArrayNode defaults	2012-02-20 23:07:03 +01:00
Console	restore previous testing style with static fixtures for console	2012-03-21 05:32:53 +01:00
CssSelector	[CssSelector] fixed CssSelector::toXPath() when the CSS selector is an empty string	2012-03-11 10:18:25 +01:00
DependencyInjection	merged 2.0	2012-03-08 19:29:37 +01:00
DomCrawler	fixed CS, phpdoc, removed unused use statements	2012-01-28 18:02:36 +01:00
EventDispatcher	[EventDispatcher] Add fluid interface on dispatch()	2012-03-10 09:55:57 +05:45
Finder	[Finder] added a convenience method Finder::create()	2011-06-14 14:18:24 +02:00
Form	merged 2.0	2012-03-15 15:47:03 +01:00
HttpFoundation	doc fix	2012-03-17 00:59:57 +01:00
HttpKernel	[HttpKernel] Fix MongoDbProfilerStorageTest	2012-03-20 17:56:45 +01:00
Locale	[WIP][Locale] StubIntlDateFormatter::parse was throwing exception instead of returning Boolean false like intl implementation	2012-02-14 01:35:14 -02:00
Process	Restore bypass_shell by default with windows compat	2012-02-22 14:19:04 +01:00
Routing	[Routing] Cleanup	2012-03-20 09:12:35 +01:00
Security	merged branch jmikola/logout-csrf (PR #3007)	2012-03-05 16:12:24 +01:00
Serializer	merged 2.0	2012-02-26 14:24:21 +01:00
Templating	[Templating] fixed 'scheme://' not detected as absolute path	2011-12-08 15:42:21 +01:00
Translation	[Translation] Ignore xliff entries with no "target" node	2012-03-21 14:55:53 +01:00
Validator	Improved feedback for Upload Validator to cover all PHP error states.	2012-03-19 14:37:25 +01:00
Yaml	merged 2.0	2011-12-18 14:48:17 +01:00