0de88bbcc1
This PR was merged into the 2.7 branch.
Discussion
----------
Entity type: loader caching by query builder instance
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Using entity types within a collection, can get very slow, if a query_builder option is set.
Without this option, the doctrine type handles everything itself, and makes it calls against the manager registry, but using this, calls the getLoader method, which ends in build the choice list again for each collection element, which makes more than twice the time for a page load within my energycalculator.
https://github.com/dominikzogg/symfony/blob/2.7/src/Symfony/Bridge/Doctrine/Form/Type/DoctrineType.php#L68
https://github.com/dominikzogg/symfony/blob/2.7/src/Symfony/Bridge/Doctrine/Form/Type/DoctrineType.php#L108
https://github.com/dominikzogg/energycalculator/blob/master/src/Dominikzogg/EnergyCalculator/Form/ComestibleWithinDayType.php
Commits
-------
|
||
---|---|---|
.. | ||
CacheWarmer | ||
DataCollector | ||
DataFixtures | ||
DependencyInjection | ||
ExpressionLanguage | ||
Form | ||
HttpFoundation | ||
Logger | ||
Security | ||
Test | ||
Tests | ||
Validator | ||
.gitignore | ||
CHANGELOG.md | ||
composer.json | ||
ContainerAwareEventManager.php | ||
LICENSE | ||
ManagerRegistry.php | ||
phpunit.xml.dist | ||
README.md | ||
RegistryInterface.php |