5d30df78e7
This PR was merged into the 2.8 branch.
Discussion
----------
[HttpFoundation] Allow reuse of Session between requests if ID did not change
| Q | A
| ------------- | ---
| Branch? | 2.8
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #13450
| License | MIT
| Doc PR | -
I stumbled upon the issue from https://github.com/symfony/symfony/issues/13450 in a more simple case than what was exposed in the issue. From my understanding, the problem arises when the session is used between an access to the session and a functional test request: because the session was accessed (usually using the container directly), the session has started and the following request fails.
This PR checks whether the ID was actually regenerated before throwing (if a setId is called with the same ID, it is the same request context, it shouldn't throw IMO).
Not sure I understood everything correctly though, feel free to fix it for me if needed.
Commits
-------
|
||
|---|---|---|
| .. | ||
| Exception | ||
| File | ||
| Session | ||
| Tests | ||
| .gitignore | ||
| AcceptHeader.php | ||
| AcceptHeaderItem.php | ||
| ApacheRequest.php | ||
| BinaryFileResponse.php | ||
| CHANGELOG.md | ||
| composer.json | ||
| Cookie.php | ||
| ExpressionRequestMatcher.php | ||
| FileBag.php | ||
| HeaderBag.php | ||
| IpUtils.php | ||
| JsonResponse.php | ||
| LICENSE | ||
| ParameterBag.php | ||
| phpunit.xml.dist | ||
| README.md | ||
| RedirectResponse.php | ||
| Request.php | ||
| RequestMatcher.php | ||
| RequestMatcherInterface.php | ||
| RequestStack.php | ||
| Response.php | ||
| ResponseHeaderBag.php | ||
| ServerBag.php | ||
| StreamedResponse.php | ||
HttpFoundation Component
The HttpFoundation component defines an object-oriented layer for the HTTP specification.