18793b7ca7
This PR was merged into the 5.0-dev branch.
Discussion
----------
[5.0] Add return types in final classes
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | yes/no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks? | no
| Deprecations? | no
| Tests pass? | no
| Fixed tickets | #31981
| License | MIT
| Doc PR | symfony/symfony-docs#... <!-- required for new features -->
This is the first step for the issue #31981
I have some questions:
- ~I have not added type for methods with `@inheritdoc` annotation, should I?~
- ~Don't we want to type also functions without `@return` annotation? (still in `final` classes)~
- ~If yes is the answer of the previous one, do we also want the `void` return type?~
- ~I have also added the return type in the `DependencyInjection` PhpDumper, but is it also wanted? (if yes, I will clean a bit the code changed)~
- ~Should we update the documentation's code samples when they display `final` classes?~
Todo:
- [x] Adjust the PR, following the answers of the questions
- [x] Add return type also when there is no `@return`, or with `@inheritdoc`
- [x] [src/Symfony/Component/Debug/ErrorHandler.php#L383](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Debug/ErrorHandler.php#L383) `@return` annotation is not correct according to the return, investigate and adjust if needed
- [x] [src/Symfony/Component/HttpKernel/ControllerMetadata/ArgumentMetadataFactory.php#L50](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/ControllerMetadata/ArgumentMetadataFactory.php#L50) `@return` annotation is not correct according to the return, investigate and adjust if needed
- [x] Do a PR on documentation to add return type on code snippets with final classes => unneeded as they were already typed
Commits
-------
|
||
|---|---|---|
| .. | ||
| Argument | ||
| Compiler | ||
| Config | ||
| Dumper | ||
| Exception | ||
| Extension | ||
| LazyProxy | ||
| Loader | ||
| ParameterBag | ||
| Tests | ||
| .gitignore | ||
| Alias.php | ||
| CHANGELOG.md | ||
| ChildDefinition.php | ||
| composer.json | ||
| Container.php | ||
| ContainerAwareInterface.php | ||
| ContainerAwareTrait.php | ||
| ContainerBuilder.php | ||
| ContainerInterface.php | ||
| Definition.php | ||
| EnvVarProcessor.php | ||
| EnvVarProcessorInterface.php | ||
| ExpressionLanguage.php | ||
| ExpressionLanguageProvider.php | ||
| LICENSE | ||
| Parameter.php | ||
| phpunit.xml.dist | ||
| README.md | ||
| Reference.php | ||
| ReverseContainer.php | ||
| ServiceLocator.php | ||
| TaggedContainerInterface.php | ||
| TypedReference.php | ||
| Variable.php | ||
DependencyInjection Component
The DependencyInjection component allows you to standardize and centralize the way objects are constructed in your application.