This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Fabien Potencier 229828da8a feature #11210 [FrameworkBundle] Improving bad bundle exception in _controller (weaverryan) ... This PR was merged into the 2.6-dev branch. Discussion ---------- [FrameworkBundle] Improving bad bundle exception in _controller ...ntroller in a routeHi guys! This improves the exception message when you use a bad bundle name in the `_controller` syntax in a routing file. Here is the before and after of the message with this mistake (real bundle is `KnpUniversityBundle`): ```yaml some_route: pattern: / defaults: { _controller: "Knp2UniversityBundle:Course:index" } ```   Notice the before and after behavior is the same `InvalidArgumentException` (just a different message). | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Catching the plain `InvalidArgumentException` from `Kernel::getBundles()` seems a bit "loose". Should we consider creating a new exception (e.g. `BundleDoesNotExistException`) that extends `InvalidArgumentException` and throw it from inside `Kernel::getBundles`? This would allow us to catch more precisely, and it seems like it would be BC. Suggestions and thoughts warmly welcome! Thanks! Commits ------- f9b88c6 Improving the exception message when the bundle name is wrong for the controller in a route		2014-07-08 21:33:54 +02:00
..
Symfony	feature #11210 [FrameworkBundle] Improving bad bundle exception in _controller (weaverryan)	2014-07-08 21:33:54 +02:00