Archived

forked from https://github.com/symfony/symfony

This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Go to file

Fabien Potencier 26c9cb787e merged branch havvg/feature/jsonp-response (PR #3639 ) Commits ------- `4a43453` remove callback from constructor and create method `601b87c` add basic validation of callback name `266f76d` rename jsonp to callback, defaults to null `38b79a7` add data and callback setter to JsonResponse `6788224` add JSONP support to JsonResponse Discussion ---------- add JSONP support to JsonResponse --------------------------------------------------------------------------- by schmittjoh at 2012-03-19T17:56:24Z I think a ``setCallback()`` method would be more expressive, and easier to use: ```php <?php return JsonResponse::create($myData)->setCallback('foo'); // vs return new JsonResponse($myData, 200, array(), 'foo'); ``` What do you think? --------------------------------------------------------------------------- by havvg at 2012-03-19T18:07:38Z Looks good to me, I'll add it. --------------------------------------------------------------------------- by dlsniper at 2012-03-19T19:38:45Z +1 for this one :) --------------------------------------------------------------------------- by vicb at 2012-03-19T23:09:50Z Sorry for nitpicking but what about: * some validation on the function name ? * renamming `jsonp` -> `callback` ? --------------------------------------------------------------------------- by havvg at 2012-03-20T09:16:32Z @vicb What do you mean with "some validation on the function name"? I can't follow you there. --------------------------------------------------------------------------- by vicb at 2012-03-20T09:22:49Z I mean a valid JS function name --------------------------------------------------------------------------- by havvg at 2012-03-20T09:34:59Z Ah I see, I searched for it, and ended up with those results: * The most complete: http://stackoverflow.com/questions/2008279/validate-a-javascript-function-name#answer-9392578 * and a less accurate one: http://www.geekality.net/2011/08/03/valid-javascript-identifier/ I'm not sure whether to put this into the `JsonResponse` itself, or to add somewhere else (where, if so?). --------------------------------------------------------------------------- by vicb at 2012-03-20T09:45:20Z I would go for a regexp only (ignoring reserved words); The idea would be not to use this to run arbitrary JS code. --------------------------------------------------------------------------- by fabpot at 2012-03-21T21:33:36Z Now that you have added the `setCallback` method, I would remove the constructor argument as it makes the signature quite long. As we have the `create` method anyway, it's more explicit and clearer to use the `setCallback` . --------------------------------------------------------------------------- by havvg at 2012-03-21T21:37:51Z So remove the callback argument from both, the constructor and the `create` method or only from the constructor? --------------------------------------------------------------------------- by havvg at 2012-03-21T21:38:30Z Ehr.. never mind :-)		2012-03-22 00:10:35 +01:00
src/Symfony	merged branch havvg/feature/jsonp-response (PR #3639 )	2012-03-22 00:10:35 +01:00
tests	merged branch havvg/feature/jsonp-response (PR #3639 )	2012-03-22 00:10:35 +01:00
.gitignore	Added vendor directory to .gitignore	2010-06-24 10:44:28 +02:00
.travis.yml	also test PHP 5.3.2, since this is the official lowest supported PHP version	2011-12-26 01:15:21 +01:00
autoload.php.dist	fixed code coverage raport generation	2012-03-16 15:28:27 +01:00
CHANGELOG-2.0.md	updated CHANGELOG for 2.0.11	2012-02-24 22:59:05 +01:00
CHANGELOG-2.1.md	[Console] Stop parsing options after encountering "--" token	2012-03-16 15:53:13 -04:00
check_cs	[Check CS] don't replace 'else if' on twig files (closes #2961 )	2011-12-27 16:10:32 +01:00
composer.json	fixed typos in composer file	2012-03-15 11:15:25 +01:00
CONTRIBUTORS.md	update CONTRIBUTORS for 2.0.10	2012-02-06 10:49:11 +01:00
LICENSE	Updated LICENSE files copyright	2012-02-22 10:10:37 +01:00
phpunit.xml.dist	Ignore destructive memcached tests by default	2012-02-24 13:37:42 +01:00
README.md	set travis-ci icon to master	2011-11-23 11:36:09 +01:00
UPGRADE-2.1.md	Changelog and upgrading changes.	2012-03-14 21:00:04 +05:45
vendors.php	fixed code coverage raport generation	2012-03-16 15:28:27 +01:00

README.md

README

What is Symfony2?

Symfony2 is a PHP 5.3 full-stack web framework. It is written with speed and flexibility in mind. It allows developers to build better and easy to maintain websites with PHP.

Symfony can be used to develop all kind of websites, from your personal blog to high traffic ones like Dailymotion or Yahoo! Answers.

Requirements

Symfony2 is only supported on PHP 5.3.2 and up.

Installation

The best way to install Symfony2 is to download the Symfony Standard Edition available at http://symfony.com/download.

Documentation

The "Quick Tour" tutorial gives you a first feeling of the framework. If, like us, you think that Symfony2 can help speed up your development and take the quality of your work to the next level, read the official Symfony2 documentation.

Contributing

Symfony2 is an open source, community-driven project. If you'd like to contribute, please read the Contributing Code part of the documentation. If you're submitting a pull request, please follow the guidelines in the Submitting a Patch section.