2f3b33a630
This PR was squashed before being merged into the master branch (closes #7559).
Discussion
----------
[HttpFoundation] [HttpKernel] Internal sub-requests should have X-Forwarded-For header providing real client IP
This is a better alternative to fix issue highlighted in #7554 and #7557.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7554, #7557
| License | MIT
When dealing with inline fragment renderer, it emulates an internal request by overriding the REMOTE_ADDR on Request. This is true, since conceptually request came from local server.
The problem that this introduces is that overriding the server value, it turns into an impossible state to retrieve the real client ip, only returning the local server IP (which is hardcoded to 127.0.0.1).
This patch takes the same approach as a Varnish call (it behaves the exact same way, reusing all code built for handling client ip handling on sub-requests), populating the X-Forwarded-For header and also making getClientIp smarter by removing possible local IP addresses from being considered as the client IP address.
Commits
-------
|
||
|---|---|---|
| .. | ||
| Bundle | ||
| CacheClearer | ||
| CacheWarmer | ||
| Config | ||
| Controller | ||
| DataCollector | ||
| Debug | ||
| DependencyInjection | ||
| EventListener | ||
| Fixtures | ||
| Fragment | ||
| HttpCache | ||
| Profiler | ||
| ClientTest.php | ||
| HttpKernelTest.php | ||
| KernelTest.php | ||
| Logger.php | ||
| TestHttpKernel.php | ||
| UriSignerTest.php | ||