This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
symfony/src/Symfony/Bridge
Christophe Coevoet 37f2c3dabd bug #11160 [DoctrineBridge] Abstract Doctrine Subscribers with tags (merk)
This PR was merged into the 2.3 branch.

Discussion
----------

[DoctrineBridge] Abstract Doctrine Subscribers with tags

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | this one
| License       | MIT
| Doc PR        | N/A

I've hit a problem with some doctrine listeners, built by decorating an abstract definition.

I want the abstract definition to hold the tag, however because the RegisterEventListenersAndSubscribersPass runs before abstract definitions are removed, they get added as method calls to the EventManager definition, which once the abstract service is removed, we end up with a method call that breaks the container.

I don't know if this is the best approach, it might be better not to return abstract services when calling `findTaggedServiceIds` instead?

Commits
-------

cbcf513 Disallow abstract definitions from doctrine event listener registration
2014-08-28 21:58:08 +02:00
..
Doctrine bug #11160 [DoctrineBridge] Abstract Doctrine Subscribers with tags (merk) 2014-08-28 21:58:08 +02:00
Monolog removed defaults from PHPUnit configuration 2014-07-07 12:13:42 +02:00
Propel1 fix some docblocks 2014-08-02 08:27:27 +02:00
ProxyManager removed defaults from PHPUnit configuration 2014-07-07 12:13:42 +02:00
Swiftmailer made phpdoc types consistent with those defined in Hack 2014-04-15 07:41:45 +02:00
Twig [TwigBridge] [Form] Fixed some extra empty spaces 2014-08-05 09:07:37 +02:00