This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
Go to file
Fabien Potencier 380c2687e7 bug #20621 [HttpKernel] Fix exception when serializing request attributes (nicolas-grekas)
This PR was merged into the 3.2 branch.

Discussion
----------

[HttpKernel] Fix exception when serializing request attributes

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Serializing request attributes obviously fails easily since once can put anything there (I've just got an "Exception: Serialization of 'Closure' is not allowed").
Yet, we don't need attributes when forging a request to feed the TraceableUrlMatcher in RouterController.
Well, technically one could for sure register a listener before the router to add an attribute to the request, then use that in the url matcher.
But, it makes no sense. And if it were to have, the profiler is already broken in this respect because in e.g. 3.1, the attribute array that is used here has already been processed by the ValueExporter. So the original values have already been altered.

Let's just handle request attributes as all the other collected data: using var dumper.

Commits
-------

2e404d0 [HttpKernel] Fix exception when serializing request attributes
2016-11-24 09:39:47 -08:00
.composer Drop hirak/prestissimo 2016-05-12 07:44:15 -05:00
.github [ci] Fix build-packages.php 2016-09-13 13:44:15 +02:00
src/Symfony [HttpKernel] Fix exception when serializing request attributes 2016-11-24 18:21:54 +01:00
.editorconfig Add EditorConfig File 2012-06-16 14:08:15 +02:00
.gitignore Add appveyor.yml for C.I. on Windows 2015-08-25 23:41:37 +02:00
.php_cs Merge branch '2.7' into 2.8 2016-10-17 21:28:30 -07:00
.travis.yml Merge branch '3.1' 2016-11-18 16:17:59 -05:00
appveyor.yml Merge branch '3.1' 2016-11-18 16:17:59 -05:00
CHANGELOG-3.0.md Merge branch '2.8' into 3.1 2016-08-05 10:37:39 +02:00
CHANGELOG-3.1.md updated CHANGELOG for 3.1.7 2016-11-20 18:44:16 -08:00
CHANGELOG-3.2.md Fixed generation mistake in changelog 2016-11-17 21:40:35 +01:00
composer.json Merge branch '3.1' 2016-11-16 17:18:16 -05:00
CONTRIBUTING.md Update contributing docs 2016-02-24 15:36:06 +01:00
CONTRIBUTORS.md update CONTRIBUTORS for 2.7.21 2016-11-20 17:12:28 -08:00
LICENSE Update copyright year 2016-01-01 23:53:47 -03:00
phpunit [travis/appveyor] Wire simple-phpunit 2016-09-12 17:58:10 +02:00
phpunit.xml.dist Make redis host configurable in tests 2016-09-19 12:25:01 -07:00
README.md Merge branch '2.8' into 3.1 2016-10-19 15:38:53 -07:00
UPGRADE-3.0.md Merge branch '2.8' into 3.1 2016-11-18 16:15:08 -05:00
UPGRADE-3.1.md [HttpKernel] Clarify deprecation of non-scalar values in surrogate renderer 2016-07-04 13:45:05 +02:00
UPGRADE-3.2.md feature #19741 [ExpressionLanguage] Making cache PSR6 compliant (Alexandre GESLIN) 2016-10-17 11:35:41 -07:00
UPGRADE-4.0.md Revert "feature #18728 deprecate get() for uncompiled container builders (xabbuh)" 2016-11-16 15:37:53 -05:00

README

What is Symfony?

Symfony is a PHP full-stack web framework. It is written with speed and flexibility in mind. It allows developers to build better and easy to maintain websites with PHP.

Symfony can be used to develop all kind of websites, from your personal blog to high traffic ones like Dailymotion or Yahoo! Answers.

Installation

The best way to install Symfony is to use the official Symfony Installer. It allows you to start a new project based on the version you want.

Documentation

The "Quick Tour" tutorial gives you a first feeling of the framework. If, like us, you think that Symfony can help speed up your development and take the quality of your work to the next level, read the official Symfony documentation.

Contributing

Symfony is an open source, community-driven project. If you'd like to contribute, please read the Contributing Code part of the documentation. If you're submitting a pull request, please follow the guidelines in the Submitting a Patch section and use Pull Request Template.

Running Symfony Tests

Information on how to run the Symfony test suite can be found in the Running Symfony Tests section.