This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
symfony/src/Symfony/Component
Fabien Potencier 4056baf0f4 bug #34129 [FrameworkBundle][Translation] Invalidate cached catalogues when the scanned directories change (fancyweb)
This PR was merged into the 4.3 branch.

Discussion
----------

[FrameworkBundle][Translation] Invalidate cached catalogues when the scanned directories change

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | https://github.com/symfony/symfony/issues/33992
| License       | MIT
| Doc PR        | -

The cache file name needs to depend on the scanned directories list. Otherwise, when a new directory is added, even if the container is rebuilt and the `FWB Translator` gets the new scanned directories list, the cached catalogue name is still the same and is resolved accordingly.

An alternative would be to make the `Translation Translator` `getCatalogueCachePath()` method and `fallbackLocales` `@internal` and `protected` to just override everything in the `FWB Translator`. The `cacheVary` argument has the benefit to be reusable by all the `Translation` component users.

Note that there is a negative minor performance impact that increases when the list of scanned directories grows.

Commits
-------

6cbee0944c [FrameworkBundle][Translation] Invalidate cached catalogues when the scanned directories change
2019-11-07 00:21:49 +01:00
..
Asset Remove superfluous phpdoc tags 2019-08-14 13:59:53 +02:00
BrowserKit Merge branch '3.4' into 4.3 2019-10-28 18:07:32 +01:00
Cache [4.3] Remove unused local variables 2019-10-30 13:58:49 +01:00
Config minor #34176 [4.3] Remove unused local variables (fancyweb) 2019-10-30 14:18:51 +01:00
Console bug #34085 [Console] Detect dimensions using mode CON if vt100 is supported (rtek) 2019-11-05 16:00:49 +01:00
CssSelector Merge branch '3.4' into 4.3 2019-10-02 10:36:26 +02:00
Debug Merge branch '3.4' into 4.3 2019-10-28 18:07:32 +01:00
DependencyInjection Merge branch '3.4' into 4.3 2019-11-05 15:48:09 +01:00
DomCrawler Merge branch '3.4' into 4.3 2019-10-28 18:07:32 +01:00
Dotenv Merge branch '3.4' into 4.3 2019-10-18 13:23:15 +02:00
EventDispatcher Name test accordingly to the tested class 2019-11-03 10:04:05 +01:00
ExpressionLanguage drop wrong test (fix merge) 2019-10-29 02:54:26 +01:00
Filesystem Merge branch '3.4' into 4.3 2019-08-20 16:07:54 +02:00
Finder Merge branch '3.4' into 4.3 2019-10-30 13:53:54 +01:00
Form Merge branch '3.4' into 4.3 2019-10-28 18:07:32 +01:00
HttpClient [HttpClient] expose only gzip when doing transparent compression 2019-11-06 11:21:02 +01:00
HttpFoundation Merge branch '3.4' into 4.3 2019-11-05 15:48:09 +01:00
HttpKernel [HttpKernel] backport FC compat code 2019-11-06 15:42:08 +01:00
Inflector add species to inflector and inflector tests 2019-11-05 20:58:22 +01:00
Intl [Intl] Update the ICU data to 65.1 (4.3 branch) 2019-10-04 23:18:34 +02:00
Ldap Merge branch '3.4' into 4.3 2019-09-24 17:54:14 +02:00
Lock Merge branch '3.4' into 4.3 2019-09-24 17:54:14 +02:00
Mailer [4.3] Remove unused local variables 2019-10-30 13:58:49 +01:00
Messenger bug #34134 [Messenger] fix retry of messages losing the routing key and properties (Tobion) 2019-11-04 07:59:16 +01:00
Mime [4.3] Remove unused local variables 2019-10-30 13:58:49 +01:00
OptionsResolver Fix an error message to be more accurate 2019-10-28 16:59:01 -04:00
Process Merge branch '3.4' into 4.3 2019-10-28 18:07:32 +01:00
PropertyAccess Merge branch '3.4' into 4.3 2019-08-26 10:26:39 +02:00
PropertyInfo [PropertyInfo] Fixed type extraction for nullable collections of non-nullable elements 2019-11-03 13:19:12 +01:00
Routing Add tests to ensure defaultLocale is properly passed to the URL generator 2019-11-04 21:23:03 +01:00
Security [4.3] Remove unused local variables 2019-10-30 13:58:49 +01:00
Serializer [Serializer] Use context to compute MetadataAwareNameConverter cache 2019-11-06 17:10:14 +01:00
Stopwatch Merge branch '3.4' into 4.3 2019-11-05 15:48:09 +01:00
Templating Merge branch '3.4' into 4.3 2019-10-28 18:07:32 +01:00
Translation bug #34129 [FrameworkBundle][Translation] Invalidate cached catalogues when the scanned directories change (fancyweb) 2019-11-07 00:21:49 +01:00
Validator Merge branch '3.4' into 4.3 2019-11-05 15:48:09 +01:00
VarDumper Increase limits for flakey appveyor tests 2019-10-13 14:02:04 +02:00
VarExporter [VarExporter] fix support for PHP 7.4 2019-08-22 09:33:08 +02:00
WebLink Disable phpunit typehint patch on 4.3 branch 2019-08-08 11:29:19 +02:00
Workflow remove outdated workflow test 2019-10-29 03:10:02 +01:00
Yaml [4.3] Remove unused local variables 2019-10-30 13:58:49 +01:00