diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
416b70d5b2
symfony/tests/Symfony/Tests/Component
History
Fabien Potencier 416b70d5b2 merged branch conf/test-fixes-for-ci.qa.php.net-2.0 (PR #2750) 
Commits
-------

c1a798e Another style fix.
eba9de1 Code style fix.
0b1abb3 1. Separated testing diacritic letters with additional check for mbstring in Symfony\Tests\Component\Console\Helper\FormatterHelperTest.php. 2. Added check if French locale was correctly set, skip the test otherwise in  Symfony\Tests\Component\Yaml\InlineTest.php. 3. Inverted check for Windows platform since testing finding php with suffixes has meaning only in Windows in Symfony\Tests\Component\Process\PhpExecutableFinderTest.php.

Discussion
----------

Test fixes for ci.qa.php.net 2.0

This is remake of https://github.com/symfony/symfony/pull/2749 against 2.0 as requested by stof. Code style fix also applied.

Original message below:
My name is Shein Alexey and I'm writing on behalf of php-qa team. As you probably know we've set up build server for testing major php versions (5.3, 5.4 and trunk for now) on the url http://ci.qa.php.net. There's also an initiative also check these versions against major php projects with good test coverage like symfony.
In our symfony builds some tests constantly fail (see http://ci.qa.php.net/view/php-userland/job/php-symfony2/420/testReport/ for example) so here are the fixes I come up with:

Separated testing diacritic letters with additional check for mbstring in Symfony\Tests\Component\Console\Helper\FormatterHelperT
Added check if French locale was correctly set, skip the test otherwise in Symfony\Tests\Component\Yaml\InlineTest.php.
Inverted check for Windows platform since testing finding php with suffixes has meaning only in Windows in Symfony\Tests\Component\Process\PhpExecutableFinderTest.php.
There is also erratic test Symfony\Tests\Component\HttpKernel\HttpCache\HttpCacheTest:testFetchesFullResponseWhenCacheStaleAndNoValidatorsPresent which randomly fails when Age header is non-zero, I'm not sure what to do here, maybe this check should be deleted since page can have age greater than zero.

Let me know what you think.
Thank you.
2011-12-01 08:33:56 +01:00
..
BrowserKit [BrowserKit] Added additional unit tests for capital letters in cookies 2011-10-14 20:31:31 +01:00
ClassLoader [ClassLoader] Fixed state when trait_exists doesn't exists 2011-09-25 19:25:50 +02:00
Config removed unused use statements 2011-11-24 07:16:14 +01:00
Console Another style fix. 2011-11-30 02:46:26 +05:00
CssSelector UnitTest 2011-06-29 18:22:32 +02:00
DependencyInjection Throw exceptions in case someone forgot to set method name in call. 2011-11-30 15:59:17 +01:00
DomCrawler [DomCrawler] trim URI in getURI 2011-11-10 15:38:28 +01:00
EventDispatcher [EventDispatcher] Fix removeSubscriber() to work with priority syntax 2011-08-23 16:41:08 -04:00
Finder [Finder] added a convenience method Finder::create() 2011-06-14 14:18:24 +02:00
Form removed unused use statements 2011-11-24 07:16:14 +01:00
HttpFoundation updated unittest 2011-11-22 22:28:38 +01:00
HttpKernel [HttpKernel] added unit tests for previous merge 2011-11-24 08:39:49 +01:00
Locale Set error code when number cannot be parsed. Fixes #2389 2011-10-30 22:02:16 +00:00
Process 1. Separated testing diacritic letters with additional check for mbstring in Symfony\Tests\Component\Console\Helper\FormatterHelperTest.php. 2011-11-30 02:22:13 +05:00
Routing removed unused use statements 2011-11-24 07:16:14 +01:00
Security removed unused use statements 2011-11-24 07:16:14 +01:00
Serializer Updated SerializerTest with "normalizeTraversable" & "testNormalizeGivesPriorityToInterfaceOverTraversable" 2011-11-07 19:25:58 -08:00
Templating removed unused use statements 2011-10-29 11:56:30 +02:00
Translation [Translation] added detection for circular references when adding a fallback catalogue 2011-11-11 08:29:16 +01:00
Validator removed unused use statements 2011-10-29 11:56:30 +02:00
Yaml 1. Separated testing diacritic letters with additional check for mbstring in Symfony\Tests\Component\Console\Helper\FormatterHelperTest.php. 2011-11-30 02:22:13 +05:00