Archived

forked from https://github.com/symfony/symfony

This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Go to file

Fabien Potencier 45849ce306 merged branch Tobion/optionsresolver-optim (PR #4388 ) Commits ------- `bad4a1f` [OptionsResolver] CS fix in LazyOption `a54ea1b` [OptionsResolver] small optimization in Options class `104dcf2` [OptionsResolver] fixed bugs concerning required options `1bfcff4` [OptionsResolver] added failing test cases to demonstrate two bugs `37a3a29` [OptionsResolver] optimized validation Discussion ---------- [OptionsResolver] fixed two bugs and applied optimization The first commit optimizes the validation in OptionsResolver by removing several unneeded method calls (without changing anything semantically). Then I recognized two bugs in the current code that I wrote failing test cases for in the second commit. 1. setAllowedValues wrongly validated missing options 2. required options with defaults were considered missing by `resolve` (contrary to the `isRequired` method) The third commit fixes these bugs. The forth commit applies a small optimization in Options and uses a static function call for a static function. --------------------------------------------------------------------------- by travisbot at 2012-05-24T03:39:34Z This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1418785) (merged `a54ea1b6` into `b07fb3c4`). --------------------------------------------------------------------------- by travisbot at 2012-05-24T05:22:33Z This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1419232) (merged `bad4a1f7` into `b07fb3c4`). --------------------------------------------------------------------------- by bschussek at 2012-05-24T06:20:02Z I just tested this on my machine, and static calls are a tiny bit faster here, although this is really irrelevant for practical use. Even though I dislike useless micro-optimizations like this, I'm ok with this PR in general. --------------------------------------------------------------------------- by Tobion at 2012-05-24T13:23:11Z I didn't say that's an optimization in the first place. (The optimization was the removal of a variable assignment) I just changed it because in other PRs I've been told, static functions should be called in a static way. --------------------------------------------------------------------------- by Tobion at 2012-05-24T23:36:13Z Please merge before 4387		2012-05-25 09:54:05 +02:00
src/Symfony	merged branch Tobion/optionsresolver-optim (PR #4388 )	2012-05-25 09:54:05 +02:00
.gitignore	ignore composer.phar	2012-04-20 14:10:06 +01:00
.travis.yml	Force root package version in travis builds	2012-05-24 20:40:53 +02:00
autoload.php.dist	[Propel1] Removed useless require in autoload.php.dist	2012-04-20 09:46:34 +02:00
CHANGELOG-2.0.md	updated CHANGELOG for 2.0.14	2012-05-17 18:29:55 +02:00
composer.json	Added missing dependency to doctrine common in the global composer.json	2012-05-20 22:32:48 +02:00
CONTRIBUTORS.md	update CONTRIBUTORS for 2.0.14	2012-05-17 18:30:22 +02:00
LICENSE	Updated LICENSE files copyright	2012-02-22 10:10:37 +01:00
phpunit.xml.dist	Set init.default_locale to 'en' in phpunit.xml.dist	2012-05-11 09:33:42 +02:00
README.md	updated minimum PHP version to 5.3.3	2012-05-07 10:29:11 +02:00
UPGRADE-2.1.md	[Form] Clarified the usage of "constraints" in the UPGRADE file	2012-05-22 11:22:27 +02:00

README.md

README

What is Symfony2?

Symfony2 is a PHP 5.3 full-stack web framework. It is written with speed and flexibility in mind. It allows developers to build better and easy to maintain websites with PHP.

Symfony can be used to develop all kind of websites, from your personal blog to high traffic ones like Dailymotion or Yahoo! Answers.

Requirements

Symfony2 is only supported on PHP 5.3.3 and up.

Installation

The best way to install Symfony2 is to download the Symfony Standard Edition available at http://symfony.com/download.

Documentation

The "Quick Tour" tutorial gives you a first feeling of the framework. If, like us, you think that Symfony2 can help speed up your development and take the quality of your work to the next level, read the official Symfony2 documentation.

Contributing

Symfony2 is an open source, community-driven project. If you'd like to contribute, please read the Contributing Code part of the documentation. If you're submitting a pull request, please follow the guidelines in the Submitting a Patch section.