This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
symfony/tests/Symfony/Tests/Component
Fabien Potencier 318ae129ad merged branch Seldaek/url_validator (PR #1370)
Commits
-------

159fc0e [Validator] Added symbols to IDNs validation
c827faf [Validator] Add support for IDNs and custom TLDs

Discussion
----------

[Validator] Add support for IDNs and custom TLDs

Minor changes to allow for IDNs and [custom TLDs](http://news.softpedia.com/news/ICANN-Approves-New-Custom-Generic-Top-Level-Domains-Like-google-bank-206977.shtml). This is the only sane way to support everything in a timeless manner.

---------------------------------------------------------------------------

by stealth35 at 2011/06/20 04:32:09 -0700

maybe it should be check the host with idn_to_ascii (if function exists, maybe it's should recreate un punycode en/decoder in the stub)

---------------------------------------------------------------------------

by mvrhov at 2011/06/20 04:40:10 -0700

/me :faceslap.
Haven't seen the link in PR

---------------------------------------------------------------------------

by Seldaek at 2011/06/20 04:40:40 -0700

@mvrhov: Yup, that's what pushed me to reconsider adding this.

@stealth35: I'm not sure if this is needed. I don't want this to be too strict, with another validator or with an extra option I think we can make a check that the domain actually exists, or do a GET / on it or something, but this just checks validity of the syntax.

---------------------------------------------------------------------------

by stealth35 at 2011/06/20 04:48:05 -0700

I understand :)
what about funny IDN like : [☎.com] (http://xn--y3h.com/) ?

---------------------------------------------------------------------------

by Seldaek at 2011/06/20 04:53:19 -0700

@stealth35: Fixed

---------------------------------------------------------------------------

by stealth35 at 2011/06/20 04:56:18 -0700

it's seem great,for acceptable chars [RFC] (http://www.faqs.org/rfcs/rfc3490.html) said (with UseSTD3ASCIIRules option) :

	(a) Verify the absence of non-LDH ASCII code points; that is, the
         absence of 0..2C, 2E..2F, 3A..40, 5B..60, and 7B..7F.
2011-06-21 18:10:17 +02:00
..
BrowserKit fixed CS 2011-06-08 19:56:59 +02:00
ClassLoader fixed CS 2011-06-08 19:56:59 +02:00
Config [Config] renamed FileLoaderImportException to FileLoaderLoadException and replaced some \InvalidArgumentException with this new exception class 2011-06-20 10:16:05 +02:00
Console [Console] added unit tests for DialogHelper 2011-06-20 19:05:56 +02:00
CssSelector [CssSelector] renamed Parser::cssToXPath() to CssSelector::toXPath() 2011-06-15 07:55:23 +02:00
DependencyInjection [DependencyInjection] Fix a typo 2011-06-16 10:37:09 +02:00
DomCrawler [DomCrawler] Uppercase http methods 2011-05-25 15:45:23 +02:00
EventDispatcher Add missing "tearDown" functions, and some missing variable declaration (this saves for me almost 20MB when run all tests) 2011-06-16 15:06:36 +02:00
Finder [Finder] added a convenience method Finder::create() 2011-06-14 14:18:24 +02:00
Form Add missing "tearDown" functions, and some missing variable declaration (this saves for me almost 20MB when run all tests) 2011-06-16 15:06:36 +02:00
HttpFoundation Add missing "tearDown" functions, and some missing variable declaration (this saves for me almost 20MB when run all tests) 2011-06-16 15:06:36 +02:00
HttpKernel Renamed core.* events to kernel.* and CoreEvents to KernelEvents 2011-06-21 16:35:14 +02:00
Locale merged branch stealth35/master (PR #1346) 2011-06-16 15:07:27 +02:00
Process fixed CS 2011-06-08 19:56:59 +02:00
Routing [Routing] removed AnnotationGlobLoader 2011-06-17 18:18:03 +02:00
Security [Security] renamed UserProviderInterface::loadUser() to refreshUser() 2011-06-16 18:00:36 +02:00
Serializer fix tests 2011-06-10 01:11:51 +02:00
Templating Add missing "tearDown" functions, and some missing variable declaration (this saves for me almost 20MB when run all tests) 2011-06-16 15:06:36 +02:00
Translation fixed CS 2011-06-08 19:56:59 +02:00
Validator [Validator] Added symbols to IDNs validation 2011-06-20 13:52:36 +02:00
Yaml Add missing "tearDown" functions, and some missing variable declaration (this saves for me almost 20MB when run all tests) 2011-06-16 15:06:36 +02:00