4660857ffa
This PR was merged into the 4.1 branch.
Discussion
----------
[VarDumper] Fix dumping by splitting Server/Connection out of Dumper/ServerDumper
| Q | A
| ------------- | ---
| Branch? | 4.1
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #27622
| License | MIT
| Doc PR | -
Right now, the `dump()` function is broken on 4.1 as soon as one sets up a `dump_destination` for the dump server (as done by default by our Flex recipe). #27397 describes the issue and proposes a tentative fix. Yet, I think the issue is deeper and exists at the design level. Writting to the server should not happen in a `DumperInterface`, that's not its semantics. Instead, I propose a `Connection` object that will allow `DumpDataCollector` to have all the info it requires to do everything on its own.
My bad for not spotting this at the review stage.
Commits
-------
|
||
|---|---|---|
| .. | ||
| AjaxDataCollector.php | ||
| ConfigDataCollector.php | ||
| DataCollector.php | ||
| DataCollectorInterface.php | ||
| DumpDataCollector.php | ||
| EventDataCollector.php | ||
| ExceptionDataCollector.php | ||
| LateDataCollectorInterface.php | ||
| LoggerDataCollector.php | ||
| MemoryDataCollector.php | ||
| RequestDataCollector.php | ||
| RouterDataCollector.php | ||
| TimeDataCollector.php | ||