Archived

forked from https://github.com/symfony/symfony

This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Go to file

Fabien Potencier 4682b096f6 merged branch bschussek/issue3156 (PR #3218 ) Commits ------- `57cc531` [Form] Improved PHPDocs of choice lists `9e7e2af` [Form] Fixed PHPDoc: Used {@inheritdoc} where applicable `2c530cc` Fixed typos in UPGRADE file `7899bea` Added examples to UPGRADE `d346ae6` Improved choice list sections of UPGRADE and CHANGELOG `a676598` [Form] Added class LazyChoiceList Discussion ---------- [Form] Added LazyChoiceList Bug fix: no Feature addition: yes Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: - Todo: - ![Travis Build Status](https://secure.travis-ci.org/bschussek/symfony.png?branch=issue3156) Adds a ChoiceList implementation that satisfies people who formerly extended ArrayChoiceList and loaded choices lazily in its `load` method. --------------------------------------------------------------------------- by craue at 2012-01-30T12:56:49Z 👍 --------------------------------------------------------------------------- by craue at 2012-01-30T14:55:38Z Not sure if it's a bug in this PR or in #3156, but the labels get replaced by their keys: ```php <?php use Symfony\Component\Form\Extension\Core\ChoiceList\ChoiceList; use Symfony\Component\Form\Extension\Core\ChoiceList\LazyChoiceList; use Symfony\Component\Form\Extension\Core\ChoiceList\SimpleChoiceList; class MyChoiceList extends LazyChoiceList { protected function loadChoiceList() { $choices = array( 'bla' => 'blaaaaaahhhh', ); return new SimpleChoiceList($choices, array(), ChoiceList::COPY_CHOICE, ChoiceList::COPY_CHOICE); } public function getChoices() { $choices = parent::getChoices(); // $choices is array('bla' => 'bla') return $choices; } } ``` If it's not this PR, I can of course open a new ticket for that. But I'm only working with `LazyChoiceList`s. --------------------------------------------------------------------------- by stof at 2012-01-30T16:07:41Z @craue the ``SimpleChoiceList`` is an implementation using the same string as label and value. If you need different ones, you need to use the ``ChoiceList`` implementation. --------------------------------------------------------------------------- by craue at 2012-01-30T16:22:06Z @stof: That would make `SimpleChoiceList` useless for almost any case. Are you sure? --------------------------------------------------------------------------- by craue at 2012-01-30T16:33:31Z The bug even occurs when using ``` return new ChoiceList(array_keys($choices), array_values($choices), array(), ChoiceList::COPY_CHOICE, ChoiceList::COPY_CHOICE); ``` --------------------------------------------------------------------------- by stof at 2012-01-30T16:40:19Z well, the SimpleChoiceList is for simple cases (thus its naming) where you want the same for the label and the values. And if you look at the class, you will see it extends the ChoiceList implementation which is the generic one. --------------------------------------------------------------------------- by craue at 2012-01-30T16:53:36Z For me, "simple" would mean that it just takes the array given, using keys as indices and values as labels. No fancy stuff messing around with anything. :D But, is there anything wrong in this code or in mine? @bschussek: Please enlighten me. --------------------------------------------------------------------------- by bschussek at 2012-01-30T17:16:58Z You are both wrong :) `getChoices` does not return the choices with their associated labels anymore. What you get now are the choice indices as array keys and the choice values as array values. How both are determined depends on the index and value generation strategy, which, in your case, are both COPY_CHOICE. The difference between simple and complex choice lists is, that simple choice lists can only contain scalar values as choices, while other choice lists (such as ObjectChoiceList, EntityChoiceList) may contain objects as choices. Choice labels are now stored in ChoiceView objects, which are returned by the various `get*Views` methods. --------------------------------------------------------------------------- by craue at 2012-01-30T18:07:43Z It's pretty annoying having provided an array with keys and values when initializing the `ChoiceList` but being unable to retrieve it again. Guess I just over-used or even abused those choice lists as kind of (not only form related) lookup tables. --------------------------------------------------------------------------- by bschussek at 2012-01-30T19:27:21Z @craue: What's your use case? --------------------------------------------------------------------------- by craue at 2012-01-30T20:10:16Z I just used choice lists extensively, even for not directly form-related stuff. In one case, I'm using two of them (which are also used individually) to build up a third one. That went well using the old `ArrayChoiceList`s and their `getChoices` method. Just thinking about creating another set of model classes which just contain my lists. So for only one select field in a form it'll take three classes then: (A) a list, (B) a choice list based on A, (C) a choice form type based on B. Oh well ... :D --------------------------------------------------------------------------- by craue at 2012-01-30T21:31:32Z Anyway, this PR for `LazyChoiceList` is great, so please merge it. ;) --------------------------------------------------------------------------- by craue at 2012-01-31T14:00:46Z @bschussek: Is it ready to be merged? --------------------------------------------------------------------------- by bschussek at 2012-01-31T16:59:17Z Yes		2012-01-31 18:09:24 +01:00
src/Symfony	merged branch bschussek/issue3156 (PR #3218 )	2012-01-31 18:09:24 +01:00
tests	merged branch bschussek/issue3156 (PR #3218 )	2012-01-31 18:09:24 +01:00
.gitignore	Added vendor directory to .gitignore	2010-06-24 10:44:28 +02:00
.travis.yml	also test PHP 5.3.2, since this is the official lowest supported PHP version	2011-12-26 01:15:21 +01:00
autoload.php.dist	fixed autoloader when tests are run on a machine without intl installed	2011-07-20 14:27:10 +02:00
CHANGELOG-2.0.md	updated CHANGELOG for 2.0.9	2012-01-06 07:48:27 +01:00
CHANGELOG-2.1.md	Improved choice list sections of UPGRADE and CHANGELOG	2012-01-30 10:57:14 +01:00
check_cs	[Check CS] don't replace 'else if' on twig files (closes #2961 )	2011-12-27 16:10:32 +01:00
composer.json	Revert "merged 2.0"	2012-01-08 20:43:02 +01:00
CONTRIBUTORS.md	update CONTRIBUTORS for 2.0.9	2012-01-06 07:49:05 +01:00
LICENSE	added the LICENSE file for the YAML component	2011-02-18 11:52:11 +01:00
phpunit.xml.dist	[Security] cleaned up opt-in to benchmark test	2011-03-06 20:06:13 +01:00
README.md	set travis-ci icon to master	2011-11-23 11:36:09 +01:00
UPGRADE-2.1.md	Fixed typos in UPGRADE file	2012-01-30 13:36:34 +01:00
vendors.php	updated vendors for 2.0.8	2011-12-26 11:50:33 +01:00

README.md

README

What is Symfony2?

Symfony2 is a PHP 5.3 full-stack web framework. It is written with speed and flexibility in mind. It allows developers to build better and easy to maintain websites with PHP.

Symfony can be used to develop all kind of websites, from your personal blog to high traffic ones like Dailymotion or Yahoo! Answers.

Requirements

Symfony2 is only supported on PHP 5.3.2 and up.

Installation

The best way to install Symfony2 is to download the Symfony Standard Edition available at http://symfony.com/download.

Documentation

The "Quick Tour" tutorial gives you a first feeling of the framework. If, like us, you think that Symfony2 can help speed up your development and take the quality of your work to the next level, read the official Symfony2 documentation.

Contributing

Symfony2 is an open source, community-driven project. If you'd like to contribute, please read the Contributing Code part of the documentation. If you're submitting a pull request, please follow the guidelines in the Submitting a Patch section.