Archived

forked from https://github.com/symfony/symfony

This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Go to file

Fabien Potencier 4b521985f1 merged branch vicb/lenient_generator (PR #5114 ) Commits ------- `03bbaaf` [Routing] Add an interface for configuring strict_parameters Discussion ---------- [RFC][Routing] Add an interface for configuring strict_parameters This is a proposal to fix #4697 (related to #4592). The main point left to discuss was the name of the interface, which is now `LenientInterface`. We could change the name to anything else is someone has a better idea. @stof @Tobion what do you think ? --------------------------------------------------------------------------- by stof at 2012-07-30T16:34:20Z @vicb I already said I had no idea to name it, and it has not changed. :) So let's wait for other people to see if they have a better idea --------------------------------------------------------------------------- by breerly at 2012-07-30T16:38:38Z Maybe `PermissibleInterface` or `PermissiveInterface`. --------------------------------------------------------------------------- by Partugal at 2012-07-30T17:00:09Z `StrictUrlGeneratorInterface`, `StrictParametersInterface` or `StrictInterface` --------------------------------------------------------------------------- by pborreli at 2012-07-30T17:04:46Z 👍 for `PermissiveInterface` --------------------------------------------------------------------------- by stof at 2012-07-30T17:07:59Z yes, because the Router currently can only use this interface to set it to ``not-strict``. It assumes that the url generator is already strict by default (which is probably a bad assumption btw as the base class for the generated generator can be changed) --------------------------------------------------------------------------- by pborreli at 2012-07-30T17:09:33Z @stof thx, got it --------------------------------------------------------------------------- by Partugal at 2012-07-30T17:10:03Z this interface realize setting Strict by setStrictParameters, and get by getStrictParameters, and imho named it by `Strictable` is more logic --------------------------------------------------------------------------- by pborreli at 2012-07-30T17:11:07Z @Partugal let's try to find an english term :) --------------------------------------------------------------------------- by Partugal at 2012-07-30T17:11:31Z ) --------------------------------------------------------------------------- by breerly at 2012-07-30T17:15:23Z @Partugal I like using "able" in interface names because it describes a behavior instead of a noun. This type of naming makes following the Interface Segregation Principle easy to follow. Good work. --------------------------------------------------------------------------- by vicb at 2012-07-30T18:24:26Z As explained by @stof I did not consider `StrictInterface` because as of now the interface is used to disabled the strict bevahior (which is enabled by default). I am not satisfied with `PermissiveInterface` / `LenientInterface` because implementing this interface does not mean that the generator will be permissive but only that the behavior is configurable - yes I did consider `Configurable` but the term is a too vague. --------------------------------------------------------------------------- by breerly at 2012-07-30T18:35:45Z I see. Perhaps ```StrictConfigurableInterface``` would do the trick. --------------------------------------------------------------------------- by Tobion at 2012-07-30T21:02:21Z I think renaming strict_parameters to `strict_requirements` is the way to go because it determines how requirements are handled when generating a URL. Also we should allow another option: strict_requirements = true: throw exception for mismatching requirements strict_requirements = null: return null as URL for mismatching requirements and log it. strict_requirements = false: return the URL with the given parameters without checking the requirements and don't log it. (Maybe use constants for these). The Interface I would then call `ConfigurableRequirementsInterface` or `RequirementsHandlingInterface`. --------------------------------------------------------------------------- by vicb at 2012-07-31T07:23:24Z Thanks all for the feeback, this is what is now implemented: - A `ConfigurableRequirementsInterface` that should be implemented by generators that can be configure not to throw an exception when the parameters do not match the requirements, - The interface has two methods: `setStrictRequirements()` and `isStrictRequirements()`, - `setStrictRequirements()` always gets called to configure the generator (whatever the option value is) Note: The Router option name has not changed (i.e. `strict_parameters`) Does that fit everyone ? --------------------------------------------------------------------------- by vicb at 2012-07-31T07:39:22Z So the option name is now consistent (`strict_requirements`) with the interface. We should sync the change [in the standard edition](https://github.com/symfony/symfony-standard/blob/master/app/config/config.yml#L11) if we agree to merge this. --------------------------------------------------------------------------- by fabpot at 2012-07-31T07:51:47Z @vicb you forgot to rename the property in `UrlGenerator` as @stof mentioned above. --------------------------------------------------------------------------- by vicb at 2012-07-31T07:59:57Z @fabpot fixed. If the code is ok, I'll squash the commits and open a PR on symfony-standard		2012-07-31 16:16:14 +02:00
src/Symfony	merged branch vicb/lenient_generator (PR #5114 )	2012-07-31 16:16:14 +02:00
.editorconfig	Add EditorConfig File	2012-06-16 14:08:15 +02:00
.gitignore	ignore composer.phar	2012-04-20 14:10:06 +01:00
.travis.yml	Revert "merged branch stof/travis_version (PR #4905 )"	2012-07-15 12:13:31 +02:00
autoload.php.dist	removed unneeded code	2012-06-30 16:47:41 +02:00
CHANGELOG-2.0.md	updated CHANGELOG for 2.0.14	2012-05-17 18:29:55 +02:00
composer.json	[Form] Improved FormRenderer API to reduce the size of the function call stack during rendering	2012-07-22 09:29:35 +02:00
CONTRIBUTORS.md	update CONTRIBUTORS for 2.0.14	2012-05-17 18:30:22 +02:00
LICENSE	Updated LICENSE files copyright	2012-02-22 10:10:37 +01:00
phpunit.xml.dist	Set init.default_locale to 'en' in phpunit.xml.dist	2012-05-11 09:33:42 +02:00
README.md	added some warnings about known PHP bugs	2012-07-15 12:19:52 +02:00
UPGRADE-2.1.md	[Form] Fixed ResolvedFormType to really be replaceable	2012-07-29 19:13:45 +02:00

README.md

README

What is Symfony2?

Symfony2 is a PHP 5.3 full-stack web framework. It is written with speed and flexibility in mind. It allows developers to build better and easy to maintain websites with PHP.

Symfony can be used to develop all kind of websites, from your personal blog to high traffic ones like Dailymotion or Yahoo! Answers.

Requirements

Symfony2 is only supported on PHP 5.3.3 and up.

Be warned that PHP versions before 5.3.8 are known to be buggy and might not work for you:

before PHP 5.3.4, if you get "Notice: Trying to get property of non-object", you've hit a known PHP bug (see https://bugs.php.net/bug.php?id=52083 and https://bugs.php.net/bug.php?id=50027);
before PHP 5.3.8, if you get an error involving annotations, you've hit a known PHP bug (see https://bugs.php.net/bug.php?id=55156).

Installation

The best way to install Symfony2 is to download the Symfony Standard Edition available at http://symfony.com/download.

Documentation

The "Quick Tour" tutorial gives you a first feeling of the framework. If, like us, you think that Symfony2 can help speed up your development and take the quality of your work to the next level, read the official Symfony2 documentation.

Contributing

Symfony2 is an open source, community-driven project. If you'd like to contribute, please read the Contributing Code part of the documentation. If you're submitting a pull request, please follow the guidelines in the Submitting a Patch section.