4e32643bdf
This PR was merged into the 4.4 branch.
Discussion
----------
[Validator] Add a Length::$allowEmptyString option to reject empty strings
| Q | A
| ------------- | ---
| Branch? | 4.4 <!-- see below -->
| Bug fix? | no
| New feature? | yes <!-- please update src/**/CHANGELOG.md files -->
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->
| License | MIT
| Doc PR | Todo (change the warning on top of https://symfony.com/doc/current/reference/constraints/Length.html)
which defaults to `true` in 4.4 but will trigger a deprecation if not set explicitly
in order to make the default `false` in 5.0.
While it could be solved now thanks to #29641 by using both `@Length(min=1)` & `@NotBlank(allowNull=true)` constraints,
as expressed in https://github.com/symfony/symfony/issues/27876#issuecomment-403307783 and following comments, the `@Length(min=1)` behavior doesn't match our expectations when reading it: it feels logical to invalidate empty strings, but it actually doesn't.
Hence the proposal of making the behavior of rejecting empty strings the default in 5.0.
In my opinion, the flag could even be removed later.
Commits
-------
|
||
|---|---|---|
| .. | ||
| CacheWarmer | ||
| DataCollector | ||
| DataFixtures | ||
| DependencyInjection | ||
| Form | ||
| Logger | ||
| Messenger | ||
| PropertyInfo | ||
| Security | ||
| Test | ||
| Tests | ||
| Validator | ||
| .gitignore | ||
| CHANGELOG.md | ||
| composer.json | ||
| ContainerAwareEventManager.php | ||
| LICENSE | ||
| ManagerRegistry.php | ||
| phpunit.xml.dist | ||
| README.md | ||
| RegistryInterface.php | ||