diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
5145084808
symfony/src/Symfony/Component/Form
History
Fabien Potencier 5145084808 bug #28840 add missing double-quotes to extra_fields output message (danielkay) 
This PR was squashed before being merged into the 2.8 branch (closes #28840).

Discussion
----------

add missing double-quotes to extra_fields output message

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

When using the extra_fields_message option on FormTypes to include the extra_fields items in the message, the output included some superfluous (or, perhaps, missing?) quotes. This resulted in some strange output: `This form should not contain extra fields: notes1\", \"notes2\", \"notes3`.

This PR removes the quotes and instead implodes the extra_fields array using merely ', ' as the glue, resulting in the output: `This form should not contain extra fields: notes1, notes2, notes3`.

Commits
-------

9e7414159c add missing double-quotes to extra_fields output message
2018-10-17 15:52:59 +02:00
..
ChoiceList [CS] Enforces null type hint on last position in phpDocs 2018-10-02 00:12:00 -03:00
Deprecated fixed some deprecation messages 2017-12-31 05:55:05 +01:00
Exception Enable the fixer enforcing fully-qualified calls for compiler-optimized functions 2018-07-24 12:05:38 +02:00
Extension bug #28840 add missing double-quotes to extra_fields output message (danielkay) 2018-10-17 15:52:59 +02:00
Guess Remove useless docblocks 2017-10-29 10:49:53 +01:00
Resources [Validator] Remove BOM in some xlf files 2018-06-19 10:02:14 +02:00
Test Consistently throw exceptions on a single line 2018-09-08 14:44:02 +02:00
Tests bug #28840 add missing double-quotes to extra_fields output message (danielkay) 2018-10-17 15:52:59 +02:00
Util fixed CS 2018-10-11 04:32:54 -07:00
.gitignore Added missing files .gitignore 2013-07-21 14:12:18 +02:00
AbstractExtension.php Enable the fixer enforcing fully-qualified calls for compiler-optimized functions 2018-07-24 12:05:38 +02:00
AbstractRendererEngine.php Enable the fixer enforcing fully-qualified calls for compiler-optimized functions 2018-07-24 12:05:38 +02:00
AbstractType.php Enable the fixer enforcing fully-qualified calls for compiler-optimized functions 2018-07-24 12:05:38 +02:00
AbstractTypeExtension.php Enable the fixer enforcing fully-qualified calls for compiler-optimized functions 2018-07-24 12:05:38 +02:00
Button.php [CS] Enforces null type hint on last position in phpDocs 2018-10-02 00:12:00 -03:00
ButtonBuilder.php Alpha-ordering for "use" statements 2018-07-26 11:03:18 +02:00
ButtonTypeInterface.php [Form] Implemented support for buttons 2013-04-13 16:46:28 +02:00
CallbackTransformer.php Alpha-ordering for "use" statements 2018-07-26 11:03:18 +02:00
CHANGELOG.md Merge branch '2.7' into 2.8 2017-11-16 17:20:19 +02:00
ClickableInterface.php removed dots at the end of @param and @return 2016-06-28 08:24:06 +02:00
composer.json Fix security/* cross-dependencies 2018-05-17 12:20:34 +02:00
DataMapperInterface.php [CS] Apply phpdoc_annotation_without_dot 2017-09-11 13:37:52 -07:00
DataTransformerInterface.php [CS] Apply phpdoc_annotation_without_dot 2017-09-11 13:37:52 -07:00
Form.php Consistently throw exceptions on a single line 2018-09-08 14:44:02 +02:00
FormBuilder.php Alpha-ordering for "use" statements 2018-07-26 11:03:18 +02:00
FormBuilderInterface.php Fixed PHPdoc return references in FormBuilderInterface 2017-06-08 17:18:54 +10:00
FormConfigBuilder.php Consistently throw exceptions on a single line 2018-09-08 14:44:02 +02:00
FormConfigBuilderInterface.php fixed CS 2018-10-11 04:32:54 -07:00
FormConfigInterface.php [CS] Enforces null type hint on last position in phpDocs 2018-10-02 00:12:00 -03:00
FormError.php [DI] minor docblock fixes 2017-10-24 13:40:19 +02:00
FormErrorIterator.php Consistently throw exceptions on a single line 2018-09-08 14:44:02 +02:00
FormEvent.php [2.7] More docblock fixes 2017-11-07 15:04:08 +01:00
FormEvents.php Merge branch '2.6' into 2.7 2015-05-02 17:21:08 +02:00
FormExtensionInterface.php [2.3][Form] Cleanup & fix phpdocs 2014-07-09 12:39:32 +02:00
FormFactory.php Enable the fixer enforcing fully-qualified calls for compiler-optimized functions 2018-07-24 12:05:38 +02:00
FormFactoryBuilder.php Enable the fixer enforcing fully-qualified calls for compiler-optimized functions 2018-07-24 12:05:38 +02:00
FormFactoryBuilderInterface.php [DI] minor docblock fixes 2017-10-24 13:40:19 +02:00
FormFactoryInterface.php [Form] Deprecated FormTypeInterface::getName() and passing of type instances 2015-07-02 10:02:46 +02:00
FormInterface.php fixed CS 2018-10-11 04:32:54 -07:00
FormRegistry.php Alpha-ordering for "use" statements 2018-07-26 11:03:18 +02:00
FormRegistryInterface.php [Form] remove validation of FormRegistry::getType as FormRegistry::hasType does not validate either 2015-10-22 02:46:43 +02:00
FormRenderer.php Alpha-ordering for "use" statements 2018-07-26 11:03:18 +02:00
FormRendererEngineInterface.php fixed CS 2018-10-11 04:32:54 -07:00
FormRendererInterface.php Fix code examples in PHPDoc 2018-08-29 15:11:53 +02:00
Forms.php Fix code examples in PHPDoc 2018-08-29 15:11:53 +02:00
FormTypeExtensionInterface.php [DI] minor docblock fixes 2017-10-24 13:40:19 +02:00
FormTypeGuesserChain.php Alpha-ordering for "use" statements 2018-07-26 11:03:18 +02:00
FormTypeGuesserInterface.php DX: replace @link with @see annotation 2016-11-13 18:41:36 +01:00
FormTypeInterface.php [CS] Enforces null type hint on last position in phpDocs 2018-10-02 00:12:00 -03:00
FormView.php Enable the fixer enforcing fully-qualified calls for compiler-optimized functions 2018-07-24 12:05:38 +02:00
LICENSE fixed years in copyright 2018-01-03 08:23:28 +01:00
NativeRequestHandler.php Enable the fixer enforcing fully-qualified calls for compiler-optimized functions 2018-07-24 12:05:38 +02:00
phpunit.xml.dist fail when detecting risky tests 2017-04-12 09:39:27 +02:00
PreloadedExtension.php Enable the fixer enforcing fully-qualified calls for compiler-optimized functions 2018-07-24 12:05:38 +02:00
README.md Updated all the README files 2016-03-04 08:12:06 +01:00
RequestHandlerInterface.php [Form] Add phpdoc to RequestHandlerInterface::isFileUpload() method 2017-11-20 18:59:30 +01:00
ResolvedFormType.php Consistently throw exceptions on a single line 2018-09-08 14:44:02 +02:00
ResolvedFormTypeFactory.php
ResolvedFormTypeFactoryInterface.php [Form] fix and unify phpdoc 2013-10-31 15:15:49 +01:00
ResolvedFormTypeInterface.php fixed @return when returning this or static 2016-12-27 11:52:11 +01:00
ReversedTransformer.php [DI] minor docblock fixes 2017-10-24 13:40:19 +02:00
SubmitButton.php [CS] Enforces null type hint on last position in phpDocs 2018-10-02 00:12:00 -03:00
SubmitButtonBuilder.php [Form] fix and unify phpdoc 2013-10-31 15:15:49 +01:00
SubmitButtonTypeInterface.php [Form] Implemented support for buttons 2013-04-13 16:46:28 +02:00

README.md

Form Component

The Form component allows you to easily create, process and reuse HTML forms.

Resources