diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
6463c9919c
symfony/src/Symfony/Bundle/FrameworkBundle/Tests
History
Fabien Potencier 6463c9919c merged branch docteurklein/fix-router-resolve-string (PR #4995) 
This PR was merged into the master branch.

Commits
-------

4b86765 [FrameworkBundle] recursively resolve container parameter placeholders for arrays in router _defaults

Discussion
----------

[2.2] [FrameworkBundle] avoid trying to resolve container placeholders on arrays on router _defaults

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: ~
Todo: ~
License of the code: MIT
Documentation PR: ~

Permits to pass arrays in route `_defaults`.

---------------------------------------------------------------------------

by stof at 2012-07-20T13:07:36Z

This seems weird. An array could contain parameters in it.

---------------------------------------------------------------------------

by docteurklein at 2012-07-20T13:17:00Z

@stof An object too then, no ? Why accepting objects but not arrays ? Would you propose to recursively resolve array values ?

---------------------------------------------------------------------------

by stof at 2012-07-20T13:31:06Z

@docteurklein Resolving array values recursively would be consistent with the way the DIC parameters are resolved. I don't really see how you would resolve objects (and btw, it is pretty much an edge case as you cannot really put an object in your routes if you define them in your YAML or XML config files or with annotations)

---------------------------------------------------------------------------

by docteurklein at 2012-07-20T13:36:43Z

@stof I agree. I can manage recursive array resolving if needed.

---------------------------------------------------------------------------

by fabpot at 2012-07-23T13:58:07Z

Can you squash your commits before I merge? Thanks.

---------------------------------------------------------------------------

by docteurklein at 2012-07-23T14:39:17Z

@fabpot  done.
2012-10-05 19:11:53 +02:00
..
CacheWarmer fixed CS 2012-07-09 14:54:20 +02:00
Command [FrameworkBundle] removed obsolete file 2010-09-24 16:34:03 +02:00
Console [FrameworkBundle] added test for fix broken command registration 2012-08-03 13:33:31 +02:00
Controller [FrameworkBundle] non-permanent redirect should be status code 404 according to spec 2012-08-28 08:03:23 +02:00
DependencyInjection merged branch fabpot/profiler-tests (PR #4897) 2012-09-18 16:35:58 +02:00
EventListener moved component and bridge unit tests to the src/ directory 2012-03-29 08:37:22 +02:00
Fixtures fixed CS (missing or misplaced license blocks) 2012-04-02 00:52:14 -03:00
Functional [FrameworkBundle] fixed functional tests 2012-09-19 06:19:30 +02:00
Routing [FrameworkBundle] recursively resolve container parameter placeholders 2012-07-23 16:44:28 +02:00
Templating [Form] Moved FormHelper back to FrameworkBundle 2012-07-31 16:35:46 +02:00
Translation [FrameworkBundle] removed duplicated line 2012-06-28 16:05:05 +02:00
Validator replaced symfony-project.org by symfony.com 2011-03-06 12:40:06 +01:00
HttpKernelTest.php fixed CS 2012-07-09 14:54:20 +02:00
TestCase.php replaced symfony-project.org by symfony.com 2011-03-06 12:40:06 +01:00