This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Fabien Potencier 649872be85 merged branch jonathaningram/issue_5375 (PR #5376) ... This PR was merged into the 2.0 branch. Commits ------- a094f7e Add check to Store::unlock to ensure file exists Discussion ---------- [2.0] [HttpKernel] Add check to Store::unlock to ensure file exists Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes I was seeing this error in my logs when using an `AppCache`: ``` Error 2: /var/www/beta.example.com/shared/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpCache/Store.php line 92: unlink(/var/www/beta.example.com/releases/20120827020525/app/cache/beta/http_cache/md/c2/88/66a911b5266a57bdd55131a47895b8861dfd.lck): No such file or directory ``` It was only occurring when the `http_cache` file was being primed (i.e. first load). I've added a simple check to ensure that the file is a valid file before trying to unlink. I also added a missing `@return` docblock. Note: I've chosen to return `false` if the file does not exist as this seems to be the behaviour of the `purge` method. --------------------------------------------------------------------------- by jonathaningram at 2012-08-29T06:46:52Z @henrikbjorn done and rebased. Thanks. --------------------------------------------------------------------------- by jonathaningram at 2012-09-17T22:38:47Z @henrikbjorn any news on this one? It's currently not possible to use the HTTP Cache without the first request failing. --------------------------------------------------------------------------- by jonathaningram at 2012-09-25T01:28:38Z ping @fabpot sorry to keep pushing this, but any chance you could take a look at this?		2012-10-27 18:34:13 +02:00
..
Symfony/Tests	merged branch jonathaningram/issue_5375 (PR #5376)	2012-10-27 18:34:13 +02:00
bootstrap.php	replaced symfony-project.org by symfony.com	2011-03-06 12:40:06 +01:00