7a461cff0c
This PR was merged into the 4.1-dev branch.
Discussion
----------
[DI] Put non-shared service factories in closures
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
With this change, non-shared services are moved to dedicated files (unless they are on the hot path).
Previously, they were always dumped as methods.
The goal of this change is to dump factories as methods *if and only if* the services they build are on the hot-path. By doing so, it will become very easy to figure out which services are on the hot path, vs the rest. And then people will be able to optimize their configurations: if too many things are dumped as methods, it will trivially mean some laziness is missing in definitions.
I spotted this while reviewing the dumped container of Blackfire, where we sometimes have long chains of dependencies that are on the hot path for no real reason - mixed with big non-shared factories (Sonata admin blocks in our case.)
Commits
-------
|
||
|---|---|---|
| .. | ||
| php_with_wrong_ext.yml | ||
| services1-1.php | ||
| services1.php | ||
| services8.php | ||
| services9_as_files.txt | ||
| services9_compiled.php | ||
| services10.php | ||
| services12.php | ||
| services13.php | ||
| services19.php | ||
| services24.php | ||
| services26.php | ||
| services33.php | ||
| services_almost_circular_private.php | ||
| services_almost_circular_public.php | ||
| services_array_params.php | ||
| services_base64_env.php | ||
| services_csv_env.php | ||
| services_env_in_id.php | ||
| services_inline_requires.php | ||
| services_locator.php | ||
| services_private_frozen.php | ||
| services_private_in_expression.php | ||
| services_rot13_env.php | ||
| services_subscriber.php | ||
| services_uninitialized_ref.php | ||
| simple.php | ||