forked from https://github.com/symfony/symfony

This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Go to file

Fabien Potencier 7dbadbf29a merged branch eriksencosta/icu-data-update (PR #5107 ) Commits ------- `33105e0` [Locale] added more information to the README.md regarding the need to build the ICU data when the intl extension ICU data version mismatch the one shipped with Symfony `3191c70` [Validator] fixed tests, ICU 4.4 (Travis version) does not have the "my" locale `d7b6bb3` [Locale] updated README.md `6456361` [Locale] added note about ICU data building: use the same PHP intl/ICU version as the desired version to build `025f972` [Locale] renamed function `8da99ca` [Locale] updated CHANGELOG.md `d909360` [Locale] don't create a "current" directory anymore, uses only the ICU version as the name of the data directory `3f2b4bf` [Locale] changed build data script name `61e3539` [Form][Locale] updated minimum ICU version to 4.0 `0d442c7` [Locale] as of ICU 4.8+, slash ("/") and dash ("-") are interchangeable, you can use any of them in a date/time pattern `90d6dc3` [Locale] fixed tests `86da1b3` [Locale] added ICU update-data script to be run before the test suite `5fd4eb1` [Locale] updated ICU data paths `64ccee7` [Locale] updated ICU data `0d0a8d4` [Locale] updated script to generate separated data directories for different ICU releases Discussion ---------- [2.1][Locale] ICU data update Bug fix: no Feature addition: yes Backwards compatibility break: no Symfony2 tests pass: no Fixes the following tickets: Todo: - License of the code: MIT [![Build Status](https://secure.travis-ci.org/eriksencosta/symfony.png?branch=icu-data-update)](http://travis-ci.org/eriksencosta/symfony) The tests are passing in Travis only because it uses ICU 4.4. The tests fails in ICU 4.8 and 49.1. The data files now are up-to-date with ICU 49.1.2. The fails are consistent between 32 and 64 bit for the PHP 5.3.3, 5.3.14 and 5.4.4 (each one compiled with ICU 4.2 to 49). Basically tests that relies on Locale will have some idiosyncrasies: - Some tests will assert a different value for different ICU versions, mostly for currency/date formatting - Some tests will skip if not the latest ICU release, code that format/parse something that is directly based on ICU behavior will always implement the behavior from the latest release - Some tests will make different assertions for different PHP versions (we already have them, just to note) The Composer script handler was a very quick implementation, I accept suggestions about it. It basically invokes the `update-data.php` script. I will also rename this script later since it now behave a little bit different from the original script. @fabpot, @stof: should I add mine Composer `post-install-cmd` script in both the project root and component `composer.json` file? I'm planning to configure a CI server with a setup similar with mine Symfony development environment to run jobs with the different PHP/ICU releases for the Locale component. But most importantly is to document how I did it since it took a lot of time to have an enviroment that supports all this "ICU hell development". Also, there are some pitfalls regarding testing and to generating the resource bundles for the different ICU versions. Almost there! I'll try to update later tomorrow (monday). --------------------------------------------------------------------------- by fabpot at 2012-07-30T08:14:29Z I would not have added the script in the `composer.json` file but in the `.travis.yml` file directly instead. We don't want this script to be run whenever someone run composer on the repository. --------------------------------------------------------------------------- by eriksencosta at 2012-07-31T03:07:58Z Ok, moved the script call to the `.travis.yml` file. --------------------------------------------------------------------------- by eriksencosta at 2012-07-31T12:38:23Z @stof The last commit was just to backup WIP changes and to ask something to @igorw, it is mine "stage" :) --------------------------------------------------------------------------- by travisbot at 2012-08-06T03:05:16Z This pull request [fails](http://travis-ci.org/symfony/symfony/builds/2044244) (merged c6a1dcd1 into `20d2e5a1`). --------------------------------------------------------------------------- by travisbot at 2012-08-06T03:16:12Z This pull request [fails](http://travis-ci.org/symfony/symfony/builds/2044311) (merged 76868419 into `20d2e5a1`). --------------------------------------------------------------------------- by travisbot at 2012-08-06T03:52:20Z This pull request [fails](http://travis-ci.org/symfony/symfony/builds/2044425) (merged 7e768eb2 into `20d2e5a1`). --------------------------------------------------------------------------- by travisbot at 2012-08-06T04:04:30Z This pull request [fails](http://travis-ci.org/symfony/symfony/builds/2044461) (merged edaca423 into `20d2e5a1`). --------------------------------------------------------------------------- by eriksencosta at 2012-08-06T04:33:55Z Ready for primetime. The failed test is not related with mine changes. --------------------------------------------------------------------------- by travisbot at 2012-08-07T02:32:19Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/2053806) (merged 386d20c8 into `842b599c`). --------------------------------------------------------------------------- by fabpot at 2012-08-07T13:51:59Z After merging this PR, I have more failing tests on my machine: PHP 5.3.8 - ICU 4.4.1 Is it expected? Is yes, how do we need to run the tests locally? --------------------------------------------------------------------------- by eriksencosta at 2012-08-07T14:56:23Z @fabpot Yep, it is expected. You'll need to build the ICU data for this version and export the `USE_INTL_ICU_DATA_VERSION` before running the tests: php src/Symfony/Component/Locale/Resources/data/build-data.php export USE_INTL_ICU_DATA_VERSION=1 phpunit src/Symfony/Component/Locale/Tests The errors happens because the implementation is in sync with the behavior of ICU 49.1.2 and the shipped data is from data version too. Maybe I should add the steps above in the components `README.md` since it is more straightforward. --------------------------------------------------------------------------- by fabpot at 2012-08-07T14:58:44Z @eriksencosta Yes, that would be good to add some more information in the README file. --------------------------------------------------------------------------- by eriksencosta at 2012-08-07T15:21:04Z @fabpot Done! --------------------------------------------------------------------------- by eriksencosta at 2012-08-07T15:21:29Z And rebased.		2012-08-07 17:32:32 +02:00
src/Symfony	[Locale] added more information to the README.md regarding the need to build the ICU data when the intl extension ICU data version mismatch the one shipped with Symfony	2012-08-07 12:17:03 -03:00
.editorconfig	Add EditorConfig File	2012-06-16 14:08:15 +02:00
.gitignore	ignore composer.phar	2012-04-20 14:10:06 +01:00
.travis.yml	[Locale] don't create a "current" directory anymore, uses only the ICU version as the name of the data directory	2012-08-07 12:17:02 -03:00
CHANGELOG-2.0.md	merged 2.0	2012-08-03 11:11:11 +02:00
CONTRIBUTORS.md	update CONTRIBUTORS for 2.0.14	2012-05-17 18:30:22 +02:00
LICENSE	Updated LICENSE files copyright	2012-02-22 10:10:37 +01:00
README.md	added some warnings about known PHP bugs	2012-07-15 12:19:52 +02:00
UPGRADE-2.1.md	Added before/after examples of change in registering security factories to upgrade info.	2012-08-02 12:39:17 +01:00
autoload.php.dist	removed unneeded code	2012-06-30 16:47:41 +02:00
composer.json	[Composer] Bumped doctrine/orm to 2.2.3	2012-07-31 16:51:24 +02:00
phpunit.xml.dist	Set init.default_locale to 'en' in phpunit.xml.dist	2012-05-11 09:33:42 +02:00

README.md

README

What is Symfony2?

Symfony2 is a PHP 5.3 full-stack web framework. It is written with speed and flexibility in mind. It allows developers to build better and easy to maintain websites with PHP.

Symfony can be used to develop all kind of websites, from your personal blog to high traffic ones like Dailymotion or Yahoo! Answers.

Requirements

Symfony2 is only supported on PHP 5.3.3 and up.

Be warned that PHP versions before 5.3.8 are known to be buggy and might not work for you:

before PHP 5.3.4, if you get "Notice: Trying to get property of non-object", you've hit a known PHP bug (see https://bugs.php.net/bug.php?id=52083 and https://bugs.php.net/bug.php?id=50027);
before PHP 5.3.8, if you get an error involving annotations, you've hit a known PHP bug (see https://bugs.php.net/bug.php?id=55156).

Installation

The best way to install Symfony2 is to download the Symfony Standard Edition available at http://symfony.com/download.

Documentation

The "Quick Tour" tutorial gives you a first feeling of the framework. If, like us, you think that Symfony2 can help speed up your development and take the quality of your work to the next level, read the official Symfony2 documentation.

Contributing

Symfony2 is an open source, community-driven project. If you'd like to contribute, please read the Contributing Code part of the documentation. If you're submitting a pull request, please follow the guidelines in the Submitting a Patch section.