Archived

forked from https://github.com/symfony/symfony

This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Go to file

Fabien Potencier 813f6b3bb5 merged branch jocl/master (PR #4211 ) Commits ------- `d3fee9b` [Finder] ignoreDotFiles(true) filter does not match (issue #4106) Discussion ---------- Fix for issue #4106 [Finder] ignoreDotFiles(true) filter does not match I added new dot test files: * .bar * .foo/ * .foo/.bar Changed the tests and made a fix to finder that seems to okay for me. I hope my first PR is well arranged ;-) If not I will be pleased to get feedback... --------------------------------------------------------------------------- by vicb at 2012-05-11T10:20:51Z Could you squash you commits ? There is also an issue when `ignoreDotFiles(false)` is called twice, could you add a failing TC and fix the code ? `$this->ignore = $this->ignore ^ static::IGNORE_DOT_FILES;` should be `$this->ignore = $this->ignore & ~static::IGNORE_DOT_FILES;` --------------------------------------------------------------------------- by travisbot at 2012-05-11T12:43:53Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1304510) (merged 72c320bc into `ff7c4757`). --------------------------------------------------------------------------- by vicb at 2012-05-11T13:09:32Z You need to: - tackle the related issue I have mentioned, - squash the commit, - rebase, - force push to your branch. http://symfony.com/doc/current/contributing/code/patches.html has some more info. As a fix, did you consider sending it to the 2.0 branch - your mention it as a BC in the commit comment but it really is a bug fix. --------------------------------------------------------------------------- by jocl at 2012-05-11T13:33:30Z Thank you. I will try it. Hasn't ```ignoreVCS(false)``` the same twice calling problem with ```$this->ignore = $this->ignore ^ static::IGNORE_VCS_FILES;```? --------------------------------------------------------------------------- by vicb at 2012-05-11T13:36:22Z yep, good catch ! --------------------------------------------------------------------------- by jocl at 2012-05-12T10:32:06Z I mentioned it as BC, since I found no place in documentation with the information that dotFiles are ignored by default. I was also wondering that it is default behavior. But if I only read the code, it is a 100% bug. As soon as the PR is merged, I think we should also add a little notice in documentation like it is for ignoreVCS(): http://symfony.com/doc/master/components/finder.html#files-or-directories --------------------------------------------------------------------------- by fabpot at 2012-05-15T05:47:49Z I think you should keep these changes on master. Last thing before I can merge: can you squash your commits as explained by @vicb? --------------------------------------------------------------------------- by travisbot at 2012-05-15T08:20:04Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1334337) (merged 525919fa into `ff7c4757`). --------------------------------------------------------------------------- by jocl at 2012-05-15T08:23:24Z I am sorry, of wasting your time... totally confused about using git. I feel a little bit squashed :-) of a the possible actions. I hope it is squashed now. And next time I will use the issue/ticket branch I made. --------------------------------------------------------------------------- by fabpot at 2012-05-15T08:35:59Z That's still not good. Squashing is explained here: http://symfony.com/doc/current/contributing/code/patches.html#rework-your-patch --------------------------------------------------------------------------- by travisbot at 2012-05-15T20:44:14Z This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1339390) (merged `d3fee9b2` into `03d4b026`).		2012-05-18 09:39:34 +02:00
src/Symfony	merged branch jocl/master (PR #4211 )	2012-05-18 09:39:34 +02:00
.gitignore	add composer to gitignore in 2.0	2012-05-10 16:15:45 +03:00
.travis.yml	removed 5.3.3 from Travis as it is not (yet) available	2012-05-08 08:42:40 +02:00
autoload.php.dist	[Propel1] Removed useless require in autoload.php.dist	2012-04-20 09:46:34 +02:00
CHANGELOG-2.0.md	updated CHANGELOG for 2.0.13	2012-04-30 15:30:03 +02:00
composer.json	[OptionsParser] Renamed OptionsParser to OptionsResolver	2012-05-14 19:35:07 +02:00
CONTRIBUTORS.md	update CONTRIBUTORS for 2.0.13	2012-04-30 15:30:38 +02:00
LICENSE	Updated LICENSE files copyright	2012-02-22 10:10:37 +01:00
phpunit.xml.dist	Set init.default_locale to 'en' in phpunit.xml.dist	2012-05-11 09:33:42 +02:00
README.md	updated minimum PHP version to 5.3.3	2012-05-07 10:29:11 +02:00
UPGRADE-2.1.md	[Form] Removed index_generation mention from the UPGRADE instructions as the option no longer exists.	2012-05-08 13:56:34 +01:00

README.md

README

What is Symfony2?

Symfony2 is a PHP 5.3 full-stack web framework. It is written with speed and flexibility in mind. It allows developers to build better and easy to maintain websites with PHP.

Symfony can be used to develop all kind of websites, from your personal blog to high traffic ones like Dailymotion or Yahoo! Answers.

Requirements

Symfony2 is only supported on PHP 5.3.3 and up.

Installation

The best way to install Symfony2 is to download the Symfony Standard Edition available at http://symfony.com/download.

Documentation

The "Quick Tour" tutorial gives you a first feeling of the framework. If, like us, you think that Symfony2 can help speed up your development and take the quality of your work to the next level, read the official Symfony2 documentation.

Contributing

Symfony2 is an open source, community-driven project. If you'd like to contribute, please read the Contributing Code part of the documentation. If you're submitting a pull request, please follow the guidelines in the Submitting a Patch section.