This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
symfony/src/Symfony
Fabien Potencier 81eb2f3423 feature #21190 [WebServerBundle] Decouple server commands from the container (chalasr)
This PR was merged into the 3.3-dev branch.

Discussion
----------

[WebServerBundle] Decouple server commands from the container

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20429
| License       | MIT
| Doc PR        | maybe

This removes the need for injecting the container in the new `server:*` commands, registering them as services when used in the framework and thus making them even more discoverable and extensible.
It would then be easy to reconsider extracting them in a `WebServer` component instead of having a bundle only. IMHO it would make sense to use these commands outside of the framework.

If the idea can be considered I'll add some tests at least ensuring that these commands are bootstrap-able. This must be done before that they are covered by the BC promise (3.3).

Commits
-------

2e63025e18 [WebServerBundle] Decouple server:* commands from the container
2017-01-07 16:40:55 -08:00
..
Bridge Merge branch '3.2' 2017-01-06 18:58:22 +01:00
Bundle feature #21190 [WebServerBundle] Decouple server commands from the container (chalasr) 2017-01-07 16:40:55 -08:00
Component minor #21192 [DI] Dont call get() when not required - µ-optim (nicolas-grekas) 2017-01-07 09:36:06 -08:00