This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Fabien Potencier 9572e9bd6e merged branch eriksencosta/issue-3841 (PR #4601) ... Commits ------- a609d55 [Locale] fixed StubIntlDateFormatter to behave like the ext/intl implementation Discussion ---------- [2.0][WIP][Locale] StubIntlDateFormatter should use the TZ environment variable instead of the PHP's date.timezone setting Bug fix: yes Feature addition: no Backwards compatibility break: yes Symfony2 tests pass: yes Fixes the following tickets: #3841 Todo: Check ext/intl changes for the next PHP 5.4 release License of the code: MIT  There were changes that need to be investigated for the next PHP 5.4 release: - [php-src @ eb346ef](eb346ef0f4) - [php-src @ 888e77f](888e77ff73) A strong evidence of bug in ext/intl was found while testing `StubIntlDateFormatter`. See the comment available at the docblock of `StubIntlDateFormatterTest`'s `testFormatWithDefaultTimezoneIntlShouldUseTheTzEnvironmentVariableWhenAvailable()` method and the following Gist for test scripts: https://gist.github.com/2946342 Maybe the upcoming PHP 5.4 release fix this bug since it will use the PHP's `date.timezone` when no time zone is provided. If confirmed the bug, it will need to be reported to the ext/intl maintainers. --------------------------------------------------------------------------- by travisbot at 2012-06-18T05:02:05Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1644431) (merged a609d55c into cd0aa378). --------------------------------------------------------------------------- by fabpot at 2012-06-28T14:09:08Z @eriksencosta Now that PHP 5.4.4 is out, our tests for the Locale components are broken. Is this PR ready to be merged? --------------------------------------------------------------------------- by eriksencosta at 2012-06-28T14:53:14Z @fabpot the failed test case seems unrelated to this issue. I will debug it. Failed test: `Locale\Tests\Stub\StubNumberFormatterTest::testParseTypeInt64IntlWith32BitIntegerInPhp32Bit` Recent build job: http://travis-ci.org/#!/symfony/symfony/jobs/1729618 I just need to confirm mine todo note. If you want, merge it, I'll track this and make a new PR if needed (possibly only to remove the TODO note.)		2012-06-28 16:57:13 +02:00
..
Bridge	fixed CS	2012-05-21 22:25:19 +02:00
Component	merged branch eriksencosta/issue-3841 (PR #4601)	2012-06-28 16:57:13 +02:00