diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
9672f4c98f
symfony/src/Symfony/Component
History
Nicolas Grekas 9672f4c98f bug #33244 [Router] Fix TraceableUrlMatcher behaviour with trailing slash (Xavier Leune) 
This PR was merged into the 3.4 branch.

Discussion
----------

[Router] Fix TraceableUrlMatcher behaviour with trailing slash

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #32149
| License       | MIT
| Doc PR        | ¤
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->
This pull requests fixes the bug #32149. This issue was about TraceableUrlMatcher having a wrong behaviour regarding trailing slashes (according to UrlMatcher and documentation).

With this pull requests, the test class TraceableUrlMatcherTest now extends UrlMatcherTest, to prevent such behaviour digression.

Thanks @nicolas-grekas for his feedback on the issue #32149

Commits
-------

fd1cb443fd [Router] Fix TraceableUrlMatcher behaviour with trailing slash
2019-08-20 15:36:35 +02:00
..
Asset Remove superfluous phpdoc tags 2019-08-14 13:59:53 +02:00
BrowserKit Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
Cache Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
ClassLoader Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
Config Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
Console Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
CssSelector Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
Debug Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
DependencyInjection minor #33252 Fix inconsistent return points (derrabus) 2019-08-20 15:34:30 +02:00
DomCrawler Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
Dotenv Remove superfluous phpdoc tags 2019-08-14 13:59:53 +02:00
EventDispatcher Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
ExpressionLanguage SCA: dropped unused mocks, duplicate import and a function alias usage 2019-08-07 09:23:44 +02:00
Filesystem Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
Finder cs fix 2019-08-14 11:39:58 +02:00
Form Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
HttpFoundation Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
HttpKernel Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
Inflector fixed short array CS in comments 2019-01-16 14:27:11 +01:00
Intl Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
Ldap Remove superfluous phpdoc tags 2019-08-14 13:59:53 +02:00
Lock Remove superfluous phpdoc tags 2019-08-14 13:59:53 +02:00
OptionsResolver Remove use of ForwardCompatTrait 2019-08-03 23:15:25 +02:00
Process Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
PropertyAccess Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
PropertyInfo Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
Routing bug #33244 [Router] Fix TraceableUrlMatcher behaviour with trailing slash (Xavier Leune) 2019-08-20 15:36:35 +02:00
Security minor #33257 [Security/Core] UserInterface::getPassword() can return null (nicolas-grekas) 2019-08-20 15:35:21 +02:00
Serializer Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
Stopwatch Fix remaining tests 2019-08-06 15:24:37 +02:00
Templating Remove use of ForwardCompatTrait 2019-08-03 23:15:25 +02:00
Translation Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
Validator Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
VarDumper Fix inconsistent return points. 2019-08-20 15:31:17 +02:00
WebLink Remove use of ForwardCompatTrait 2019-08-03 23:15:25 +02:00
Workflow Fix some docblocks. 2019-08-16 02:50:45 +02:00
Yaml Fix inconsistent return points. 2019-08-20 15:31:17 +02:00