This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
symfony/src/Symfony/Component
Fabien Potencier 9784301b1f minor #19608 [DependencyInjection] ContainerBuilder: Remove obsolete definitions (ogizanagi)
This PR was merged into the 3.1 branch.

Discussion
----------

[DependencyInjection] ContainerBuilder: Remove obsolete definitions

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | yes
| New feature?  |no
| BC breaks?    | may be considered
| Deprecations? | may be considered
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

IIUC, [the obsolete definitions thing was tied to scoped & sync services](https://github.com/symfony/symfony/pull/7007).
Thus, this code [is not meant to be used since 3.0 and can be removed](https://github.com/symfony/symfony/pull/13289).

However, it may be considered as a BC break and would require introducing a new deprecation instead, because the current code allows to set a service on a frozen container if it has an obsolete synthetic definition...which is weird, isn't it ? (I doubt this feature was explicitly intended to allow setting a synthetic service more than once, and it wasn't before sync services introduction)

I suggest this as a patch for 3.1, under the pretext of forgotten code tied to a previous deprecation & feature removal, but let me know if it should be considered differently.

Commits
-------

daa7d00 [DependencyInjection] ContainerBuilder: Remove obsolete definitions
2016-08-15 16:00:31 -07:00
..
Asset Merge branch '3.0' into 3.1 2016-07-01 18:00:00 +02:00
BrowserKit Merge branch '3.0' into 3.1 2016-07-26 10:04:17 +02:00
Cache [Cache] Handle unserialize() failures gracefully 2016-08-10 19:24:03 +02:00
ClassLoader Merge branch '3.0' into 3.1 2016-07-10 10:05:47 +02:00
Config Merge branch '2.8' into 3.1 2016-08-10 08:57:07 +02:00
Console Merge branch '2.8' into 3.1 2016-08-10 08:57:07 +02:00
CssSelector Merge branch '3.0' into 3.1 2016-06-29 07:41:56 +02:00
Debug Merge branch '2.8' into 3.1 2016-08-05 10:37:39 +02:00
DependencyInjection [DependencyInjection] ContainerBuilder: Remove obsolete definitions 2016-08-14 11:06:18 +02:00
DomCrawler Merge branch '2.8' into 3.1 2016-08-05 10:37:39 +02:00
EventDispatcher bug #19564 Added class existence check if is_subclass_of() fails in compiler passes (SCIF) 2016-08-09 11:00:18 +02:00
ExpressionLanguage Merge branch '3.0' 2016-03-10 12:16:56 +01:00
Filesystem Merge branch '3.0' into 3.1 2016-07-20 08:44:26 +03:00
Finder Merge branch '2.7' into 2.8 2016-07-26 10:02:44 +02:00
Form Merge branch '2.7' into 2.8 2016-07-30 03:20:35 -04:00
HttpFoundation Merge branch '2.7' into 2.8 2016-07-30 03:20:35 -04:00
HttpKernel bug #19564 Added class existence check if is_subclass_of() fails in compiler passes (SCIF) 2016-08-09 11:00:18 +02:00
Inflector Fixed singular of committee 2016-06-08 13:24:07 +02:00
Intl Merge branch '2.8' into 3.1 2016-08-10 08:57:07 +02:00
Ldap Reference the actual location of the documentation 2016-07-26 17:33:44 +02:00
OptionsResolver Merge branch '2.7' into 2.8 2016-06-29 07:29:29 +02:00
Process Merge branch '2.8' into 3.1 2016-08-07 17:17:34 +02:00
PropertyAccess Merge branch '2.8' into 3.1 2016-08-05 10:37:39 +02:00
PropertyInfo Fix merge 2016-07-20 08:55:49 +03:00
Routing Merge branch '2.8' into 3.1 2016-08-07 17:17:34 +02:00
Security Minor fixes 2016-07-30 03:17:26 -04:00
Serializer [Serializer] Include the format in the cache key 2016-07-13 10:40:09 +02:00
Stopwatch Merge branch '3.0' into 3.1 2016-06-29 07:41:56 +02:00
Templating Merge branch '2.8' into 3.1 2016-08-05 10:37:39 +02:00
Translation Merge branch '2.8' into 3.1 2016-08-05 10:37:39 +02:00
Validator Merge branch '2.8' into 3.1 2016-08-07 17:17:34 +02:00
VarDumper Merge branch '2.8' into 3.1 2016-08-05 10:37:39 +02:00
Yaml Improved deprecation message 2016-08-05 11:04:52 +02:00