This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
symfony/src/Symfony/Component/Validator
Fabien Potencier 0807ff77d0 minor #17903 Validate XLIFF translation files (javiereguiluz)
This PR was squashed before being merged into the 2.3 branch (closes #17903).

Discussion
----------

Validate XLIFF translation files

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

In #17902 @stof proposed to add a simple test to validate `.xlf` files (to avoid issues like #17893).

This is a proposal for that test. My questions:

**1)** Do you agree displaying detailed error messages when the XML is not valid. Example output for the #17893 error:

![error_log](https://cloud.githubusercontent.com/assets/73419/13250664/932d2f14-da2b-11e5-8ea0-ecb43f58feea.png)

Or is it enough displaying just the PHPUnit error message and let the user figure out the details?

![simple_error](https://cloud.githubusercontent.com/assets/73419/13250671/a3b4bfd2-da2b-11e5-9277-454d0dd160b2.png)

**2)** How do I validate the translation files of the Security and Form components? Do I just copy+paste this test in those components?

Commits
-------

db03055 Validate XLIFF translation files
2016-02-23 19:12:36 +01:00
..
Constraints [Validator] Allow an empty path with a non empty fragment or a query 2015-11-13 07:29:58 +00:00
Exception [Validator]Fixed getting wrong msg when value is an object in UnexpectedTypeException 2013-12-07 14:24:25 +00:00
Mapping [2.3] Static Code Analysis for Components 2016-01-12 12:31:34 +01:00
Resources/translations Fixed a minor XML issue in a translation file 2016-02-23 11:57:32 +01:00
Tests Validate XLIFF translation files 2016-02-23 19:12:35 +01:00
.gitignore Added missing files .gitignore 2013-07-21 14:12:18 +02:00
CHANGELOG.md Fixed compatibility with PHP7 and up by introducing new constraints (IsNull, IsTrue, IsFalse) and related validators (IsNullValidator, IsTrueValidator, IsFalseValidator) 2015-05-13 11:33:22 +02:00
ClassBasedInterface.php [Validator] Refactored the GraphWalker into an implementation of the Visitor design pattern. 2012-11-24 13:00:28 +01:00
composer.json added the new Composer exclude-from-classmap option 2015-10-30 12:48:51 -07:00
Constraint.php remove api tags from code 2015-09-28 19:11:22 +02:00
ConstraintValidator.php remove api tags from code 2015-09-28 19:11:22 +02:00
ConstraintValidatorFactory.php made {@inheritdoc} annotations consistent across the board 2014-04-16 09:04:20 +02:00
ConstraintValidatorFactoryInterface.php removed unneeded use statements 2014-01-01 08:52:14 +01:00
ConstraintValidatorInterface.php remove api tags from code 2015-09-28 19:11:22 +02:00
ConstraintViolation.php Docblock fixes 2014-11-30 13:33:44 +00:00
ConstraintViolationInterface.php remove api tags from code 2015-09-28 19:11:22 +02:00
ConstraintViolationList.php made {@inheritdoc} annotations consistent across the board 2014-04-16 09:04:20 +02:00
ConstraintViolationListInterface.php remove api tags from code 2015-09-28 19:11:22 +02:00
DefaultTranslator.php [2.3] Fix @link annotations 2015-04-10 20:54:05 +02:00
ExecutionContext.php unified return null usages 2014-04-16 09:43:51 +02:00
ExecutionContextInterface.php remove api tags from code 2015-09-28 19:11:22 +02:00
GlobalExecutionContextInterface.php Fixes various phpdoc and coding standards. 2015-01-02 09:58:20 +01:00
GroupSequenceProviderInterface.php fixed CS 2012-07-09 14:54:20 +02:00
LICENSE Update copyright year 2016-01-01 23:53:47 -03:00
MetadataFactoryInterface.php Docblock fixes 2014-11-30 13:33:44 +00:00
MetadataInterface.php [Validator] Refactored the GraphWalker into an implementation of the Visitor design pattern. 2012-11-24 13:00:28 +01:00
ObjectInitializerInterface.php remove api tags from code 2015-09-28 19:11:22 +02:00
phpunit.xml.dist Add missing exclusions from phpunit.xml.dist 2015-11-18 09:19:46 +01:00
PropertyMetadataContainerInterface.php fixed types in phpdocs 2014-04-16 12:30:19 +02:00
PropertyMetadataInterface.php [Validator] Refactored the GraphWalker into an implementation of the Visitor design pattern. 2012-11-24 13:00:28 +01:00
README.md use new repo location in some readme.md 2015-09-03 22:55:07 +02:00
Validation.php [Form] [Validator] Fixed issues mentioned in the PR 2012-07-30 16:22:02 +02:00
ValidationVisitor.php [Validator] Backported #11410 to 2.3: Object initializers are called only once per object 2014-07-18 10:20:25 +02:00
ValidationVisitorInterface.php Docblock fixes 2014-11-30 13:33:44 +00:00
Validator.php fixed CS 2014-09-22 10:32:35 +02:00
ValidatorBuilder.php [Validator] removed deprecated methods 2013-03-23 11:48:19 +01:00
ValidatorBuilderInterface.php [Validator] removed deprecated methods 2013-03-23 11:48:19 +01:00
ValidatorInterface.php remove api tags from code 2015-09-28 19:11:22 +02:00

Validator Component

This component is based on the JSR-303 Bean Validation specification and enables specifying validation rules for classes using XML, YAML, PHP or annotations, which can then be checked against instances of these classes.

Usage

The component provides "validation constraints", which are simple objects containing the rules for the validation. Let's validate a simple string as an example:

use Symfony\Component\Validator\Validation;
use Symfony\Component\Validator\Constraints\Length;

$validator = Validation::createValidator();

$violations = $validator->validateValue('Bernhard', new Length(array('min' => 10)));

This validation will fail because the given string is shorter than ten characters. The precise errors, here called "constraint violations", are returned by the validator. You can analyze these or return them to the user. If the violation list is empty, validation succeeded.

Validation of arrays is possible using the Collection constraint:

use Symfony\Component\Validator\Validation;
use Symfony\Component\Validator\Constraints as Assert;

$validator = Validation::createValidator();

$constraint = new Assert\Collection(array(
    'name' => new Assert\Collection(array(
        'first_name' => new Assert\Length(array('min' => 101)),
        'last_name' => new Assert\Length(array('min' => 1)),
    )),
    'email' => new Assert\Email(),
    'simple' => new Assert\Length(array('min' => 102)),
    'gender' => new Assert\Choice(array(3, 4)),
    'file' => new Assert\File(),
    'password' => new Assert\Length(array('min' => 60)),
));

$violations = $validator->validateValue($input, $constraint);

Again, the validator returns the list of violations.

Validation of objects is possible using "constraint mapping". With such a mapping you can put constraints onto properties and objects of classes. Whenever an object of this class is validated, its properties and method results are matched against the constraints.

use Symfony\Component\Validator\Validation;
use Symfony\Component\Validator\Constraints as Assert;

class User
{
    /**
     * @Assert\Length(min = 3)
     * @Assert\NotBlank
     */
    private $name;

    /**
     * @Assert\Email
     * @Assert\NotBlank
     */
    private $email;

    public function __construct($name, $email)
    {
        $this->name = $name;
        $this->email = $email;
    }

    /**
     * @Assert\True(message = "The user should have a Google Mail account")
     */
    public function isGmailUser()
    {
        return false !== strpos($this->email, '@gmail.com');
    }
}

$validator = Validation::createValidatorBuilder()
    ->enableAnnotationMapping()
    ->getValidator();

$user = new User('John Doe', 'john@example.com');

$violations = $validator->validate($user);

This example uses the annotation support of Doctrine Common to map constraints to properties and methods. You can also map constraints using XML, YAML or plain PHP, if you dislike annotations or don't want to include Doctrine. Check the documentation for more information about these drivers.

Resources

Silex integration:

https://github.com/silexphp/Silex/blob/master/src/Silex/Provider/ValidatorServiceProvider.php

Documentation:

https://symfony.com/doc/2.3/book/validation.html

JSR-303 Specification:

http://jcp.org/en/jsr/detail?id=303

You can run the unit tests with the following command:

$ cd path/to/Symfony/Component/Validator/
$ composer install
$ phpunit