b4dcd500dd
This PR was merged into the 2.6-dev branch.
Discussion
----------
[Form] Choice children can be template customized like collection
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | yes?
| Deprecations? | no
| Tests pass? | No ?
| Fixed tickets |
| License | MIT
| Doc PR | None
I wanted to customize the template of a children of a choice field. I learned it was not currently possible, though it is with the collection type. So this should let people be able to customize the template for all the choice children at once.
Ie:
```jinja
{% block _user_colors_entry_widget %}
```
Still have to fix the tests
Commits
-------
4e6b27f [Form] Choice children can be template customized like collection
537 lines
15 KiB
PHP
537 lines
15 KiB
PHP
<?php
|
|
|
|
/*
|
|
* This file is part of the Symfony package.
|
|
*
|
|
* (c) Fabien Potencier <fabien@symfony.com>
|
|
*
|
|
* For the full copyright and license information, please view the LICENSE
|
|
* file that was distributed with this source code.
|
|
*/
|
|
|
|
namespace Symfony\Component\Form\Tests;
|
|
|
|
use Symfony\Component\Form\FormError;
|
|
use Symfony\Component\Security\Csrf\CsrfToken;
|
|
|
|
abstract class AbstractTableLayoutTest extends AbstractLayoutTest
|
|
{
|
|
public function testRow()
|
|
{
|
|
$form = $this->factory->createNamed('name', 'text');
|
|
$form->addError(new FormError('[trans]Error![/trans]'));
|
|
$view = $form->createView();
|
|
$html = $this->renderRow($view);
|
|
|
|
$this->assertMatchesXpath($html,
|
|
'/tr
|
|
[
|
|
./td
|
|
[./label[@for="name"]]
|
|
/following-sibling::td
|
|
[
|
|
./ul
|
|
[./li[.="[trans]Error![/trans]"]]
|
|
[count(./li)=1]
|
|
/following-sibling::input[@id="name"]
|
|
]
|
|
]
|
|
'
|
|
);
|
|
}
|
|
|
|
public function testLabelIsNotRenderedWhenSetToFalse()
|
|
{
|
|
$form = $this->factory->createNamed('name', 'text', null, array(
|
|
'label' => false,
|
|
));
|
|
$html = $this->renderRow($form->createView());
|
|
|
|
$this->assertMatchesXpath($html,
|
|
'/tr
|
|
[
|
|
./td
|
|
[count(//label)=0]
|
|
/following-sibling::td
|
|
[./input[@id="name"]]
|
|
]
|
|
'
|
|
);
|
|
}
|
|
|
|
public function testRepeatedRow()
|
|
{
|
|
$form = $this->factory->createNamed('name', 'repeated');
|
|
$html = $this->renderRow($form->createView());
|
|
|
|
$this->assertMatchesXpath($html,
|
|
'/tr
|
|
[
|
|
./td
|
|
[./label[@for="name_first"]]
|
|
/following-sibling::td
|
|
[./input[@id="name_first"]]
|
|
]
|
|
/following-sibling::tr
|
|
[
|
|
./td
|
|
[./label[@for="name_second"]]
|
|
/following-sibling::td
|
|
[./input[@id="name_second"]]
|
|
]
|
|
/following-sibling::tr[@style="display: none"]
|
|
[./td[@colspan="2"]/input
|
|
[@type="hidden"]
|
|
[@id="name__token"]
|
|
]
|
|
[count(../tr)=3]
|
|
'
|
|
);
|
|
}
|
|
|
|
public function testRepeatedRowWithErrors()
|
|
{
|
|
$form = $this->factory->createNamed('name', 'repeated');
|
|
$form->addError(new FormError('[trans]Error![/trans]'));
|
|
$view = $form->createView();
|
|
$html = $this->renderRow($view);
|
|
|
|
// The errors of the form are not rendered by intention!
|
|
// In practice, repeated fields cannot have errors as all errors
|
|
// on them are mapped to the first child.
|
|
// (see RepeatedTypeValidatorExtension)
|
|
|
|
$this->assertMatchesXpath($html,
|
|
'/tr
|
|
[
|
|
./td
|
|
[./label[@for="name_first"]]
|
|
/following-sibling::td
|
|
[./input[@id="name_first"]]
|
|
]
|
|
/following-sibling::tr
|
|
[
|
|
./td
|
|
[./label[@for="name_second"]]
|
|
/following-sibling::td
|
|
[./input[@id="name_second"]]
|
|
]
|
|
/following-sibling::tr[@style="display: none"]
|
|
[./td[@colspan="2"]/input
|
|
[@type="hidden"]
|
|
[@id="name__token"]
|
|
]
|
|
[count(../tr)=3]
|
|
'
|
|
);
|
|
}
|
|
|
|
public function testButtonRow()
|
|
{
|
|
$form = $this->factory->createNamed('name', 'button');
|
|
$view = $form->createView();
|
|
$html = $this->renderRow($view);
|
|
|
|
$this->assertMatchesXpath($html,
|
|
'/tr
|
|
[
|
|
./td
|
|
[.=""]
|
|
/following-sibling::td
|
|
[./button[@type="button"][@name="name"]]
|
|
]
|
|
[count(//label)=0]
|
|
'
|
|
);
|
|
}
|
|
|
|
public function testRest()
|
|
{
|
|
$view = $this->factory->createNamedBuilder('name', 'form')
|
|
->add('field1', 'text')
|
|
->add('field2', 'repeated')
|
|
->add('field3', 'text')
|
|
->add('field4', 'text')
|
|
->getForm()
|
|
->createView();
|
|
|
|
// Render field2 row -> does not implicitly call renderWidget because
|
|
// it is a repeated field!
|
|
$this->renderRow($view['field2']);
|
|
|
|
// Render field3 widget
|
|
$this->renderWidget($view['field3']);
|
|
|
|
// Rest should only contain field1 and field4
|
|
$html = $this->renderRest($view);
|
|
|
|
$this->assertMatchesXpath($html,
|
|
'/tr
|
|
[
|
|
./td
|
|
[./label[@for="name_field1"]]
|
|
/following-sibling::td
|
|
[./input[@id="name_field1"]]
|
|
]
|
|
/following-sibling::tr
|
|
[
|
|
./td
|
|
[./label[@for="name_field4"]]
|
|
/following-sibling::td
|
|
[./input[@id="name_field4"]]
|
|
]
|
|
[count(../tr)=3]
|
|
[count(..//label)=2]
|
|
[count(..//input)=3]
|
|
/following-sibling::tr[@style="display: none"]
|
|
[./td[@colspan="2"]/input
|
|
[@type="hidden"]
|
|
[@id="name__token"]
|
|
]
|
|
'
|
|
);
|
|
}
|
|
|
|
public function testCollection()
|
|
{
|
|
$form = $this->factory->createNamed('names', 'collection', array('a', 'b'), array(
|
|
'type' => 'text',
|
|
));
|
|
|
|
$this->assertWidgetMatchesXpath($form->createView(), array(),
|
|
'/table
|
|
[
|
|
./tr[./td/input[@type="text"][@value="a"]]
|
|
/following-sibling::tr[./td/input[@type="text"][@value="b"]]
|
|
/following-sibling::tr[@style="display: none"][./td[@colspan="2"]/input[@type="hidden"][@id="names__token"]]
|
|
]
|
|
[count(./tr[./td/input])=3]
|
|
'
|
|
);
|
|
}
|
|
|
|
public function testEmptyCollection()
|
|
{
|
|
$form = $this->factory->createNamed('names', 'collection', array(), array(
|
|
'type' => 'text',
|
|
));
|
|
|
|
$this->assertWidgetMatchesXpath($form->createView(), array(),
|
|
'/table
|
|
[./tr[@style="display: none"][./td[@colspan="2"]/input[@type="hidden"][@id="names__token"]]]
|
|
[count(./tr[./td/input])=1]
|
|
'
|
|
);
|
|
}
|
|
|
|
public function testForm()
|
|
{
|
|
$view = $this->factory->createNamedBuilder('name', 'form')
|
|
->setMethod('PUT')
|
|
->setAction('http://example.com')
|
|
->add('firstName', 'text')
|
|
->add('lastName', 'text')
|
|
->getForm()
|
|
->createView();
|
|
|
|
$html = $this->renderForm($view, array(
|
|
'id' => 'my&id',
|
|
'attr' => array('class' => 'my&class'),
|
|
));
|
|
|
|
$this->assertMatchesXpath($html,
|
|
'/form
|
|
[
|
|
./input[@type="hidden"][@name="_method"][@value="PUT"]
|
|
/following-sibling::table
|
|
[
|
|
./tr
|
|
[
|
|
./td
|
|
[./label[@for="name_firstName"]]
|
|
/following-sibling::td
|
|
[./input[@id="name_firstName"]]
|
|
]
|
|
/following-sibling::tr
|
|
[
|
|
./td
|
|
[./label[@for="name_lastName"]]
|
|
/following-sibling::td
|
|
[./input[@id="name_lastName"]]
|
|
]
|
|
/following-sibling::tr[@style="display: none"]
|
|
[./td[@colspan="2"]/input
|
|
[@type="hidden"]
|
|
[@id="name__token"]
|
|
]
|
|
]
|
|
[count(.//input)=3]
|
|
[@id="my&id"]
|
|
[@class="my&class"]
|
|
]
|
|
[@method="post"]
|
|
[@action="http://example.com"]
|
|
[@class="my&class"]
|
|
'
|
|
);
|
|
}
|
|
|
|
public function testFormWidget()
|
|
{
|
|
$view = $this->factory->createNamedBuilder('name', 'form')
|
|
->add('firstName', 'text')
|
|
->add('lastName', 'text')
|
|
->getForm()
|
|
->createView();
|
|
|
|
$this->assertWidgetMatchesXpath($view, array(),
|
|
'/table
|
|
[
|
|
./tr
|
|
[
|
|
./td
|
|
[./label[@for="name_firstName"]]
|
|
/following-sibling::td
|
|
[./input[@id="name_firstName"]]
|
|
]
|
|
/following-sibling::tr
|
|
[
|
|
./td
|
|
[./label[@for="name_lastName"]]
|
|
/following-sibling::td
|
|
[./input[@id="name_lastName"]]
|
|
]
|
|
/following-sibling::tr[@style="display: none"]
|
|
[./td[@colspan="2"]/input
|
|
[@type="hidden"]
|
|
[@id="name__token"]
|
|
]
|
|
]
|
|
[count(.//input)=3]
|
|
'
|
|
);
|
|
}
|
|
|
|
// https://github.com/symfony/symfony/issues/2308
|
|
public function testNestedFormError()
|
|
{
|
|
$form = $this->factory->createNamedBuilder('name', 'form')
|
|
->add($this->factory
|
|
->createNamedBuilder('child', 'form', null, array('error_bubbling' => false))
|
|
->add('grandChild', 'form')
|
|
)
|
|
->getForm();
|
|
|
|
$form->get('child')->addError(new FormError('[trans]Error![/trans]'));
|
|
|
|
$this->assertWidgetMatchesXpath($form->createView(), array(),
|
|
'/table
|
|
[
|
|
./tr/td/ul[./li[.="[trans]Error![/trans]"]]
|
|
/following-sibling::table[@id="name_child"]
|
|
]
|
|
[count(.//li[.="[trans]Error![/trans]"])=1]
|
|
'
|
|
);
|
|
}
|
|
|
|
public function testCsrf()
|
|
{
|
|
$this->csrfTokenManager->expects($this->any())
|
|
->method('getToken')
|
|
->will($this->returnValue(new CsrfToken('token_id', 'foo&bar')));
|
|
|
|
$form = $this->factory->createNamedBuilder('name', 'form')
|
|
->add($this->factory
|
|
// No CSRF protection on nested forms
|
|
->createNamedBuilder('child', 'form')
|
|
->add($this->factory->createNamedBuilder('grandchild', 'text'))
|
|
)
|
|
->getForm();
|
|
|
|
$this->assertWidgetMatchesXpath($form->createView(), array(),
|
|
'/table
|
|
[
|
|
./tr[@style="display: none"]
|
|
[./td[@colspan="2"]/input
|
|
[@type="hidden"]
|
|
[@id="name__token"]
|
|
]
|
|
]
|
|
[count(.//input[@type="hidden"])=1]
|
|
'
|
|
);
|
|
}
|
|
|
|
public function testRepeated()
|
|
{
|
|
$form = $this->factory->createNamed('name', 'repeated', 'foobar', array(
|
|
'type' => 'text',
|
|
));
|
|
|
|
$this->assertWidgetMatchesXpath($form->createView(), array(),
|
|
'/table
|
|
[
|
|
./tr
|
|
[
|
|
./td
|
|
[./label[@for="name_first"]]
|
|
/following-sibling::td
|
|
[./input[@type="text"][@id="name_first"]]
|
|
]
|
|
/following-sibling::tr
|
|
[
|
|
./td
|
|
[./label[@for="name_second"]]
|
|
/following-sibling::td
|
|
[./input[@type="text"][@id="name_second"]]
|
|
]
|
|
/following-sibling::tr[@style="display: none"]
|
|
[./td[@colspan="2"]/input
|
|
[@type="hidden"]
|
|
[@id="name__token"]
|
|
]
|
|
]
|
|
[count(.//input)=3]
|
|
'
|
|
);
|
|
}
|
|
|
|
public function testRepeatedWithCustomOptions()
|
|
{
|
|
$form = $this->factory->createNamed('name', 'repeated', 'foobar', array(
|
|
'type' => 'password',
|
|
'first_options' => array('label' => 'Test', 'required' => false),
|
|
'second_options' => array('label' => 'Test2'),
|
|
));
|
|
|
|
$this->assertWidgetMatchesXpath($form->createView(), array(),
|
|
'/table
|
|
[
|
|
./tr
|
|
[
|
|
./td
|
|
[./label[@for="name_first"][.="[trans]Test[/trans]"]]
|
|
/following-sibling::td
|
|
[./input[@type="password"][@id="name_first"][@required="required"]]
|
|
]
|
|
/following-sibling::tr
|
|
[
|
|
./td
|
|
[./label[@for="name_second"][.="[trans]Test2[/trans]"]]
|
|
/following-sibling::td
|
|
[./input[@type="password"][@id="name_second"][@required="required"]]
|
|
]
|
|
/following-sibling::tr[@style="display: none"]
|
|
[./td[@colspan="2"]/input
|
|
[@type="hidden"]
|
|
[@id="name__token"]
|
|
]
|
|
]
|
|
[count(.//input)=3]
|
|
'
|
|
);
|
|
}
|
|
|
|
/**
|
|
* The block "_name_child_label" should be overridden in the theme of the
|
|
* implemented driver.
|
|
*/
|
|
public function testCollectionRowWithCustomBlock()
|
|
{
|
|
$collection = array('one', 'two', 'three');
|
|
$form = $this->factory->createNamedBuilder('names', 'collection', $collection)
|
|
->getForm();
|
|
|
|
$this->assertWidgetMatchesXpath($form->createView(), array(),
|
|
'/table
|
|
[
|
|
./tr[./td/label[.="Custom label: [trans]0[/trans]"]]
|
|
/following-sibling::tr[./td/label[.="Custom label: [trans]1[/trans]"]]
|
|
/following-sibling::tr[./td/label[.="Custom label: [trans]2[/trans]"]]
|
|
]
|
|
'
|
|
);
|
|
}
|
|
|
|
public function testFormEndWithRest()
|
|
{
|
|
$view = $this->factory->createNamedBuilder('name', 'form')
|
|
->add('field1', 'text')
|
|
->add('field2', 'text')
|
|
->getForm()
|
|
->createView();
|
|
|
|
$this->renderWidget($view['field1']);
|
|
|
|
// Rest should only contain field2
|
|
$html = $this->renderEnd($view);
|
|
|
|
// Insert the start tag, the end tag should be rendered by the helper
|
|
// Unfortunately this is not valid HTML, because the surrounding table
|
|
// tag is missing. If someone renders a form with table layout
|
|
// manually, she should call form_rest() explicitly within the <table>
|
|
// tag.
|
|
$this->assertMatchesXpath('<form>'.$html,
|
|
'/form
|
|
[
|
|
./tr
|
|
[
|
|
./td
|
|
[./label[@for="name_field2"]]
|
|
/following-sibling::td
|
|
[./input[@id="name_field2"]]
|
|
]
|
|
/following-sibling::tr[@style="display: none"]
|
|
[./td[@colspan="2"]/input
|
|
[@type="hidden"]
|
|
[@id="name__token"]
|
|
]
|
|
]
|
|
'
|
|
);
|
|
}
|
|
|
|
public function testFormEndWithoutRest()
|
|
{
|
|
$view = $this->factory->createNamedBuilder('name', 'form')
|
|
->add('field1', 'text')
|
|
->add('field2', 'text')
|
|
->getForm()
|
|
->createView();
|
|
|
|
$this->renderWidget($view['field1']);
|
|
|
|
// Rest should only contain field2, but isn't rendered
|
|
$html = $this->renderEnd($view, array('render_rest' => false));
|
|
|
|
$this->assertEquals('</form>', $html);
|
|
}
|
|
|
|
public function testWidgetContainerAttributes()
|
|
{
|
|
$form = $this->factory->createNamed('form', 'form', null, array(
|
|
'attr' => array('class' => 'foobar', 'data-foo' => 'bar'),
|
|
));
|
|
|
|
$form->add('text', 'text');
|
|
|
|
$html = $this->renderWidget($form->createView());
|
|
|
|
// compare plain HTML to check the whitespace
|
|
$this->assertContains('<table id="form" class="foobar" data-foo="bar">', $html);
|
|
}
|
|
|
|
public function testWidgetContainerAttributeNameRepeatedIfTrue()
|
|
{
|
|
$form = $this->factory->createNamed('form', 'form', null, array(
|
|
'attr' => array('foo' => true),
|
|
));
|
|
|
|
$html = $this->renderWidget($form->createView());
|
|
|
|
// foo="foo"
|
|
$this->assertContains('<table id="form" foo="foo">', $html);
|
|
}
|
|
}
|