65e254c2fe
This PR was merged into the 3.2-dev branch.
Discussion
----------
[HttpFoundation] Deprecate extending some methods
| Q | A
| ------------- | ---
| Branch? | "master"
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | yes
| Tests pass? | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/19727
| License | MIT
| Doc PR |
It's really hard to change methods signature because of bc. I'm proposing to deprecate extending some getters/setters of `Response` because of this (and because extending them is not really useful).
If you like this approach it could be used in other places to simplify bc in 4.0.
Edit: This causes issues (warnings always triggered) when mocking `Response` entirely but does it matter as people should only mock needed methods?
Commits
-------
|
||
---|---|---|
.. | ||
Exception | ||
File | ||
Session | ||
Tests | ||
.gitignore | ||
AcceptHeader.php | ||
AcceptHeaderItem.php | ||
ApacheRequest.php | ||
BinaryFileResponse.php | ||
CHANGELOG.md | ||
composer.json | ||
Cookie.php | ||
ExpressionRequestMatcher.php | ||
FileBag.php | ||
HeaderBag.php | ||
IpUtils.php | ||
JsonResponse.php | ||
LICENSE | ||
ParameterBag.php | ||
phpunit.xml.dist | ||
README.md | ||
RedirectResponse.php | ||
Request.php | ||
RequestMatcher.php | ||
RequestMatcherInterface.php | ||
RequestStack.php | ||
Response.php | ||
ResponseHeaderBag.php | ||
ServerBag.php | ||
StreamedResponse.php |
HttpFoundation Component
The HttpFoundation component defines an object-oriented layer for the HTTP specification.