This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
symfony/src/Symfony/Component/HttpFoundation
Fabien Potencier 65e254c2fe feature #19734 [HttpFoundation] Deprecate extending some methods (Ener-Getick)
This PR was merged into the 3.2-dev branch.

Discussion
----------

[HttpFoundation] Deprecate extending some methods

| Q             | A
| ------------- | ---
| Branch?       | "master"
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/19727
| License       | MIT
| Doc PR        |

It's really hard to change methods signature because of bc. I'm proposing to deprecate extending some getters/setters of `Response` because of this (and because extending them is not really useful).
If you like this approach it could be used in other places to simplify bc in 4.0.

Edit: This causes issues (warnings always triggered) when mocking `Response` entirely but does it matter as people should only mock needed methods?

Commits
-------

c0a26bc [HttpFoundation] Deprecate extending some methods
2016-09-14 13:47:40 -07:00
..
Exception [HttpFoundation] Warning when request has both Forwarded and X-Forwarded-For 2016-06-29 09:01:55 +02:00
File removed dots at the end of @param and @return 2016-06-28 08:24:06 +02:00
Session Merge branch '2.8' into 3.1 2016-09-06 13:02:40 +02:00
Tests [HttpFoundation] Deprecate extending some methods 2016-09-14 12:52:06 +02:00
.gitignore Added missing files .gitignore 2013-07-21 14:12:18 +02:00
AcceptHeader.php [2.3] CS And DocBlock Fixes 2014-12-22 16:58:09 +01:00
AcceptHeaderItem.php fixed types in phpdocs 2014-04-16 12:30:19 +02:00
ApacheRequest.php [HttpFoundation] do not use server variable PATH_INFO because it is already decoded and thus symfony is fragile to double encoding of the path 2013-04-12 17:03:10 +02:00
BinaryFileResponse.php Merge branch '2.3' into 2.7 2016-03-10 20:23:56 +01:00
CHANGELOG.md Add a Controller function to make it easy to return json 2016-03-02 16:31:41 +02:00
composer.json updated version to 3.2 2016-05-13 13:13:23 -05:00
Cookie.php fixed CS 2016-06-23 15:33:17 +02:00
ExpressionRequestMatcher.php [HttpFoundation] added ExpressionRequestMatcher 2013-09-19 12:59:11 +02:00
FileBag.php remove api tags from code 2015-09-28 19:11:22 +02:00
HeaderBag.php Merge branch '2.3' into 2.7 2016-01-12 18:44:11 +01:00
IpUtils.php Verify explicitly that the request IP is a valid IPv4 address 2016-08-19 08:01:16 -07:00
JsonResponse.php Merge branch '3.1' 2016-09-06 13:07:23 +02:00
LICENSE Update copyright year 2016-01-01 23:53:47 -03:00
ParameterBag.php Merge branch '2.8' into 3.0 2016-06-29 07:40:00 +02:00
phpunit.xml.dist Add missing exclusions from phpunit.xml.dist 2015-11-18 09:19:46 +01:00
README.md Updated all the README files 2016-03-04 08:12:06 +01:00
RedirectResponse.php Merge branch '3.1' 2016-06-29 07:43:10 +02:00
Request.php Merge branch '3.1' 2016-08-16 18:09:30 +02:00
RequestMatcher.php Merge branch '2.3' into 2.7 2015-09-29 14:06:14 +02:00
RequestMatcherInterface.php remove api tags from code 2015-09-28 19:11:22 +02:00
RequestStack.php unified return null usages 2014-04-18 22:38:54 +02:00
Response.php [HttpFoundation] Deprecate extending some methods 2016-09-14 12:52:06 +02:00
ResponseHeaderBag.php Merge branch '3.1' 2016-06-29 07:43:10 +02:00
ServerBag.php [HttpFoundation] Do not overwrite the Authorization header if it is already set 2016-01-22 07:46:45 +01:00
StreamedResponse.php Add more callable type hints 2015-10-05 18:52:37 +02:00

HttpFoundation Component

The HttpFoundation component defines an object-oriented layer for the HTTP specification.

Resources