This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Fabien Potencier b3da94d0e3 merged branch Seldaek/router_def (PR #3437) ... Commits ------- 09b1bd5 [HttpKernel] Remove the _controller since it is not a route parameter part of the url Discussion ---------- [HttpKernel] Remove the _controller since it is not a route parameter part of the URL There is no reason for the _controller to be there, the whole idea behind this _route_params thing was to help re-generating the current page's URL, you can easily grab the _route + _route_params and reconstruct it without having lots of garbage as query parameters like `?_controller=Foo::..` --------------------------------------------------------------------------- by fabpot at 2012-02-24T10:29:01Z I agree but isn't it a BC break? I mean, someone may rely on `_controller` in his code. --------------------------------------------------------------------------- by Seldaek at 2012-02-24T11:45:46Z This is a new 2.1 feature AFAIK so no it's not breaking anything. If _controller is deemed necessary then we should add it on the attributes, but not in the _route_params IMO. --------------------------------------------------------------------------- by stof at 2012-02-24T13:32:41Z indeed, ``_route_params`` is new in 2.1		2012-02-27 10:03:33 +01:00
..
Symfony	merged branch Seldaek/router_def (PR #3437)	2012-02-27 10:03:33 +01:00