Archived

forked from https://github.com/symfony/symfony

This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Go to file

Fabien Potencier bb57e54320 merged branch web-dev/bundle-interface-command-fatal-error (PR #5133 ) Commits ------- `30bcb57` Added a test case to demonstrate the fatal error occuring when a Bundle implementing BundleInterface only is registered in the kernel. Discussion ---------- Fatal error in FrameworkBundle console application A fatal error is generated in the `FrameworkBundle` console application when a bundle is added implementing [`BundleInterface`](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/Bundle/BundleInterface.php) This is because the method `registerCommands` does not exist on this interface and is instead only defined on the concrete [`Bundle`](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/Bundle/Bundle.php#L173) implementation. The workaround for this issue is simple - implement an empty method for `registerCommands` in the bundle implementation so that the fatal error is not triggered. However this issue should probably be fixed by either restricting bundles to the Bundle class or expanding the `BundleInterface` to include the `registerCommands` method signature. Both of these fixes will introduce a BC break into the API so I would suggest creating a fix for 2.0 which includes method detection in the `registerCommands` method of the [`Console\Application`](https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/Console/Application.php#L80) class. I'm happy to submit the fix for this - however I would like some direction from the SF2 dev team as to which way they would like to resolve this. The PR currently only contains a unit test that proves this behaviour. --------------------------------------------------------------------------- by travisbot at 2012-08-01T02:42:55Z This pull request [fails](http://travis-ci.org/symfony/symfony/builds/2006350) (merged `30bcb572` into `1da896dc`). --------------------------------------------------------------------------- by henrikbjorn at 2012-08-01T05:50:16Z I am thinking a instanceof check might be the most reasonable in this case. But in master it should proberly be fixed by adding the method to the interface. /cc @stof any comments if that is to be done? --------------------------------------------------------------------------- by stof at 2012-08-01T08:53:02Z yeah, for 2.0, we cannot change the interface.		2012-08-03 10:18:29 +02:00
src/Symfony	Added a test case to demonstrate the fatal error occuring when a Bundle implementing BundleInterface only is registered in the kernel.	2012-08-01 09:25:05 +07:00
tests	[Validator] Fixed: StaticMethodLoader does not try to invoke methods of interfaces anymore	2012-07-26 16:39:18 +02:00
.gitignore	add composer to gitignore in 2.0	2012-05-10 16:15:45 +03:00
.travis.yml	Add 5.3.3 to Travis, now is available.	2012-05-28 15:38:15 +03:00
autoload.php.dist	bumped minimal version of Swiftmailer to 4.2.0	2012-06-29 18:02:19 +02:00
CHANGELOG-2.0.md	MD format fix	2012-08-03 08:13:46 +02:00
composer.json	fixed swiftmailer requirement in composer file	2012-07-12 00:10:01 +02:00
CONTRIBUTORS.md	update CONTRIBUTORS for 2.0.16	2012-07-11 19:50:55 +02:00
LICENSE	Updated LICENSE files copyright	2012-02-22 10:10:37 +01:00
phpunit.xml.dist	[Security] cleaned up opt-in to benchmark test	2011-03-06 20:06:13 +01:00
README.md	point the status icon to 2.0	2011-11-22 20:15:25 +01:00
UPDATE.ja.md	updated translation of UPDATE file (Japanese RC5 added)	2011-07-30 02:08:25 +09:00
UPDATE.md	UPDATE.md: trivial markdown syntax fix	2011-11-15 10:19:29 -08:00
vendors.php	updated vendors	2012-06-29 18:05:48 +02:00

README.md

README

What is Symfony2?

Symfony2 is a PHP 5.3 full-stack web framework. It is written with speed and flexibility in mind. It allows developers to build better and easy to maintain websites with PHP.

Symfony can be used to develop all kind of websites, from your personal blog to high traffic ones like Dailymotion or Yahoo! Answers.

Requirements

Symfony2 is only supported on PHP 5.3.2 and up.

Installation

The best way to install Symfony2 is to download the Symfony Standard Edition available at http://symfony.com/download.

Documentation

The "Quick Tour" tutorial gives you a first feeling of the framework. If, like us, you think that Symfony2 can help speed up your development and take the quality of your work to the next level, read the official Symfony2 documentation.

Contributing

Symfony2 is an open source, community-driven project. If you'd like to contribute, please read the Contributing Code part of the documentation. If you're submitting a pull request, please follow the guidelines in the Submitting a Patch section.