Archived

forked from https://github.com/symfony/symfony

This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Go to file

Fabien Potencier c761d0cebb merged branch lencioni/fix-clean-output-buffering (PR #3667 ) Commits ------- `068e859` [TwigBundle] Changed getAndCleanOutputBuffering() handling of systems where ob_get_level() never returns 0 Discussion ---------- [TwigBundle] Changed getAndCleanOutputBuffering() handling of systems where ob_get_level() never returns 0 Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: [![Build Status](https://secure.travis-ci.org/lencioni/symfony.png)](http://travis-ci.org/lencioni/symfony) Fixes the following tickets: - Todo: - Relying on decrementing a counter has two problems. First, and most importantly, if the output buffering nesting level is greater than the counter, the function does not perform the expected task. Secondly, on systems where the counter is needed, a lot of unnecessary extra loops would potentially occur. This approach checks to see if the level has stayed the same from the previous iteration and if it has it stops looping. --------------------------------------------------------------------------- by fabpot at 2012-03-21T21:29:50Z Have you encounter this problem to confirm that your approach works? --------------------------------------------------------------------------- by vicb at 2012-03-21T21:35:39Z @lencioni could you also provide an answer from my question in the former version of this PR ? --------------------------------------------------------------------------- by lencioni at 2012-03-21T21:56:06Z @fabpot I have not encountered this problem personally, but the code I submitted is [similar to an approach I use in SLIR](https://github.com/lencioni/SLIR/blob/master/core/slir.class.php#L462), which has been successful for people who have encountered it. @vicb You are referring to [this question](https://github.com/symfony/symfony/pull/3666#issuecomment-4626105), right? >It was possible than the body of the while loop was never executed before, it is no more. Is this expected ? I think you may have misinterpreted the change I submitted. In the original code, there were two conditions being checked in the while loop. The first condition has not changed in my code and could still prevent the body of the while loop from being never executed. The second condition in the original code would always evaluate to 99 on the first iteration, which would not prevent the loop from running. --------------------------------------------------------------------------- by vicb at 2012-03-21T22:00:01Z oops my mistake, sorry.		2012-03-22 14:11:08 +01:00
src/Symfony	[TwigBundle] Changed getAndCleanOutputBuffering() handling of systems where ob_get_level() never returns 0	2012-03-21 15:25:48 -05:00
tests	Changed instances of \DateTimeZone::UTC to 'UTC' as the constant is not valid a produces this error when DateTimeZone is instantiated: DateTimeZone::__construct() [<a href='datetimezone.--construct'>datetimezone.--construct</a>]: Unknown or bad timezone (1024)	2012-03-16 17:19:53 -04:00
.gitignore	Added vendor directory to .gitignore	2010-06-24 10:44:28 +02:00
.travis.yml	also test PHP 5.3.2, since this is the official lowest supported PHP version	2011-12-26 01:15:21 +01:00
autoload.php.dist	Allow autoload to run without vendors being cloned	2012-03-06 13:36:48 +01:00
CHANGELOG-2.0.md	updated CHANGELOG for 2.0.12	2012-03-19 00:56:33 +01:00
check_cs	[Check CS] don't replace 'else if' on twig files (closes #2961 )	2011-12-27 16:10:32 +01:00
composer.json	removed the version attribute in all composer.json files	2012-01-05 14:51:20 +01:00
CONTRIBUTORS.md	update CONTRIBUTORS for 2.0.12	2012-03-19 00:57:27 +01:00
LICENSE	Updated LICENSE files copyright	2012-02-22 10:10:37 +01:00
phpunit.xml.dist	[Security] cleaned up opt-in to benchmark test	2011-03-06 20:06:13 +01:00
README.md	point the status icon to 2.0	2011-11-22 20:15:25 +01:00
UPDATE.ja.md	updated translation of UPDATE file (Japanese RC5 added)	2011-07-30 02:08:25 +09:00
UPDATE.md	UPDATE.md: trivial markdown syntax fix	2011-11-15 10:19:29 -08:00
vendors.php	updated vendors for 2.0.12	2012-03-19 00:53:37 +01:00

README.md

README

What is Symfony2?

Symfony2 is a PHP 5.3 full-stack web framework. It is written with speed and flexibility in mind. It allows developers to build better and easy to maintain websites with PHP.

Symfony can be used to develop all kind of websites, from your personal blog to high traffic ones like Dailymotion or Yahoo! Answers.

Requirements

Symfony2 is only supported on PHP 5.3.2 and up.

Installation

The best way to install Symfony2 is to download the Symfony Standard Edition available at http://symfony.com/download.

Documentation

The "Quick Tour" tutorial gives you a first feeling of the framework. If, like us, you think that Symfony2 can help speed up your development and take the quality of your work to the next level, read the official Symfony2 documentation.

Contributing

Symfony2 is an open source, community-driven project. If you'd like to contribute, please read the Contributing Code part of the documentation. If you're submitting a pull request, please follow the guidelines in the Submitting a Patch section.