This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
symfony/src/Symfony/Component
Fabien Potencier ce2fae1953 merged branch reenl/fix-round-issues (PR #8447)
This PR was merged into the 2.2 branch.

Discussion
----------

[Console] Show completed percentage, not a rounded value.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This pull request has 2 minor changes:
- 199/200 => 99% instead of 100% (there was no test case and I added one, everything else passes) In the past the value was rounded, the progress bar ended up being 100% for 0.5% of the total execution time. That means 18 seconds on a 1 hour process.
- Fixed the comments to match the inner workings of RedrawFrequency.

First Symfony PR and second overall so hope I just did this the right way.

PR #8419 Rebased for 2.2

Commits
-------

91bb757 ProgressHelper shows percentage complete.
40591b9 Comment fixed: RedrawFrequency is measured in steps.
2013-07-08 16:59:54 +02:00
..
BrowserKit Merge branch '2.1' into 2.2 2013-04-30 09:15:50 +02:00
ClassLoader Merge branch '2.1' into 2.2 2013-05-06 22:02:13 +02:00
Config Merge branch '2.1' into 2.2 2013-05-10 20:08:31 +02:00
Console ProgressHelper shows percentage complete. 2013-07-08 16:34:53 +02:00
CssSelector fixed CS 2013-07-01 14:15:46 +02:00
DependencyInjection Merge branch '2.1' into 2.2 2013-05-06 10:37:50 +02:00
DomCrawler fixed CS 2013-07-01 14:15:46 +02:00
EventDispatcher Merge branch '2.1' into 2.2 2013-02-11 12:26:43 +01:00
Filesystem Merge branch '2.1' into 2.2 2013-05-06 22:02:13 +02:00
Finder fixed CS 2013-07-01 14:15:46 +02:00
Form [Form] fixed INF usage which does not work on Solaris (closes #8246) 2013-06-23 09:35:41 +02:00
HttpFoundation Update JsonResponse.php 2013-07-08 15:12:21 +02:00
HttpKernel merged branch lsmith77/fix_include_default_text (PR #8445) 2013-07-08 16:43:11 +02:00
Locale Update composer.json files: - to allow versions ~2.2 (>=2.2,<3.0) of Doctrine DBAL, ORM & Common - fixed Propel1 versions difference between main and bridge files - fixed Twig versions difference between main and bridge files - to allow versions ~1.11 (>=1.11,<2.0) of Twig - fixed Locale ext-intl version to accept all, not non-existing version 2013-02-01 10:33:53 +01:00
OptionsResolver Merge branch '2.1' 2013-01-17 16:25:59 +01:00
Process [Process] Disable exception on stream_select timeout 2013-06-13 17:57:04 +02:00
PropertyAccess [PropertyAccess] Add objectives to pluralMap 2013-04-08 00:02:49 +02:00
Routing Fix grammar 2013-06-23 08:56:04 +02:00
Security Merge branch '2.1' into 2.2 2013-05-27 16:47:40 +02:00
Serializer [Serializer] fixed CS (refs #7971) 2013-05-08 10:39:40 +02:00
Stopwatch updated license year 2013-01-04 17:58:00 +01:00
Templating Merge branch '2.1' into 2.2 2013-04-17 07:27:14 +02:00
Translation fixed CS 2013-05-10 18:49:00 +02:00
Validator Replace romaji period characters with Japanese style zenkaku period characters 2013-07-02 09:41:45 +02:00
Yaml Merge branch '2.1' into 2.2 2013-05-10 20:08:31 +02:00