This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
symfony/src/Symfony/Component
Fabien Potencier d2bac32525 feature #38940 [Messenger] Improve formatting of exception in failed message (Jeroen Noten)
This PR was merged into the 5.2-dev branch.

Discussion
----------

[Messenger] Improve formatting of exception in failed message

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | not really, enhancement of an existing feature
| Deprecations? | no
| Tickets       | Fix #32310
| License       | MIT

This PR improves the formatting of exception details in failed messenges when displayed using `messenger:failed:show <id> -vv`.

Before:
<img width="807" alt="Screen Shot 2020-11-01 at 1 05 24 PM" src="https://user-images.githubusercontent.com/4370753/97802602-ea593200-1c44-11eb-8bcb-7fcf2d3f1db0.png">

After:
<img width="803" alt="Screen Shot 2020-11-01 at 1 03 09 PM" src="https://user-images.githubusercontent.com/4370753/97802615-f0e7a980-1c44-11eb-8c12-46b2d4510364.png">

I created a `ThrownExceptionDetails` class which will be displayed as a normal exception when dumped with the VarDumper component. Not sure if this is the right way to do it and if the class is in the right namespace, but this is the best solution I could came up with to fix #32310. I'm open for other suggestions.

Commits
-------

2ad1adda69 [Messenger] Improve formatting of thrown exception in show failed message command
2020-11-04 08:21:06 +01:00
..
Asset Merge branch '4.4' into 5.1 2020-10-24 14:01:57 +02:00
BrowserKit Merge branch '5.1' into 5.x 2020-10-28 22:46:03 +01:00
Cache Merge branch '5.1' into 5.x 2020-11-02 09:16:52 +01:00
Config Merge branch '5.1' into 5.x 2020-10-28 22:46:03 +01:00
Console [Console] Make error message more verbose 2020-11-01 18:40:07 +01:00
CssSelector Merge branch '4.4' into 5.1 2020-10-28 22:31:18 +01:00
DependencyInjection Merge branch '5.1' into 5.x 2020-11-02 16:47:15 +01:00
DomCrawler Merge branch '4.4' into 5.1 2020-10-24 14:01:57 +02:00
Dotenv Merge branch '4.4' into 5.1 2020-10-24 14:01:57 +02:00
ErrorHandler Merge branch '5.1' into 5.x 2020-10-28 22:46:03 +01:00
EventDispatcher Merge branch '5.1' into 5.x 2020-11-01 17:14:45 +01:00
ExpressionLanguage Merge branch '5.1' into 5.x 2020-10-28 22:46:03 +01:00
Filesystem Fix CS 2020-10-28 22:33:29 +01:00
Finder Merge branch '4.4' into 5.1 2020-11-02 08:55:38 +01:00
Form Merge branch '5.1' into 5.x 2020-11-02 16:47:15 +01:00
HttpClient Merge branch '5.1' into 5.x 2020-10-24 14:08:07 +02:00
HttpFoundation Deprecate HEADER_X_FORWARDED_ALL constant 2020-11-02 17:16:33 +01:00
HttpKernel feature #38954 [HttpFundation][FrameworkBundle] Deprecate the HEADER_X_FORWARDED_ALL constant (jderusse) 2020-11-04 08:16:55 +01:00
Inflector Merge branch '4.4' into 5.1 2020-10-24 14:01:57 +02:00
Intl Merge branch '4.4' into 5.1 2020-11-03 12:59:17 +01:00
Ldap Merge branch '5.1' into 5.x 2020-11-01 17:14:45 +01:00
Lock Merge branch '5.1' into 5.x 2020-10-28 22:46:03 +01:00
Mailer Merge branch '5.1' into 5.x 2020-10-28 22:46:03 +01:00
Messenger [Messenger] Improve formatting of thrown exception in show failed message command 2020-11-03 13:22:22 +01:00
Mime remove reflection-docblock from mime requirements 2020-10-30 15:55:39 +01:00
Notifier [Notifier] Add unit tests for NullMessage, NullTransport and NullTransportFactory 2020-11-03 00:54:11 +01:00
OptionsResolver Merge branch '5.1' into 5.x 2020-10-24 14:08:07 +02:00
Process Merge branch '5.1' into 5.x 2020-11-02 16:47:15 +01:00
PropertyAccess Merge branch '5.1' into 5.x 2020-11-01 17:14:45 +01:00
PropertyInfo Merge branch '5.1' into 5.x 2020-10-28 22:46:03 +01:00
RateLimiter feature #38664 [RateLimiter] Moved classes implementing LimiterInterface to a new namespace (Nyholm) 2020-10-25 09:35:39 +01:00
Routing Fix transiant tests in 4.4 2020-11-01 22:34:37 +01:00
Security Merge branch '5.1' into 5.x 2020-11-02 16:47:15 +01:00
Semaphore Merge branch '5.1' into 5.x 2020-10-24 14:08:07 +02:00
Serializer Merge branch '5.1' into 5.x 2020-11-01 17:14:45 +01:00
Stopwatch Merge branch '5.1' into 5.x 2020-11-01 17:14:45 +01:00
String Merge branch '5.1' into 5.x 2020-10-24 14:08:07 +02:00
Templating Merge branch '4.4' into 5.1 2020-10-24 14:01:57 +02:00
Translation Merge branch '5.1' into 5.x 2020-10-28 22:46:03 +01:00
Uid Merge branch '5.1' into 5.x 2020-10-24 14:08:07 +02:00
Validator Merge branch '5.1' into 5.x 2020-11-02 16:47:15 +01:00
VarDumper Merge branch '5.1' into 5.x 2020-10-28 22:46:03 +01:00
VarExporter Merge branch '4.4' into 5.1 2020-10-28 22:31:18 +01:00
WebLink Merge branch '4.4' into 5.1 2020-10-24 14:01:57 +02:00
Workflow Merge branch '5.1' into 5.x 2020-10-28 22:46:03 +01:00
Yaml fix merge 2020-10-24 14:03:25 +02:00