This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
symfony/src/Symfony/Bundle/FrameworkBundle
Fabien Potencier 2abe788f6e minor #24407 [FrameworkBundle] Make Controller helpers final (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] Make Controller helpers final

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

I propose to make all ControllerTrait methods final so we can add type hints.
I also propose to add ControllerTrait::has/get so that AbstractController also has the methods.
This will help move from Controller to AbstractController.

Commits
-------

bbc52a1d14 [FrameworkBundle] Make Controller helpers final
2017-10-03 11:13:57 -07:00
..
CacheWarmer Merge branch '3.3' into 3.4 2017-10-02 08:49:52 +02:00
Command [FrameworkBundle] Expose dotenv in bin/console about 2017-10-03 17:06:18 +02:00
Console Merge branch '3.3' into 3.4 2017-10-02 08:49:52 +02:00
Controller [FrameworkBundle] Make Controller helpers final 2017-10-03 11:44:07 +02:00
DataCollector [FrameworkBundle] Extends the RequestDataCollector 2016-03-30 19:02:53 +02:00
DependencyInjection [FrameworkBundle] Don't clear app pools on cache:clear 2017-09-30 20:17:55 +02:00
EventListener check _controller attribute is a string before parsing it 2017-07-10 18:12:17 +02:00
HttpCache Merge branch '2.8' into 3.3 2017-10-02 08:42:24 +02:00
Kernel [DI] Turn services and aliases private by default, with BC layer 2017-09-19 11:28:48 +02:00
Resources Show welcome message if no routing configuration could be found 2017-10-02 19:25:29 -04:00
Routing Merge branch '3.3' into 3.4 2017-10-02 08:49:52 +02:00
Templating Merge branch '3.3' into 3.4 2017-10-02 08:49:52 +02:00
Test Merge branch '3.3' into 3.4 2017-09-15 12:12:22 +02:00
Tests Merge branch '3.3' into 3.4 2017-10-02 08:49:52 +02:00
Translation Merge branch '3.3' into 3.4 2017-10-02 08:49:52 +02:00
Validator removed useless PHPDoc 2017-09-30 07:00:23 -07:00
.gitignore Added missing files .gitignore 2013-07-21 14:12:18 +02:00
CHANGELOG.md [FrameworkBundle] Expose dotenv in bin/console about 2017-10-03 17:06:18 +02:00
Client.php [FrameworkBundle] Fix autoloader in insulated clients 2017-03-08 10:00:17 +01:00
composer.json [Lock] Include lock component in framework bundle 2017-09-27 08:10:55 -07:00
FrameworkBundle.php feature #24300 [HttpKernel][FrameworkBundle] Add a minimalist default PSR-3 logger (dunglas) 2017-09-29 10:02:07 -07:00
LICENSE updated LICENSE year 2017-01-02 12:30:00 -08:00
phpunit.xml.dist Merge branch '3.2' 2017-04-12 07:14:56 -07:00
README.md add readme files where missing 2016-03-07 11:36:15 +01:00