diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
db91042f6b
symfony/src/Symfony/Component
History
Christian Flothmann db91042f6b minor #31222 [Form] Add Button type back to Form::getClickedButton docblock (Bill Hance) 
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Add Button type back to Form::getClickedButton docblock

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

In commit 56429a6f08 the `Button` type was removed from the return doc block.

I suspect this was an oversight because, AFAIK, the [recommended way](https://symfony.com/doc/current/form/multiple_buttons.html) to check the name of a clicked button would require a return type of `Button` or `SubmitButton`.

The effect is that our static analysis checks are failing.
```
Call to an undefined method
Symfony\Component\Form\ClickableInterface::getName().
```

Commits
-------

b71d589071 Added FormInterface to @return Form::getClickedButton docblock
2019-06-08 11:35:31 +02:00
..
Asset Use willReturn() instead of will(returnValue()). 2019-05-30 17:47:52 +02:00
BrowserKit Run test in separate process 2019-04-06 21:33:58 +02:00
Cache Use willReturn() instead of will(returnValue()). 2019-05-30 17:47:52 +02:00
ClassLoader switched array() to [] 2019-01-16 10:39:14 +01:00
Config Use willReturn() instead of will(returnValue()). 2019-05-30 17:47:52 +02:00
Console Fix json-encoding when JSON_THROW_ON_ERROR is used 2019-06-05 13:33:52 +02:00
CssSelector switched array() to [] 2019-01-16 10:39:14 +01:00
Debug Use willReturn() instead of will(returnValue()). 2019-05-30 17:47:52 +02:00
DependencyInjection Use willReturn() instead of will(returnValue()). 2019-05-30 17:47:52 +02:00
DomCrawler Use willReturn() instead of will(returnValue()). 2019-05-30 17:47:52 +02:00
Dotenv SCA: minor code tweaks 2019-04-01 09:08:40 +02:00
EventDispatcher Use willReturn() instead of will(returnValue()). 2019-05-30 17:47:52 +02:00
ExpressionLanguage Use willReturn() instead of will(returnValue()). 2019-05-30 17:47:52 +02:00
Filesystem [Filesystem] Fixed some docblocks and typos 2019-02-04 22:34:32 +01:00
Finder Use willReturn() instead of will(returnValue()). 2019-05-30 17:47:52 +02:00
Form minor #31222 [Form] Add Button type back to Form::getClickedButton docblock (Bill Hance) 2019-06-08 11:35:31 +02:00
HttpFoundation bug #31863 [HttpFoundation] Fixed case-sensitive handling of cache-control header in RedirectResponse constructor (Ivo) 2019-06-05 15:24:38 +02:00
HttpKernel Use willReturn() instead of will(returnValue()). 2019-05-30 17:47:52 +02:00
Inflector fixed short array CS in comments 2019-01-16 14:27:11 +01:00
Intl Use willReturn() instead of will(returnValue()). 2019-05-30 17:47:52 +02:00
Ldap Use willReturn() instead of will(returnValue()). 2019-05-30 17:47:52 +02:00
Lock switched array() to [] 2019-01-16 10:39:14 +01:00
OptionsResolver CS Fixes: Not double split with one array argument 2019-04-10 18:00:48 +02:00
Process Use willReturn() instead of will(returnValue()). 2019-05-30 17:47:52 +02:00
PropertyAccess Add a missing quote in getValue() DocBlock 2019-06-05 17:56:22 +02:00
PropertyInfo [PropertyInfo] Add missing documentation link in Readme 2019-05-16 16:10:36 +02:00
Routing Use willReturn() instead of will(returnValue()). 2019-05-30 17:47:52 +02:00
Security [Security] added support for updated \"distinguished name\" format in x509 authentication 2019-06-04 09:01:11 +02:00
Serializer [Serializer] Fix DataUriNormalizer docblock & composer suggest section 2019-06-07 10:45:31 +02:00
Stopwatch switched array() to [] 2019-01-16 10:39:14 +01:00
Templating Use willReturn() instead of will(returnValue()). 2019-05-30 17:47:52 +02:00
Translation Fix json-encoding when JSON_THROW_ON_ERROR is used 2019-06-05 13:33:52 +02:00
Validator fix typo in PR #31802 2019-06-03 11:50:31 +02:00
VarDumper Reword VarDumper description 2019-05-01 11:52:10 +02:00
WebLink switched array() to [] 2019-01-16 10:39:14 +01:00
Workflow Use willReturn() instead of will(returnValue()). 2019-05-30 17:47:52 +02:00
Yaml use behavior instead of behaviour 2019-03-25 08:48:46 +01:00