This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Fabien Potencier 1bebf30454 merged branch snc/profiler-tests (PR #3454) ... Commits ------- ed8c1c0 Fixed AbstractProfilerStorageTest and some minor CS changes. 1ac581e Overwrite the profile data if the token already exists like in the other implementations. 198d406 Return profiler results sorted by time in descending order like in the other implementations. 9d8e3f2 Refactored profiler storage tests to share some code. Discussion ---------- [WIP] Refactored profiler tests including some storage fixes Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes While refactoring the tests I came across some inconsistencies. Two of them are already fixed in this PR. One thing left is the [MongoDbProfilerStorageTest::testCleanup()](9d8e3f2da4/tests/Symfony/Tests/Component/HttpKernel/Profiler/MongoDbProfilerStorageTest.php (L51)) test which fails in all other storage implementations. The mongodb implementation uses the `time` value from the profiler data to clean up the storage while the others additionally save a `created_at` value which is then used. For me this `created_at` value does not make any sense and I would suggest to change the other implementations to use the `time` value for cleaning up. What do you think? --------------------------------------------------------------------------- by pulzarraider at 2012-02-27T06:55:06Z +1 for refactoring profiler tests, I will update my RedisProfilerStorage after your changes will be merged. --------------------------------------------------------------------------- by snc at 2012-02-28T20:05:12Z Any suggestions about the cleanup issue?		2012-03-02 21:37:15 +01:00
..
Bundle	fixed CS	2011-06-08 19:56:59 +02:00
CacheClearer	Coding standards and removing whitespace.	2011-12-24 15:50:47 +05:45
CacheWarmer	removed unused use statements	2011-10-29 11:56:30 +02:00
Controller	[HttpKernel] fixed function support in ControllerResolver (closes #3331)	2012-02-12 00:34:53 +01:00
DataCollector	removed unused use statements	2011-11-24 07:16:14 +01:00
Debug	Broaden timer tests limits	2012-02-23 20:36:56 +01:00
DependencyInjection	[HttpKernel] added BundleInterface::getContainerExtension() which is implicitly loaded	2011-04-25 21:12:35 -07:00
EventListener	[HttpFoundation] Moved session related classes to own sub-namespace.	2012-02-11 11:24:31 +05:45
Exception	[HttpKernel] added some unit tests for ExceptionHandler and	2012-01-22 11:19:40 +01:00
Fixtures	removed empty lines/trailing spaces	2011-04-15 21:12:02 +02:00
HttpCache	merged 2.0	2012-02-04 08:03:45 +01:00
Profiler	merged branch snc/profiler-tests (PR #3454)	2012-03-02 21:37:15 +01:00
ClientTest.php	[CS] Fix usage of assertCount	2012-01-18 14:42:47 +01:00
HttpKernelTest.php	[HttpKernel] added request and response as arguments to the TerminableInterface::terminate() method	2011-12-15 18:16:29 +01:00
KernelTest.php	[HttpKernel] added request and response as arguments to the TerminableInterface::terminate() method	2011-12-15 18:16:29 +01:00
Logger.php	[HttpKernel] Added the context in the LoggerInterface	2011-06-17 12:26:12 +02:00
TestHttpKernel.php	[HttpKernel] Simplify test code	2011-08-18 09:32:26 +02:00