This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Fabien Potencier deb740b6ed merged branch bamarni/preloaded-extension (PR #5479) ... This PR was merged into the 2.1 branch. Commits ------- 84635bd [Form] allowed no type guesser to be registered Discussion ---------- [Form] made the factory builder pass null when no type guesser registered reopened #5422 against 2.1 as it's a bug fix --------------------------------------------------------------------------- by stof at 2012-10-13T21:23:34Z @fabpot anything left for this PR ? --------------------------------------------------------------------------- by fabpot at 2012-10-14T09:41:29Z @bamarni Can you add some unit tests and also update the FormExtensionInterface interface phpdoc as `getTypeGuesser` can now return `null`? Thanks. ping @bschussek --------------------------------------------------------------------------- by bamarni at 2012-10-14T17:10:27Z I've added a few tests covering this. @fabpot : the phpdoc is already correct, it currently can return null, this only occurs with this convenient class. --------------------------------------------------------------------------- by bschussek at 2012-10-16T07:43:41Z This PR breaks FormFactory::createBuilderForProperty(), which expects a guesser to be present. Can you check the component for other uses of the guesser and add a null-check there? --------------------------------------------------------------------------- by bamarni at 2012-10-16T10:57:54Z I cannot find other places than the factory (searching for 'getTypeGuesser'). --------------------------------------------------------------------------- by bschussek at 2012-11-08T16:58:37Z You should also adapt `FormRegistry::getTypeGuesser()` not to build a `FormTypeGuesserChain` if the array of guessers is empty. In that case it will return now `null` (adapt the doc block). We also need a different was of checking if the type guessers have already been parsed in FormRegistry. Otherwise the first if condition in `FormRegistry::getTypeGuesser()` will never become false. You could for example initialize the property `$guesser` to `false` and only set it to `null` after the first run of `getTypeGuesser()`. --------------------------------------------------------------------------- by bamarni at 2012-11-08T18:40:00Z good catch I had missed it! I've applied your suggestion in the latest commit. Do you see anything else before I squash? --------------------------------------------------------------------------- by bschussek at 2012-11-08T18:45:15Z A test for `FormRegistry::getTypeGuesser()` would of course be awesome. --------------------------------------------------------------------------- by bamarni at 2012-11-08T18:52:13Z Then it was already awesome! (see https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/Tests/FormRegistryTest.php#L252) I've also added one for the null case if it's what you meant.		2012-11-24 12:52:59 +01:00
..
Symfony	merged branch bamarni/preloaded-extension (PR #5479)	2012-11-24 12:52:59 +01:00