diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
forked from https://github.com/symfony/symfony
This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
29,053 Commits 24 Branches 563 Tags 228 MiB
PHP 98.7%
Twig 1.1%
CSS 0.1%
df876b3044
Go to file
Fabien Potencier df876b3044 feature #20887 [Form] DateIntervalType: Allow to configure labels & enhance form theme (ogizanagi) 
This PR was merged into the 3.3-dev branch.

Discussion
----------

[Form] DateIntervalType: Allow to configure labels & enhance form theme

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no (unless someone relies on this non themed type)
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | Should document the new `labels` option

I just realized by using it for last fixes in #20886 and #20877 that this type was not really themed:

### before

<img width="861" alt="screenshot 2016-12-13 a 00 54 35" src="https://cloud.githubusercontent.com/assets/2211145/21121792/c589d27a-c0ce-11e6-8368-a396fda3bc7a.PNG">

At least labels should appear, but this also means being able to change them (thus the new `labels` option).

I think the form themes should provide a functional & minimalistic integration like this:

### after

<img width="862" alt="screenshot 2016-12-13 a 00 54 17" src="https://cloud.githubusercontent.com/assets/2211145/21121814/d9c4ead6-c0ce-11e6-94e1-41e6c14884a7.PNG">

---
(On screenshots above, I've only added a css rule to remove the 100% width of the `.table` class. See https://github.com/symfony/symfony/pull/20887#discussion_r92069557)

Commits
-------

bfd9e50bbb [Form] DateIntervalType: Allow to configure labels & enhance form theme
2017-01-11 11:11:51 -08:00
.composer Drop hirak/prestissimo 2016-05-12 07:44:15 -05:00
.github Minor fixes found while ugrading the CI 2017-01-03 16:43:07 +01:00
src/Symfony feature #20887 [Form] DateIntervalType: Allow to configure labels & enhance form theme (ogizanagi) 2017-01-11 11:11:51 -08:00
.editorconfig Add EditorConfig File 2012-06-16 14:08:15 +02:00
.gitignore Add appveyor.yml for C.I. on Windows 2015-08-25 23:41:37 +02:00
.php_cs.dist Merge branch '2.7' into 2.8 2017-01-04 14:01:04 -08:00
.travis.yml feature #21108 [Cache] Add DSN, createClient & better error reporting to MemcachedAdapter (nicolas-grekas, robfrawley) 2017-01-04 07:51:37 +01:00
appveyor.yml Merge branch '3.1' into 3.2 2017-01-03 12:28:32 +01:00
CHANGELOG-3.0.md Merge branch '2.8' into 3.1 2016-08-05 10:37:39 +02:00
CHANGELOG-3.1.md updated CHANGELOG for 3.1.8 2016-12-13 13:52:03 +01:00
CHANGELOG-3.2.md updated CHANGELOG for 3.2.1 2016-12-13 14:19:37 +01:00
composer.json [WebServerBundle] moved most of the logic in a new class 2016-12-30 08:54:40 +01:00
CONTRIBUTING.md Mention the community review guide 2016-12-18 22:02:35 +01:00
CONTRIBUTORS.md update CONTRIBUTORS for 2.7.22 2016-12-13 11:53:11 +01:00
LICENSE updated LICENSE year 2017-01-02 12:30:00 -08:00
phpunit Minor fixes found while ugrading the CI 2017-01-03 16:43:07 +01:00
phpunit.xml.dist [cache] Add tests for MemcachedAdapter::createClient() 2017-01-03 17:10:30 +01:00
README.md Merge branch '2.8' into 3.1 2016-12-23 17:43:44 +01:00
UPGRADE-3.0.md Merge branch '2.8' into 3.1 2016-11-18 16:15:08 -05:00
UPGRADE-3.1.md [Serializer] Remove AbstractObjectNormalizer::isAttributeToNormalize 2016-12-08 16:02:32 +01:00
UPGRADE-3.2.md [TwigBridge] Fix upgrade/changelog notes 2016-12-27 20:04:23 +01:00
UPGRADE-3.3.md Move AddConsoleCommandPass from FrameworkBundle to Console. 2017-01-11 13:05:48 +01:00
UPGRADE-4.0.md Move AddConsoleCommandPass from FrameworkBundle to Console. 2017-01-11 13:05:48 +01:00

README.md

README

What is Symfony?

Symfony is a PHP full-stack web framework. It is written with speed and flexibility in mind. It allows developers to build better and easy to maintain websites with PHP.

Symfony can be used to develop all kind of websites, from your personal blog to high traffic ones like Dailymotion or Yahoo! Answers.

Installation

The best way to install Symfony is to use the official Symfony Installer. It allows you to start a new project based on the version you want.

Documentation

The "Quick Tour" tutorial gives you a first feeling of the framework. If, like us, you think that Symfony can help speed up your development and take the quality of your work to the next level, read the official Symfony documentation.

Contributing

Symfony is an open source, community-driven project. If you'd like to contribute, please read the Contributing Code part of the documentation. If you're submitting a pull request, please follow the guidelines in the Submitting a Patch section and use Pull Request Template.

Community Reviews

If you don't feel ready to contribute code or patches, reviewing issues and pull requests can be a great start to get involved and give back. In fact, people who "triage" issues are the backbone to Symfony's success!
More information can be found in the Community Reviews guide.

Running Symfony Tests

Information on how to run the Symfony test suite can be found in the Running Symfony Tests section.