This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Fabien Potencier e3cc337b00 merged branch colinfrei/deprecationErrors (PR #6180) ... This PR was merged into the master branch. Commits ------- 6b10550 Merge branch 'master' of github.com:symfony/symfony into deprecationErrors 1d82112 [Form] Fix two cases where deprecated methods were being used b8cdbdc [Form] Catch deprecation errors that are caused by BC code ebcb432 [Form] [FrameworkBundle] catch deprecation errors in tests c21b12e [Form] handle BC use of deprecated stuff in non-test-methods. fc2be6d [Form] catch deprecated errors in tests 800a032 [Form] replace bindRequest() with bind(), as bindRequest is deprecated d5b2638 [Form] Trigger errors for deprecated methods in Form Component f3d6966 [Validator] Stop using deprecated methods d57ad32 [Form] Catch deprecation errors when using deprecated methods/classes in tests 3241157 [Validator] Trigger errors for deprecations 1f9eb7f return value of handleError b35de9e Handle errors using a custom error handler f49704b trigger errors for deprecated methods in HttpFoundation component Discussion ---------- trigger_error() for deprecations See also #6173 and #6139. Started triggering errors in the HttpFoundation component. It seems as if most of the time the error is just duplicating the text in the @deprecation comment. Any opinions on if duplicating the text is acceptable, or if fetching the comment text to output the error makes sense? --------------------------------------------------------------------------- by Seldaek at 2012-12-04T13:39:42Z IMO it's fine to just duplicate the `@deprecated` note in the message, since anyway this code is meant to be completely deleted, this duplication should not do much harm. --------------------------------------------------------------------------- by fabpot at 2012-12-06T08:22:21Z @colinfrei I've merged PR #6173. Do you have time to implement the `trigger_error()` call everywhere? Thanks. --------------------------------------------------------------------------- by colinfrei at 2012-12-06T08:36:55Z Yep I'll finish that, probably until the beginning of next week. --------------------------------------------------------------------------- by bschussek at 2012-12-10T10:15:12Z Thank you for working on this! --------------------------------------------------------------------------- by fabpot at 2012-12-12T11:08:53Z @colinfrei: Is this PR finished? Can I merge it? --------------------------------------------------------------------------- by colinfrei at 2012-12-12T12:09:19Z @fabpot not quite - I lost some work due to a computer crash over the weekend. The only thing open is fixing the tests for the Form Component and catching the cases where the Form Component intentionally uses deprecated stuff. --------------------------------------------------------------------------- by colinfrei at 2012-12-15T07:32:28Z @fabpot - finished adding trigger_errors and catching them in Tests and as needed. Travis is failing, but that seems to be master being broken due to the Finder changes? I changed a few cases where the code was using deprecated methods which wasn't necessary in my eyes, specifically 1d8211249b, 800a032f07, f3d696636a		2012-12-15 08:53:57 +01:00
..
Bridge	merged branch colinfrei/deprecationErrors (PR #6180)	2012-12-15 08:53:57 +01:00
Bundle	merged branch colinfrei/deprecationErrors (PR #6180)	2012-12-15 08:53:57 +01:00
Component	merged branch colinfrei/deprecationErrors (PR #6180)	2012-12-15 08:53:57 +01:00