This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
symfony/src/Symfony
Fabien Potencier e4bbd462f3 bug #24802 [TwigBridge] [Bootstrap 4] Fix hidden errors (ostrolucky)
This PR was merged into the 3.4 branch.

Discussion
----------

[TwigBridge] [Bootstrap 4] Fix hidden errors

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24801
| License       | MIT
| Doc PR        | -

Fixes displaying errors for:

- Symfony\Component\Form\Extension\Core\Type\BirthdayType
- Symfony\Component\Form\Extension\Core\Type\CheckboxType
- Symfony\Component\Form\Extension\Core\Type\DateIntervalType
- Symfony\Component\Form\Extension\Core\Type\DateTimeType
- Symfony\Component\Form\Extension\Core\Type\DateType
- Symfony\Component\Form\Extension\Core\Type\FileType
- Symfony\Component\Form\Extension\Core\Type\RadioType
- Symfony\Component\Form\Extension\Core\Type\TimeType

<table>
<tr><th>Layout</th><th>Before</th><th>After</th></tr>
<tr><td>vertical</td><td valign="top"><img src="https://user-images.githubusercontent.com/496233/32405939-1b4c92c8-c16f-11e7-9b21-8af296aa8d94.png" width="400" alt="less validation errors shown in vertical bs4 layout" /></td>
<td valign="top"><img src="https://user-images.githubusercontent.com/496233/32405935-008a3d8c-c16f-11e7-8155-2a51ab55ae9a.png" width="400" alt="more validation errors shown in vertical bs4 layout"  /></td>
</tr>
<tr><td>horizontal</td><td valign="top"><img src="https://user-images.githubusercontent.com/496233/32405984-213b432c-c170-11e7-832a-d94c7f7ddf07.png" width="400" alt="less validation errors shown in bs4 horizontal layout" /></td>
<td valign="top"><img src="https://user-images.githubusercontent.com/496233/32406022-bd25bf92-c170-11e7-893d-f071225f8273.png" width="400" alt="more validation errors shown"  /></td>
</tr>
</table>

Commits
-------

5810983e30 Fix displaying errors for bootstrap 4
2017-11-05 07:45:34 -08:00
..
Bridge Fix displaying errors for bootstrap 4 2017-11-04 14:34:38 +01:00
Bundle bug #24821 symfony/form auto-enables symfony/validator, even when not present (weaverryan) 2017-11-05 07:35:58 -08:00
Component bug #24822 [DI] Fix "almost-circular" dependencies handling (nicolas-grekas) 2017-11-05 07:38:28 -08:00