diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
e71d1579d1
symfony/tests/Symfony/Tests/Component/Form
History
Fabien Potencier e71d1579d1 merged branch helmer/readonly (PR #3193) 
Commits
-------

de253dd [Form] read_only and disabled attributes

Discussion
----------

[Form] read_only and disabled attributes (closes #1974)

1. Removed ``readOnly`` property from ``Form``, as it is no longer required
2. Introduced ``disabled`` property to ``Form``, behaves exactly like ``readOnly`` used to
3. Added ``disabled`` property to fields, defaults to ``false``, renders as ``disabled="disabled"``
4. A field with positive ``read_only`` property now renders as ``readonly="readonly"``

---------------------------------------------------------------------------

by helmer at 2012-01-26T17:46:17Z

I changed ``Form`` and ``FormBuilder`` property ``readOnly`` to ``disabled``. On second thought, this is perhaps not such good change - while readOnly somewhat implied the use-case, disabled no longer does.

Perhaps something else, like ``bindable`` (as not to confuse with read_only attribute of Fields)?

@bschussek, others, any thoughts?

---------------------------------------------------------------------------

by bschussek at 2012-01-31T06:53:59Z

Please prefix commits with the affected component, if applicable.

---------------------------------------------------------------------------

by helmer at 2012-01-31T08:41:03Z

@bschussek Prefixed. Please also see see to [this question](https://github.com/symfony/symfony/pull/3193#issuecomment-3673074)
2012-02-02 10:03:00 +01:00
..
Extension merged branch helmer/readonly (PR #3193) 2012-02-02 10:03:00 +01:00
Fixtures [Form] Reverted PR #1758. 2011-07-22 16:42:50 +02:00
Guess fixed CS 2011-06-08 19:56:59 +02:00
Util [Form] Greatly improved ChoiceListInterface and all of its implementations 2012-01-23 18:28:25 +01:00
AbstractDivLayoutTest.php [Form] reverted partially previous commit 2011-09-24 16:42:12 +02:00
AbstractExtensionTest.php merged 2.0 2011-10-29 12:01:39 +02:00
AbstractLayoutTest.php merged branch helmer/readonly (PR #3193) 2012-02-02 10:03:00 +01:00
AbstractTableLayoutTest.php Rebased with master, and fixed wrong behavior with proper tests coverage 2011-09-24 10:44:47 +02:00
FormBuilderTest.php [Form] Restricted form names to specific characters to (1) fix generation of HTML IDs and to (2) avoid problems with property paths. 2012-01-23 18:28:25 +01:00
FormFactoryTest.php [Form] read_only and disabled attributes 2012-01-31 11:51:22 +02:00
FormInterface.php fixed CS 2011-06-08 19:56:59 +02:00
FormTest.php merged branch helmer/readonly (PR #3193) 2012-02-02 10:03:00 +01:00
PropertyPathTest.php [Tests] Use proper phpunit assertion functions: "assertTrue", "assertFalse", "assertNull" 2011-08-25 15:41:15 +02:00