diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.
ed799c96af
symfony/src/Symfony/Component
History
Fabien Potencier ed799c96af bug #9354 [2.2][Process] Fix #9343 : revert file handle usage on Windows platform (romainneutron) 
This PR was merged into the 2.2 branch.

Discussion
----------

[2.2][Process] Fix #9343 : revert file handle usage on Windows platform

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9343
| License       | MIT

Hello,

I propose to revert the use of file handles only for `STDOUT` on Windows platform (see implementation in 2.2.6 [here](4059720232/src/Symfony/Component/Process/Process.php (L231-L242))).

When I decoupled pipes management from `Process` in #8924, I used file handles for both `STDOUT` and `STDERR`. This was an error as it introduced random failure in reading the handles (reported as [PHP#65650](https://bugs.php.net/bug.php?id=65650)).

Reverting to the previous implementation solves the issue. My apologies for the issues it introduced.

Versions that have been affected by the bug are 2.2.7, 2.2.8, 2.2.9, 2.3.4, 2.3.5 and 2.3.6.

Side note : I thought about testing the file handles implementation on *nix, but it fails most of the time where as Windows is okay. Unit testing on windows is okay (AbstractProcessTest::testProcessPipes tests it), but I don't provide a travis compatible test.

Commits
-------

e9dd408 [Process] Fix #9343 : revert file handle usage on Windows platform
2013-10-26 09:51:51 +02:00
..
BrowserKit bugix: CookieJar returns cookies with domain "domain.com" for domain "foodomain.com" 2013-09-25 15:49:28 +02:00
ClassLoader Fix some annotates 2013-09-19 11:36:05 +02:00
Config Fix some annotates 2013-09-19 11:36:05 +02:00
Console Run all tests in parallel. 2013-09-25 07:58:50 +02:00
CssSelector Fix some annotates 2013-09-19 11:36:05 +02:00
DependencyInjection Fix some annotates 2013-09-19 11:36:05 +02:00
DomCrawler [DomCrawler]Crawler guess charset from html 2013-09-19 18:37:12 +02:00
EventDispatcher updated the composer install command to reflect changes in Composer 2013-09-18 09:27:26 +02:00
Filesystem updated the composer install command to reflect changes in Composer 2013-09-18 09:27:26 +02:00
Finder updated the composer install command to reflect changes in Composer 2013-09-18 09:27:26 +02:00
Form [Intl] Improved FormTypeCsrfExtension to use the type class as default intention if the form name is empty 2013-10-18 13:07:56 +02:00
HttpFoundation fixed wrong started states 2013-10-10 17:50:52 +02:00
HttpKernel bumped Symfony version to 2.2.10 2013-10-10 15:10:05 +02:00
Locale [Locale] added support for the position argument to NumberFormatter::parse() 2013-09-22 19:34:01 +02:00
OptionsResolver updated the composer install command to reflect changes in Composer 2013-09-18 09:27:26 +02:00
Process [Process] Fix #9343 : revert file handle usage on Windows platform 2013-10-21 13:56:16 +02:00
PropertyAccess updated the composer install command to reflect changes in Composer 2013-09-18 09:27:26 +02:00
Routing [Routing] removed extra argument 2013-09-26 21:07:06 +02:00
Security Fixed English usage for existing users. 2013-10-24 21:28:54 +02:00
Serializer Fix some annotates 2013-09-19 11:36:05 +02:00
Stopwatch Make usleep longer and simplify assertions 2013-10-15 18:59:35 +02:00
Templating Fix in ChainLoader.php 2013-10-10 17:51:38 +02:00
Translation PoFileDumper - PO headers 2013-10-09 22:59:37 +02:00
Validator Fix some annotates 2013-09-19 11:36:05 +02:00
Yaml [Yaml] Fixed the escaping of strings starting with a dash when dumping 2013-10-11 00:23:27 +02:00