Archived

forked from https://github.com/symfony/symfony

This repository has been archived on 2023-08-20. You can view files and clone it, but cannot push or open issues or pull requests.

Go to file

Fabien Potencier f6ee66f75a merged branch stof/session_cleanup (PR #3333 ) Commits ------- `2c767d1` [HttpFoundation] Fixed closeSession for the Memcached storage `ec44e68` [HttpFoundation] Fixed the use of the prefix for the Memcached storage `5808773` [HttpFoundation] Fixed a typo and updated the phpdoc for the session `0550bef` Removed methods duplicated from parent class Discussion ---------- Session cleanup This cleans the phpdoc of the refactored session by using inheritdoc in all appropriate places. For the SessionInterface, I added the ``@api`` tag in all methods as the Session class had them. It also fixes a few typos in the variable names. I figured a few things: - the Session class implements some methods that are not part of the SessionInterface. Is it intended or simply a left-over ? - the MemcachedSessionStorage uses a ``prefix`` property which does not exist. This is clearly a copy-paste from the MemcacheSessionStorage which has it. It also call the ``Memcached#close`` method which does not exist according to PhpStorm. @drak could you check this class ? I don't know Memcached at all. - as I said on the refactoring PR, the Serializable implementation of the Session class seems totally wrong as the SessionStorage is not serializable. /cc @drak --------------------------------------------------------------------------- by drak at 2012-02-12T02:09:38Z @stof there is a ticket about this, the problem exists from Symfony 2.0 also - refs #3000 PDOSessionStorage --------------------------------------------------------------------------- by drak at 2012-02-12T02:10:12Z @stof I will look at the memcache issue and make a quick PR --------------------------------------------------------------------------- by stof at 2012-02-12T02:11:07Z @drak the issue could exist with any SessionStorage as your SessionStorageInterface does not enforce making it serializable --------------------------------------------------------------------------- by stof at 2012-02-12T02:14:15Z @drak note that this PR already fixes 2 typo in the memcached storage. It seems like some tests are missing for it as they should have been found (they would have raised a notice in the constructor) --------------------------------------------------------------------------- by drak at 2012-02-12T02:14:50Z Afaik, only PDO is not serializable@ but the `Serializable` is on the SessionInterface. The problem is with #3000, the serialization is necessary but impossible. --------------------------------------------------------------------------- by stof at 2012-02-12T02:21:42Z @drak what about a Mongo storage or things like that ? --------------------------------------------------------------------------- by drak at 2012-02-12T02:23:58Z @stof Since you've started this PR would you mind removing `$prefix.` from the `*session()` methods in `MemcachedSessionStorage` - they are not required because Memcached handles prefixes itself. I'll write some tests in another PR for them. I guess I omitted it because at the time I didn't have them on my test env. --------------------------------------------------------------------------- by drak at 2012-02-12T02:24:35Z @stof - Let's take the serialization issue to #3000 because it's being discussed there. --------------------------------------------------------------------------- by stof at 2012-02-12T02:27:27Z @drak what about the ``close()`` method which does not exist in the Memcached class ? --------------------------------------------------------------------------- by drak at 2012-02-12T03:58:11Z The method just needs to `return true;`.		2012-02-12 13:06:54 +01:00
src/Symfony	[HttpFoundation] Fixed closeSession for the Memcached storage	2012-02-12 12:08:35 +01:00
tests	[HttpFoundation] Added tests for Session class.	2012-02-12 10:23:04 +05:45
.gitignore	Added vendor directory to .gitignore	2010-06-24 10:44:28 +02:00
.travis.yml	also test PHP 5.3.2, since this is the official lowest supported PHP version	2011-12-26 01:15:21 +01:00
autoload.php.dist	[Tests] [Propel] Added some tests for the ModelChoiceList class	2012-02-05 23:08:07 +01:00
CHANGELOG-2.0.md	updated CHANGELOG for 2.0.9	2012-01-06 07:48:27 +01:00
CHANGELOG-2.1.md	merged branch bschussek/issue3022 (PR #3322 )	2012-02-12 00:48:39 +01:00
check_cs	[Check CS] don't replace 'else if' on twig files (closes #2961 )	2011-12-27 16:10:32 +01:00
composer.json	[MonologBundle] moved bundle to its own repository	2012-02-09 10:22:21 +01:00
CONTRIBUTORS.md	update CONTRIBUTORS for 2.0.9	2012-01-06 07:49:05 +01:00
LICENSE	added the LICENSE file for the YAML component	2011-02-18 11:52:11 +01:00
phpunit.xml.dist	[Security] cleaned up opt-in to benchmark test	2011-03-06 20:06:13 +01:00
README.md	set travis-ci icon to master	2011-11-23 11:36:09 +01:00
UPGRADE-2.1.md	merged branch bschussek/issue3022 (PR #3322 )	2012-02-12 00:48:39 +01:00
vendors.php	[MonologBundle] moved bundle to its own repository	2012-02-09 10:22:21 +01:00

README.md

README

What is Symfony2?

Symfony2 is a PHP 5.3 full-stack web framework. It is written with speed and flexibility in mind. It allows developers to build better and easy to maintain websites with PHP.

Symfony can be used to develop all kind of websites, from your personal blog to high traffic ones like Dailymotion or Yahoo! Answers.

Requirements

Symfony2 is only supported on PHP 5.3.2 and up.

Installation

The best way to install Symfony2 is to download the Symfony Standard Edition available at http://symfony.com/download.

Documentation

The "Quick Tour" tutorial gives you a first feeling of the framework. If, like us, you think that Symfony2 can help speed up your development and take the quality of your work to the next level, read the official Symfony2 documentation.

Contributing

Symfony2 is an open source, community-driven project. If you'd like to contribute, please read the Contributing Code part of the documentation. If you're submitting a pull request, please follow the guidelines in the Submitting a Patch section.